Skip to content

Commit 55dd42b

Browse files
committed
Fixing #220 - Program Queries fail
* Error when creating an Alert Rules based on program name * Preparing for release 4.2
1 parent 35fee95 commit 55dd42b

4 files changed

Lines changed: 19 additions & 4 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414

1515
* issue#218: SQL errors when deleting messages
1616

17+
* issue#220: Error when creating an Alert Rules based on program name
18+
1719
* issue#222: PHP Deprecation Errors in PHP 8.2
1820

1921
--- 4.1 ---

INFO

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
; +-------------------------------------------------------------------------+
2-
; | Copyright (C) 2004-2023 The Cacti Group |
2+
; | Copyright (C) 2004-2024 The Cacti Group |
33
; | |
44
; | This program is free software; you can redistribute it and/or |
55
; | modify it under the terms of the GNU General Public License |

config.php.dist

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?php
22
/*
33
+-------------------------------------------------------------------------+
4-
| Copyright (C) 2004-2023 The Cacti Group |
4+
| Copyright (C) 2004-2024 The Cacti Group |
55
| |
66
| This program is free software; you can redistribute it and/or |
77
| modify it under the terms of the GNU General Public License |
@@ -64,10 +64,11 @@ if (!$use_cacti_db) {
6464
//$syslog_install_options['id'] = 'syslog';
6565

6666
/* field in the incomming table */
67-
$syslog_incoming_config['timeField'] = 'logtime';
6867
$syslog_incoming_config['priorityField'] = 'priority_id';
6968
$syslog_incoming_config['facilityField'] = 'facility_id';
70-
$syslog_incoming_config['hostField'] = 'host_id';
69+
$syslog_incoming_config['programField'] = 'program';
70+
$syslog_incoming_config['timeField'] = 'logtime';
71+
$syslog_incoming_config['hostField'] = 'host';
7172
$syslog_incoming_config['textField'] = 'message';
7273
$syslog_incoming_config['id'] = 'seq';
7374

functions.php

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1612,6 +1612,10 @@ function syslog_process_alert($alert, $sql, $params, $count, $hostname = '') {
16121612
function syslog_get_alert_sql(&$alert, $uniqueID) {
16131613
global $syslogdb_default, $syslog_incoming_config;
16141614

1615+
if (!isset($syslog_incoming_config['programField'])) {
1616+
$syslog_incoming_config['programField'] = 'program';
1617+
}
1618+
16151619
$params = array();
16161620
$sql = '';
16171621

@@ -1653,6 +1657,14 @@ function syslog_get_alert_sql(&$alert, $uniqueID) {
16531657
WHERE `' . $syslog_incoming_config['hostField'] . '` = ?
16541658
AND `status` = ?' . $uniqueID;
16551659

1660+
$params[] = $alert['message'];
1661+
$params[] = $uniqueID;
1662+
} elseif ($alert['type'] == 'program') {
1663+
$sql = 'SELECT *
1664+
FROM `' . $syslogdb_default . '`.`syslog_incoming`
1665+
WHERE `' . $syslog_incoming_config['programField'] . '` = ?
1666+
AND `status` = ?' . $uniqueID;
1667+
16561668
$params[] = $alert['message'];
16571669
$params[] = $uniqueID;
16581670
} elseif ($alert['type'] == 'sql') {

0 commit comments

Comments
 (0)