Skip to content

Commit 8193acf

Browse files
ddb4githubJing Chen
andauthored
Fixed: #125 XSS vulnerabilities for alert/reports page (#131)
Co-authored-by: Jing Chen <three_chenjing@sohu.com>
1 parent 3e20494 commit 8193acf

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

syslog_alerts.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -795,8 +795,8 @@ function syslog_alerts() {
795795
form_selectable_cell(($alert['method'] == 1 ? $alert['num']:__('N/A', 'syslog')), $alert['id']);
796796
form_selectable_cell((($alert['enabled'] == 'on') ? __('Yes', 'syslog'):__('No', 'syslog')), $alert['id']);
797797
form_selectable_cell($message_types[$alert['type']], $alert['id']);
798-
form_selectable_cell(title_trim($alert['message'],60), $alert['id']);
799-
form_selectable_cell((substr_count($alert['email'], ',') ? __('Multiple', 'syslog'):$alert['email']), $alert['id']);
798+
form_selectable_cell(title_trim(html_escape($alert['message']),60), $alert['id']);
799+
form_selectable_cell((substr_count($alert['email'], ',') ? __('Multiple', 'syslog'):html_escape($alert['email'])), $alert['id']);
800800
form_selectable_cell(date('Y-m-d H:i:s', $alert['date']), $alert['id']);
801801
form_selectable_cell($alert['user'], $alert['id']);
802802
form_checkbox_cell($alert['name'], $alert['id']);

syslog_reports.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -685,7 +685,7 @@ function syslog_report() {
685685
form_selectable_cell(filter_value(title_trim($report['name'], read_config_option('max_title_length')), get_request_var('filter'), $config['url_path'] . 'plugins/syslog/syslog_reports.php?action=edit&id=' . $report['id']), $report['id']);
686686
form_selectable_cell((($report['enabled'] == 'on') ? __('Yes', 'syslog'):__('No', 'syslog')), $report['id']);
687687
form_selectable_cell($message_types[$report['type']], $report['id']);
688-
form_selectable_cell($report['message'], $report['id']);
688+
form_selectable_cell(html_escape($report['message']), $report['id']);
689689
form_selectable_cell($syslog_freqs[$report['timespan']], $report['id']);
690690
form_selectable_cell($syslog_times[$report['timepart']], $report['id']);
691691
form_selectable_cell(($report['lastsent'] == 0 ? __('Never', 'syslog'): date('Y-m-d H:i:s', $report['lastsent'])), $report['id']);

0 commit comments

Comments
 (0)