Resolving Issue #91

Page become blank after collecting multiple host syslog info

Author: cigamit

README.md

@@ -77,6 +77,9 @@ The sylog plugin has been in development for well over a decade with increasing
 
 ## ChangeLog
 
+--- develop ---
+* issue#91: Page become blank after collecting multiple host syslog info
+
 --- 2.2  ---
 * feature: Allow for reprocess message per rule 
 * issue#66: Filter for All Programs can not work well

functions.php

@@ -583,8 +583,8 @@ function sql_hosts_where($tab) {
 	$hostfilter     = '';
 	$hostfilter_log = '';
 
-	if (!isempty_request_var('host') && get_request_var('host') != 'null') {
-		$hostarray = explode(',', get_request_var('host'));
+	if (!isempty_request_var('host') && get_nfilter_request_var('host') != 'null') {
+		$hostarray = explode(',', trim(get_nfilter_request_var('host')));
 		if ($hostarray[0] != '0') {
 			foreach($hostarray as $host_id) {
 				input_validate_input_number($host_id);

syslog.php

@@ -190,10 +190,9 @@ function syslog_statistics() {
             'options' => array('options' => 'sanitize_search_string')
             ),
         'host' => array(
-            'filter' => FILTER_CALLBACK,
+            'filter' => FILTER_VALIDATE_IS_NUMERIC_LIST,
             'pageset' => true,
             'default' => '',
-            'options' => array('options' => 'sanitize_search_string')
             ),
         'facility' => array(
             'filter' => FILTER_CALLBACK,
@@ -645,10 +644,9 @@ function syslog_request_validation($current_tab, $force = false) {
             'default' => '-1'
 			),
         'host' => array(
-            'filter' => FILTER_CALLBACK,
+            'filter' => FILTER_VALIDATE_IS_NUMERIC_LIST,
             'pageset' => true,
-            'default' => '0',
-            'options' => array('options' => 'sanitize_search_string')
+            'default' => '',
             ),
         'efacility' => array(
             'filter' => FILTER_CALLBACK,
@@ -1280,7 +1278,7 @@ function timeshiftFilterRight() {
 						<td>
 							<?php print __('Devices', 'syslog');?>
 						</td>
-						<td class='even'>
+						<td>
 							<select id='host' multiple style='display:none; width: 150px; overflow: scroll;'>
 								<?php if ($tab == 'syslog') { ?><option id='host_all' value='0'<?php if (get_request_var('host') == 'null' || get_request_var('host') == '0' || $reset_multi) { ?> selected<?php } ?>><?php print __('Show All Devices', 'syslog');?></option><?php } else { ?>
 								<option id='host_all' value='0'<?php if (get_request_var('host') == 'null' || get_request_var('host') == 0 || $reset_multi) { ?> selected<?php } ?>><?php print __('Show All Logs', 'syslog');?></option>
@@ -1294,15 +1292,16 @@ function timeshiftFilterRight() {
 									$hosts_where
 									ORDER BY host");
 
-								$selected = explode(' ', get_request_var('host'));
+								$selected = explode(',', get_request_var('host'));
+
 								if (cacti_sizeof($hosts)) {
 									foreach ($hosts as $host) {
 										if (!is_ipaddress($host['host'])) {
 											$parts = explode('.', $host['host']);
 											$host['host'] = $parts[0];
 										}
 
-										print "<option value='" . $host["host_id"] . "'";
+										print "<option value='" . $host['host_id'] . "'";
 										if (cacti_sizeof($selected)) {
 											if (in_array($host['host_id'], $selected)) {
 												print ' selected';