Skip to content

Add on-chain per-developer rate-limit enforcement to vault.deduct #480

Description

@greatest0fallt1me

Description

This is a smart-contract issue for the GrantFox campaign. Introduce per-developer token-bucket state in vault storage so deducts can be rate-limited at the contract layer as a defense-in-depth backstop.

Requirements and Context

  • Bucket size/refill from developer-config
  • Reject with RateLimited error when empty
  • Refill amortized over ledger ticks
  • Test edge cases at boundary
  • Must be secure, tested, and documented
  • Should be efficient and easy to review

Suggested Execution

  1. Fork the repo and create a branch
    git checkout -b feature/vault-rate-limit
  2. Implement changes
    • contracts/vault/src/lib.rs
    • contracts/vault/src/rate_limit.rs (new)
    • contracts/vault/src/test.rs
  3. Test and commit
    • Run the repo's standard test suite and lint
    • Cover edge cases; include output in the PR

Example commit message

feat: on-chain per-developer rate-limit on vault.deduct

Acceptance Criteria

  • Bucket persists
  • Refill correct
  • Rejects on empty
  • Edge cases tested

Guidelines

  • Minimum 95% test coverage with cargo test
  • require_auth on every state-changing entrypoint
  • Overflow-safe math; no unwrap() in production paths
  • Clear NatSpec-style /// rustdoc
  • Timeframe: 96 hours

Metadata

Metadata

Labels

GRANTFOX OSSGrantFox open-source campaign taskOFFICIAL CAMPAIGNOfficial GrantFox campaign issueStellar WaveIssues in the Stellar wave programrustRust implementationsecuritySecurity hardeningsmart-contractSoroban smart-contract worksorobanSoroban SDK / Stellar

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions