Bug: revenue_pool emits inconsistent event shape vs schema documentation

[greatest0fallt1me]

Description

This is a smart-contract issue for the GrantFox campaign. Two events in revenue_pool include a 4th topic that doesn't exist in EVENT_SCHEMA.md.

Requirements and Context

• Identify the mismatch
• Choose schema vs code as source-of-truth
• Fix the side that's wrong
• Add CI check
• Must be secure, tested, and documented
• Should be efficient and easy to review

Suggested Execution

1. Fork the repo and create a branch

   git checkout -b bug/revenue-event-shape

2. Implement changes
   • contracts/revenue_pool/src/events.rs
   • docs/EVENT_SCHEMA.md
   • scripts/check-event-shape.sh
3. Test and commit
   • Run the repo's standard test suite and lint
   • Cover edge cases; include output in the PR

Example commit message

fix: revenue_pool event shape vs schema

Acceptance Criteria

• Mismatch identified
• Code matches docs
• CI gate works
• No regressions

Guidelines

• Minimum 95% test coverage with cargo test
• require_auth on every state-changing entrypoint
• Overflow-safe math; no unwrap() in production paths
• Clear NatSpec-style /// rustdoc
• Timeframe: 96 hours

[gaiabio12-design]

The mismatch is in contracts/revenue_pool/src/events.rs where event_admin_changed and event_admin_transfer_started are emitting a 4th topic parameter that EVENT_SCHEMA.md doesn't define — I'll audit both functions against the schema, determine which is the source-of-truth (likely the schema since it's the indexer contract), and remove the extra topic from the Rust event constructors. Can have a PR up tomorrow with the matching schema test added to the CI gate.

[RemmyAcee]

@RemmyAcee has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

I've reviewed the issue and understand the requirements. I'd love to work on this and submit a clean PR that meets the acceptance criteria.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @RemmyAcee to this issue.

[Okorie2000-code]

@Okorie2000-code has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

Hi Maintainer, can I work on this?

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Okorie2000-code to this issue.

[Ajibose]

@Ajibose has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

Can i work on this

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Ajibose to this issue.

[gaiabio12-design]

Thanks for the assignment. I'll start investigating the event emission inconsistency and open a PR within 2 days with a fix and updated schema documentation.

[Derry255]

@Derry255 has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

Hello maintainer, I am confident to take on this task, implement a good fix and open a cleanly ready to merge PR

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Derry255 to this issue.

[Osuolale1]

@Osuolale1 has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

I would love to work on this.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Osuolale1 to this issue.