From 531a4c9733cc5c438995f17d02d12c57e76f1dfd Mon Sep 17 00:00:00 2001
From: Oba <republicoba1@gmail.com>
Date: Sat, 27 Jun 2026 23:22:48 +0100
Subject: [PATCH] test(settlement): add full struct snapshot tests for
 PaymentReceivedEvent

- Add test_payment_received_event_snapshot_to_pool: asserts the complete
  PaymentReceivedEvent struct (from_vault, amount, to_pool, developer) in
  a single assert_eq! for the to_pool=true branch
- Add test_payment_received_event_snapshot_to_developer: same full-struct
  assertion for the to_pool=false / developer branch
- These complement the existing field-by-field event shape tests by
  catching any future change to the event's structure or values in one
  comparison, rather than requiring each field to be checked individually

Note: contracts/settlement currently has 34 pre-existing compile errors
on main (missing Severity/AdminBroadcast types in lib.rs, argument
mismatches in unrelated withdraw_developer_balance tests, missing Box
imports in test_invariant.rs) that block cargo test from running. These
are unrelated to this change and were verified to exist on main prior to
this branch via git stash comparison. This PR does not attempt to fix
them as they are out of scope for this issue.

Closes #491
---
 contracts/settlement/src/test.rs | 83 ++++++++++++++++++++++++++++++++
 1 file changed, 83 insertions(+)

diff --git a/contracts/settlement/src/test.rs b/contracts/settlement/src/test.rs
index e5c6881..094d261 100644
--- a/contracts/settlement/src/test.rs
+++ b/contracts/settlement/src/test.rs
@@ -1252,6 +1252,89 @@ mod settlement_tests {
         assert!(data.developer.is_none());
     }
 
+    /// Snapshot: asserts the full `PaymentReceivedEvent` struct shape and values
+    /// in a single comparison, for the to_pool=true branch. Any future change to
+    /// the struct's fields or this call's emitted values will fail this test,
+    /// making accidental output-structure drift impossible to miss.
+    #[test]
+    fn test_payment_received_event_snapshot_to_pool() {
+        use soroban_sdk::testutils::Events as _;
+        use soroban_sdk::{IntoVal, Symbol};
+
+        let env = Env::default();
+        env.mock_all_auths();
+        let admin = Address::generate(&env);
+        let vault = Address::generate(&env);
+        let addr = env.register(CalloraSettlement, ());
+        let client = CalloraSettlementClient::new(&env, &addr);
+        client.init(&admin, &vault);
+
+        client.receive_payment(&vault, &750i128, &true, &None);
+
+        let events = env.events().all();
+        let ev = events
+            .iter()
+            .find(|e| {
+                !e.1.is_empty() && {
+                    let t: Symbol = e.1.get(0).unwrap().into_val(&env);
+                    t == Symbol::new(&env, "payment_received")
+                }
+            })
+            .expect("expected payment_received event");
+
+        let data: crate::PaymentReceivedEvent = ev.2.into_val(&env);
+
+        let expected = crate::PaymentReceivedEvent {
+            from_vault: vault.clone(),
+            amount: 750i128,
+            to_pool: true,
+            developer: None,
+        };
+
+        assert_eq!(data, expected);
+    }
+
+    /// Snapshot: asserts the full `PaymentReceivedEvent` struct shape and values
+    /// in a single comparison, for the to_pool=false (developer) branch.
+    #[test]
+    fn test_payment_received_event_snapshot_to_developer() {
+        use soroban_sdk::testutils::Events as _;
+        use soroban_sdk::{IntoVal, Symbol};
+
+        let env = Env::default();
+        env.mock_all_auths();
+        let admin = Address::generate(&env);
+        let vault = Address::generate(&env);
+        let developer = Address::generate(&env);
+        let addr = env.register(CalloraSettlement, ());
+        let client = CalloraSettlementClient::new(&env, &addr);
+        client.init(&admin, &vault);
+
+        client.receive_payment(&vault, &321i128, &false, &Some(developer.clone()));
+
+        let events = env.events().all();
+        let ev = events
+            .iter()
+            .find(|e| {
+                !e.1.is_empty() && {
+                    let t: Symbol = e.1.get(0).unwrap().into_val(&env);
+                    t == Symbol::new(&env, "payment_received")
+                }
+            })
+            .expect("expected payment_received event");
+
+        let data: crate::PaymentReceivedEvent = ev.2.into_val(&env);
+
+        let expected = crate::PaymentReceivedEvent {
+            from_vault: vault.clone(),
+            amount: 321i128,
+            to_pool: false,
+            developer: Some(developer.clone()),
+        };
+
+        assert_eq!(data, expected);
+    }
+
     #[test]
     fn test_payment_received_and_balance_credited_events_to_developer() {
         use soroban_sdk::testutils::Events as _;