create local reusable actions

Author: loitly

.github/actions/firefly-version/action.yml

@@ -0,0 +1,37 @@
+name: 'Resolve Firefly Version'
+description: 'Extracts the firefly.tag.name from app.config.'
+
+inputs:
+  config_path:
+    description: 'Path to the app.config file'
+    required: true
+
+outputs:
+  ref:
+    description: 'The extracted firefly tag'
+    value: ${{ steps.extract.outputs.ref }}
+
+runs:
+  using: 'composite'
+  steps:
+    - id: extract
+      shell: bash
+      run: |
+        set -euo pipefail
+
+        if [[ ! -f "${{ inputs.config_path }}" ]]; then
+          echo "::error::Configuration file not found at: ${{ inputs.config_path }}"
+          exit 1
+        fi
+
+        ref="$(
+          grep -E '^[[:space:]]*firefly\.tag\.name[[:space:]]*=' "${{ inputs.config_path }}" | cut -d'"' -f2
+        )"
+
+        if [[ -z "$ref" ]]; then
+          echo "ERROR: firefly.tag.name not found or malformed in ${{ inputs.config_path }}"
+          exit 1
+        fi
+
+        echo "Using firefly tag: $ref"
+        echo "ref=$ref" >> "$GITHUB_OUTPUT"

.github/actions/resolve-tags/action.yml

@@ -0,0 +1,35 @@
+name: 'Resolve tags'
+description: 'Determines the git ref and image tag based on inputs and event type'
+
+inputs:
+  git_tag:
+    description: 'Manual git tag input'
+    required: false
+  img_tag:
+    description: 'Manual image tag input'
+    required: false
+
+outputs:
+  ref:
+    description: "The resolved git reference"
+    value: ${{ github.event_name == 'release' && github.event.release.tag_name || inputs.git_tag }}
+  tag:
+    description: "The resolved image tag"
+    value: ${{ steps.logic.outputs.tag }}
+
+runs:
+  using: "composite"
+  steps:
+    - id: logic
+      shell: bash
+      run: |
+        set -euo pipefail
+        if [[ "${{ github.event_name }}" == "release" ]]; then
+          echo "tag=${{ github.event.release.name }}" >> $GITHUB_OUTPUT
+        else
+          FINAL_TAG="${{ inputs.img_tag }}"
+          if [[ -z "$FINAL_TAG" ]]; then
+            FINAL_TAG="${{ inputs.git_tag }}"
+          fi
+          echo "tag=$FINAL_TAG" >> $GITHUB_OUTPUT
+        fi

.github/workflows/build_publish.yml

@@ -28,34 +28,22 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      # ------------------------------------------------------------
-      # Resolve checkout ref and image tag
-      # - If triggered by a release event, use the release tag for both ref and image tag
-      # - Otherwise, prefer `inputs.img_tag` (short form) and fallback to `inputs.git_tag`
-      # This ensures `git_tag` is required and independent of `img_tag`.
-      # ------------------------------------------------------------
+      # -------------------------------------------------------------
+      # Use local action to resolve git ref and image tag from inputs
+      # -------------------------------------------------------------
       - name: Resolve tags
         id: resolve_tags
-        run: |
-          if [[ "${{ github.event_name }}" == "release" ]]; then
-            echo "ref=${{ github.event.release.tag_name }}" >> $GITHUB_OUTPUT
-            echo "tag=${{ github.event.release.name }}" >> $GITHUB_OUTPUT
-          else
-            echo "ref=${{ inputs.git_tag }}" >> $GITHUB_OUTPUT
-            if [[ -n "${{ inputs.img_tag }}" ]]; then
-              echo "tag=${{ inputs.img_tag }}" >> $GITHUB_OUTPUT
-            else
-              echo "tag=${{ inputs.git_tag }}" >> $GITHUB_OUTPUT
-            fi
-          fi
+        uses: firefly/.github/actions/resolve-tags
+        with:
+          git_tag: ${{ inputs.git_tag }}
+          img_tag: ${{ inputs.img_tag }}
 
       # ------------------------------------------------------------
-      # Checkout firefly repo at the resolved ref
+      # Checkout firefly (this repo)
       # ------------------------------------------------------------
       - name: Checkout Firefly
         uses: actions/checkout@v4
         with:
-          repository: Caltech-IPAC/firefly
           ref: ${{ steps.resolve_tags.outputs.ref }}
           path: firefly
 
@@ -99,7 +87,8 @@ jobs:
           file: firefly/docker/Dockerfile
           platforms: linux/amd64,linux/arm64
           push: ${{ github.event_name == 'release' || inputs.push_image == 'true' }}
-          tags: ghcr.io/${{ github.repository }}:${{ steps.resolve_tags.outputs.tag }}
+          # docker buildx does not allow uppercase letters in tags, so we convert to lowercase here
+          tags: ghcr.io/caltech-ipac/firefly:${{ steps.resolve_tags.outputs.tag }}
           build-args: |
             env=ops
           cache-from: type=gha