Refactoring out direct API call to external service

- moving to webhooks

Author: ryanarakawa

app/models/submitter.rb

@@ -139,7 +139,8 @@ def export_submission_on_status_change
     status_fields = %w[completed_at declined_at opened_at sent_at]
     return unless saved_changes.keys.intersect?(status_fields)
 
-    ExportSubmissionService.new(submission).call
+    # CP-12761: Disabled - migrating to webhooks. Remove when ATS /api/docuseal/submissions endpoint is cleaned up.
+    # ExportSubmissionService.new(submission).call
   rescue StandardError => e
     Rails.logger.error("Failed to export submission on status change: #{e.message}")
   end

spec/models/submitter_spec.rb

@@ -134,93 +134,30 @@
   end
 
   describe '#export_submission_on_status_change' do
-    let(:export_location) { create(:export_location, :with_submissions_endpoint) }
-    let(:export_service) { instance_double(ExportSubmissionService) }
-
+    # CP-12761: ExportSubmissionService is disabled - submission sync migrated to webhooks.
+    # These tests verify the service is not called on any status change.
     before do
-      allow(ExportLocation).to receive(:default_location).and_return(export_location)
-      allow(ExportSubmissionService).to receive(:new).with(submission).and_return(export_service)
-      allow(export_service).to receive(:call).and_return(true)
+      allow(ExportSubmissionService).to receive(:new)
     end
 
-    context 'when status-related field changes' do
-      it 'calls ExportSubmissionService when completed_at changes' do
-        submitter.update!(completed_at: Time.current)
-        expect(ExportSubmissionService).to have_received(:new).with(submission)
-        expect(export_service).to have_received(:call)
-      end
-
-      it 'calls ExportSubmissionService when declined_at changes' do
-        submitter.update!(declined_at: Time.current)
-        expect(ExportSubmissionService).to have_received(:new).with(submission)
-        expect(export_service).to have_received(:call)
-      end
-
-      it 'calls ExportSubmissionService when opened_at changes' do
-        submitter.update!(opened_at: Time.current)
-        expect(ExportSubmissionService).to have_received(:new).with(submission)
-        expect(export_service).to have_received(:call)
-      end
-
-      it 'calls ExportSubmissionService when sent_at changes' do
-        submitter.update!(sent_at: Time.current)
-        expect(ExportSubmissionService).to have_received(:new).with(submission)
-        expect(export_service).to have_received(:call)
-      end
+    it 'does not call ExportSubmissionService when completed_at changes' do
+      submitter.update!(completed_at: Time.current)
+      expect(ExportSubmissionService).not_to have_received(:new)
     end
 
-    context 'when non-status field changes' do
-      it 'does not call ExportSubmissionService when email changes' do
-        submitter.update!(email: 'new@example.com')
-        expect(ExportSubmissionService).not_to have_received(:new)
-        expect(export_service).not_to have_received(:call)
-      end
-
-      it 'does not call ExportSubmissionService when name changes' do
-        submitter.update!(name: 'New Name')
-        expect(ExportSubmissionService).not_to have_received(:new)
-        expect(export_service).not_to have_received(:call)
-      end
+    it 'does not call ExportSubmissionService when declined_at changes' do
+      submitter.update!(declined_at: Time.current)
+      expect(ExportSubmissionService).not_to have_received(:new)
     end
 
-    context 'when export service raises an error' do
-      before do
-        allow(export_service).to receive(:call).and_raise(StandardError.new('Export failed'))
-        allow(Rails.logger).to receive(:error)
-      end
-
-      it 'logs the error and does not re-raise' do
-        expect { submitter.update!(completed_at: Time.current) }.not_to raise_error
-        expect(Rails.logger).to have_received(:error).with(
-          'Failed to export submission on status change: Export failed'
-        )
-      end
-    end
-
-    context 'when ExportLocation.default_location returns nil' do
-      before do
-        allow(ExportLocation).to receive(:default_location).and_return(nil)
-        allow(export_service).to receive(:call).and_return(false)
-      end
-
-      it 'calls ExportSubmissionService but service handles nil export location' do
-        submitter.update!(completed_at: Time.current)
-        expect(ExportSubmissionService).to have_received(:new).with(submission)
-        expect(export_service).to have_received(:call)
-      end
+    it 'does not call ExportSubmissionService when opened_at changes' do
+      submitter.update!(opened_at: Time.current)
+      expect(ExportSubmissionService).not_to have_received(:new)
     end
 
-    context 'when export location has no submissions_endpoint' do
-      before do
-        allow(export_location).to receive(:submissions_endpoint).and_return(nil)
-        allow(export_service).to receive(:call).and_return(false)
-      end
-
-      it 'calls ExportSubmissionService but service handles missing endpoint' do
-        submitter.update!(completed_at: Time.current)
-        expect(ExportSubmissionService).to have_received(:new).with(submission)
-        expect(export_service).to have_received(:call)
-      end
+    it 'does not call ExportSubmissionService when sent_at changes' do
+      submitter.update!(sent_at: Time.current)
+      expect(ExportSubmissionService).not_to have_received(:new)
     end
   end