update to non-predicate method for rubocop

we used to just return true or false, but we are using nil to signify that the submitter uuid is not found for the controller so the error can be surfaced to the user.

Author: ryanarakawa

app/controllers/submit_form_controller.rb

@@ -22,7 +22,7 @@ def show
 
     if @form_configs[:enforce_signing_order] ||
        submission.template_signing_order.in?(%w[employee_then_manager manager_then_employee])
-      signing_order = Submitters.current_submitter_order?(@submitter)
+      signing_order = Submitters.current_submitter_order(@submitter)
 
       if signing_order.nil?
         flash.now[:alert] = I18n.t('user_id_did_not_match_please_try_again_or_contact_support')

lib/submitters.rb

@@ -162,7 +162,7 @@ def send_signature_requests(submitters, delay_seconds: nil)
     end
   end
 
-  def current_submitter_order?(submitter)
+  def current_submitter_order(submitter)
     submitter_items = submitter.submission.template_submitters || submitter.submission.template.submitters
     submitters_order = submitter.submission.template_signing_order
 

spec/lib/submitters_spec.rb

@@ -3,7 +3,7 @@
 require 'rails_helper'
 
 RSpec.describe Submitters do
-  describe '.current_submitter_order?' do
+  describe '.current_submitter_order' do
     let(:account) { create(:account) }
     let(:user) { create(:user, account:) }
     let(:template) { create(:template, account:, author: user, submitter_count: 2) }
@@ -24,71 +24,71 @@ def update_order(order)
       before { update_order('manager_then_employee') }
 
       it 'returns true for the manager (index 1)' do
-        expect(described_class.current_submitter_order?(manager.reload)).to be true
+        expect(described_class.current_submitter_order(manager.reload)).to be true
       end
 
       it 'returns false for the employee when manager has not completed' do
         manager.update!(completed_at: nil)
-        expect(described_class.current_submitter_order?(employee.reload)).to be false
+        expect(described_class.current_submitter_order(employee.reload)).to be false
       end
 
       it 'returns true for the employee when manager has completed' do
         manager.update!(completed_at: Time.current)
-        expect(described_class.current_submitter_order?(employee.reload)).to be true
+        expect(described_class.current_submitter_order(employee.reload)).to be true
       end
     end
 
     context 'with employee_then_manager order' do
       before { update_order('employee_then_manager') }
 
       it 'returns true for the first submitter (Employee)' do
-        expect(described_class.current_submitter_order?(employee.reload)).to be true
+        expect(described_class.current_submitter_order(employee.reload)).to be true
       end
 
       it 'returns false for the manager when employee has not completed' do
         employee.update!(completed_at: nil)
-        expect(described_class.current_submitter_order?(manager.reload)).to be false
+        expect(described_class.current_submitter_order(manager.reload)).to be false
       end
 
       it 'returns true for the manager when employee has completed' do
         employee.update!(completed_at: Time.current)
-        expect(described_class.current_submitter_order?(manager.reload)).to be true
+        expect(described_class.current_submitter_order(manager.reload)).to be true
       end
     end
 
     context 'with simultaneous order' do
       before { update_order('simultaneous') }
 
       it 'returns true for the first submitter' do
-        expect(described_class.current_submitter_order?(employee.reload)).to be true
+        expect(described_class.current_submitter_order(employee.reload)).to be true
       end
 
       it 'returns true for the second submitter when the first has completed' do
         employee.update!(completed_at: Time.current)
-        expect(described_class.current_submitter_order?(manager.reload)).to be true
+        expect(described_class.current_submitter_order(manager.reload)).to be true
       end
 
       it 'returns false for the second submitter when the first has not completed' do
         employee.update!(completed_at: nil)
-        expect(described_class.current_submitter_order?(manager.reload)).to be false
+        expect(described_class.current_submitter_order(manager.reload)).to be false
       end
     end
 
     context 'with single_sided order' do
       before { update_order('single_sided') }
 
       it 'returns true for the first submitter' do
-        expect(described_class.current_submitter_order?(employee.reload)).to be true
+        expect(described_class.current_submitter_order(employee.reload)).to be true
       end
 
       it 'returns true for the second submitter when the first has completed' do
         employee.update!(completed_at: Time.current)
-        expect(described_class.current_submitter_order?(manager.reload)).to be true
+        expect(described_class.current_submitter_order(manager.reload)).to be true
       end
 
       it 'returns false for the second submitter when the first has not completed' do
         employee.update!(completed_at: nil)
-        expect(described_class.current_submitter_order?(manager.reload)).to be false
+        expect(described_class.current_submitter_order(manager.reload)).to be false
       end
     end
   end