Skip to content

Commit cd14a25

Browse files
committed
completed and awaiting partial updates
* remove form name since we only add form name on creation and don't sync it to external API on edits * change copy to inform the user of the status of the form "Submitted", "Completed", or "Awaiting approval" * add DocuSeal attribution to awaiting status page
1 parent 5ddc761 commit cd14a25

3 files changed

Lines changed: 11 additions & 5 deletions

File tree

app/views/submit_form/awaiting.html.erb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
<%= svg_icon('writing_sign', class: 'w-10 h-10') %>
88
</div>
99
<div dir="auto">
10-
<p class="text-lg font-bold mb-1"><%= @submitter.submission.name || @submitter.submission.template.name %></p>
1110
<p class="text-sm"><%= t('awaiting_completion_by_the_other_party') %></p>
1211
</div>
1312
</div>

app/views/submit_form/completed.html.erb

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,14 @@
77
<%= svg_icon('writing_sign', class: 'w-10 h-10') %>
88
</div>
99
<div>
10-
<p dir="auto" class="text-lg font-bold mb-1"><%= @submitter.submission.name || @submitter.submission.template.name %></p>
11-
<p dir="auto" class="text-sm">
12-
<%= t(@submitter.with_signature_fields? ? 'signed_on_time' : 'completed_on_time', time: l(@submitter.completed_at.to_date, format: :long)) %>
13-
</p>
10+
<% if @submitter.submission.requires_approval? && @submitter.submission.approved_at.nil? %>
11+
<p dir="auto" class="text-sm font-bold mb-1"><%= t('submitted_on_time', time: l(@submitter.completed_at.to_date, format: :long)) %></p>
12+
<p dir="auto" class="text-sm"><%= t('awaiting_manager_approval') %></p>
13+
<% else %>
14+
<p dir="auto" class="text-sm">
15+
<%= t(@submitter.with_signature_fields? ? 'signed_on_time' : 'completed_on_time', time: l(@submitter.completed_at.to_date, format: :long)) %>
16+
</p>
17+
<% end %>
1418
</div>
1519
</div>
1620
</div>
@@ -19,3 +23,4 @@
1923
</div>
2024
</div>
2125
</div>
26+
<%= render 'shared/attribution', link_path: '/start', account: @submitter.account %>

config/locales/i18n.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,8 @@ en: &en
130130
you_have_been_invited_to_submit_a_form: You have been invited to submit a form
131131
signed_on_time: 'Signed on %{time}'
132132
completed_on_time: 'Completed on %{time}'
133+
submitted_on_time: 'Submitted on %{time}'
134+
awaiting_manager_approval: 'Awaiting manager approval'
133135
document_has_been_signed_already: Document has been signed already
134136
form_has_been_submitted_already: Form has been submitted already
135137
send_copy_to_email: Send copy to Email

0 commit comments

Comments
 (0)