rubocop and rspec fixes

Author: ryanarakawa

app/controllers/templates_preferences_controller.rb

@@ -17,7 +17,7 @@ def create
 
     old_submitters_order = @template.preferences['submitters_order']
     @template.preferences = @template.preferences.merge(template_params[:preferences])
-    @templahttp://app.lvh.me:3000/retain/team/tasks_list_builder/13/editte.preferences = @template.preferences.reject { |_, v| (v.is_a?(String) || v.is_a?(Hash)) && v.blank? }
+    @template.preferences = @template.preferences.reject { |_, v| (v.is_a?(String) || v.is_a?(Hash)) && v.blank? }
 
     # Handle single_sided case (when template has < 2 unique submitters)
     if @template.unique_submitter_uuids.size < 2 && @template.preferences['submitters_order'].present?

lib/submitters.rb

@@ -168,7 +168,7 @@ def current_submitter_order?(submitter)
 
     ordered_items = submitters_order == 'manager_then_employee' ? submitter_items.reverse : submitter_items
 
-    before_items = ordered_items[0...ordered_items.find_index { |e| e['uuid'] == submitter.uuid }]
+    before_items = ordered_items[0...(ordered_items.find_index { |e| e['uuid'] == submitter.uuid })]
 
     before_items.all? do |item|
       submitter.submission.submitters.find { |e| e.uuid == item['uuid'] }&.completed_at?

spec/lib/submissions/create_from_submitters_spec.rb

@@ -9,15 +9,15 @@
 
   let(:submitter_attrs) do
     template.submitters.map do |s|
-      HashWithIndifferentAccess.new({ 'uuid' => s['uuid'], 'email' => Faker::Internet.email })
+      { 'uuid' => s['uuid'], 'email' => Faker::Internet.email }.with_indifferent_access
     end
   end
 
   def call(template:, submitters_order:)
     described_class.call(
       template:,
       user:,
-      submissions_attrs: [HashWithIndifferentAccess.new({ 'submitters' => submitter_attrs })],
+      submissions_attrs: [{ 'submitters' => submitter_attrs }.with_indifferent_access],
       source: :api,
       submitters_order:
     )

spec/lib/submissions_spec.rb

@@ -19,13 +19,13 @@
       allow(Submitters).to receive(:send_signature_requests)
     end
 
-    def set_order(order)
+    def update_order(order)
       template.update_column(:preferences, { 'submitters_order' => order })
       submission.reload
     end
 
     context 'with employee_then_manager order' do
-      before { set_order('employee_then_manager') }
+      before { update_order('employee_then_manager') }
 
       it 'sends signature request only to the employee first' do
         described_class.send_signature_requests([submission])
@@ -35,7 +35,7 @@ def set_order(order)
     end
 
     context 'with manager_then_employee order' do
-      before { set_order('manager_then_employee') }
+      before { update_order('manager_then_employee') }
 
       it 'sends signature request only to the manager first' do
         described_class.send_signature_requests([submission])
@@ -45,12 +45,12 @@ def set_order(order)
     end
 
     context 'with simultaneous order' do
-      before { set_order('simultaneous') }
+      before { update_order('simultaneous') }
 
       it 'sends signature requests to all submitters' do
         described_class.send_signature_requests([submission])
 
-        expect(Submitters).to have_received(:send_signature_requests).with(match_array([employee, manager]),
+        expect(Submitters).to have_received(:send_signature_requests).with(contain_exactly(employee, manager),
                                                                            delay_seconds: nil)
       end
     end

spec/lib/submitters_spec.rb

@@ -15,13 +15,13 @@
     let!(:employee) { create(:submitter, submission:, uuid: employee_uuid) }
     let!(:manager) { create(:submitter, submission:, uuid: manager_uuid) }
 
-    def set_order(order)
+    def update_order(order)
       template.update_column(:preferences, { 'submitters_order' => order })
       submission.reload
     end
 
     context 'with manager_then_employee order' do
-      before { set_order('manager_then_employee') }
+      before { update_order('manager_then_employee') }
 
       it 'returns true for the manager (index 1)' do
         expect(described_class.current_submitter_order?(manager.reload)).to be true
@@ -39,7 +39,7 @@ def set_order(order)
     end
 
     context 'with employee_then_manager order' do
-      before { set_order('employee_then_manager') }
+      before { update_order('employee_then_manager') }
 
       it 'returns true for the first submitter (Employee)' do
         expect(described_class.current_submitter_order?(employee.reload)).to be true

spec/requests/templates_spec.rb

@@ -253,7 +253,8 @@ def template_body(template)
       ],
       preferences: {
         'request_email_subject' => 'Subject text',
-        'request_email_body' => 'Body Text'
+        'request_email_body' => 'Body Text',
+        'submitters_order' => 'single_sided'
       },
       schema: [
         {