fixed pylint

Author: TimoK93

ctc_metrics/metrics/biological/bc.py

@@ -103,18 +103,20 @@ def is_matching(
             # Check if start frames of the daughters are close enough <= i_max
             temporal_error = abs(t_ref - t_comp)
             if temporal_error > max_i:
-                break
+                continue
             # Verify if children are overlapping spatially
             t_max = max(t_ref, t_comp)
+            # Check if the  daughter match is unique, i.e. the computed track is only assigned to one gt
+            if mapped_comp[t_max].count(j) != 1:
+                continue
             if i in mapped_ref[t_max] and j in mapped_comp[t_max]:
                 ind = mapped_ref[t_max].index(i)
                 if mapped_comp[t_max][ind] == j:
-                    # Check if the  daughter match is unique, i.e. the computed track is only assigned to one gt
-                    if mapped_comp[t_max].count(j) == 1:
-                        # There is a match!
-                        if j not in matched_children:
-                            matched_children.append(j)
-                        break
+                    # There is a match!
+                    if j not in matched_children:
+                        matched_children.append(j)
+                    break
+
 
     if len(matched_children) != len(ref_children):
         return False

ctc_metrics/scripts/evaluate.py

@@ -1,8 +1,8 @@
+import warnings
 import argparse
 from os.path import join, basename
 from multiprocessing import Pool, cpu_count
 import numpy as np
-import warnings
 
 from ctc_metrics.metrics import (
     valid, det, seg, tra, ct, tf, bc, raw_division_metrics, cca, mota, hota, idf1, chota, mtml, faf,
@@ -177,9 +177,7 @@ def calculate_metrics(
     for m in metrics:
         if m.startswith("BC("):
             try:
-                i = int(m[3:-1])
-                if i > max_i_for_bci:
-                    max_i_for_bci = i
+                max_i_for_bci = max(max_i_for_bci, int(m[3:-1]))
                 if "BC" not in metrics:
                     metrics.append("BC")
             except ValueError:
@@ -426,12 +424,7 @@ def main():
         res = evaluate_sequence(
             res=args.res, gt=args.gt, metrics=metrics, threads=args.num_threads)
     # Visualize and store results
-    print_out = res if type(res) is list else [(args.res, res)]
-    for name, output in print_out:
-        print("----------")
-        print(f"{name}")
-        for k,v in output.items():
-            print(f"{k}: {v}")
+    print_results(res)
     if args.csv_file is not None:
         store_results(args.csv_file, res)
 

ctc_metrics/utils/handle_results.py

@@ -8,23 +8,22 @@ def print_results(results: dict):
         results: A dictionary containing the results.
     """
 
-    def print_line(metrics: dict):
+    def print_block(metrics: dict):
         """
         Prints a line of the table.
 
         Args:
             metrics: A list containing the arguments for the line.
         """
-
-        print(*[f"{k}: {'N/A' if v is None else float(v):.5},\t" for k, v
-                in metrics.items()])
+        for k, v in metrics.items():
+            print(f"{k}: {'N/A' if v is None else float(v):.5}")
 
     if isinstance(results, dict):
-        print_line(results)
+        print_block(results)
     elif isinstance(results, list):
         for res in results:
             print(res[0], end=":\t\t")
-            print_line(res[1])
+            print_block(res[1])
 
 
 def store_results(