Update login flow and context to only show warning for hidden SSO

Author: cslzchen

src/main/java/io/cos/cas/osf/authentication/support/OsfInstitutionUtils.java

@@ -31,6 +31,13 @@ public static boolean validateInstitutionForLogin(final JpaOsfDao jpaOsfDao, fin
                 && institution.getSsoAvailability() != SsoAvailability.UNAVAILABLE;
     }
 
+    public static boolean isInstitutionSsoAvailabilityHidden(final JpaOsfDao jpaOsfDao, final String id) {
+        final OsfInstitution institution = jpaOsfDao.findOneInstitutionById(id);
+        return institution != null
+                && institution.getDelegationProtocol() != null
+                && institution.getSsoAvailability() == SsoAvailability.HIDDEN;
+    }
+
     public static String getInstitutionSupportEmail(final JpaOsfDao jpaOsfDao, final String id) {
         final OsfInstitution institution = jpaOsfDao.findOneInstitutionById(id);
         return institution != null ? institution.getSupportEmail() : null;

src/main/java/io/cos/cas/osf/web/flow/login/OsfAbstractLoginPreparationAction.java

@@ -37,6 +37,8 @@ public abstract class OsfAbstractLoginPreparationAction extends AbstractAuthenti
 
     protected static final String PARAMETER_INSTITUTION_ID = "institutionId";
 
+    protected static final String PARAMETER_HIDDEN_SSO_AVAILABILITY = "hiddenSsoAvailability";
+
     protected static final String PARAMETER_ORCID_CLIENT_TYPE = "orcid";
 
     protected static final String PARAMETER_CAS_CLIENT_TYPE = "cas";

src/main/java/io/cos/cas/osf/web/flow/login/OsfDefaultLoginPreparationAction.java

@@ -70,6 +70,7 @@ protected Event doExecute(RequestContext context) {
             loginContext = new OsfCasLoginContext(
                     institutionLogin,
                     institutionId,
+                    Boolean.FALSE,
                     StringUtils.EMPTY,
                     unsupportedInstitutionLogin,
                     orcidRedirect,
@@ -80,6 +81,7 @@ protected Event doExecute(RequestContext context) {
         } else {
             loginContext.setInstitutionLogin(institutionLogin);
             loginContext.setInstitutionId(institutionId);
+            loginContext.setHiddenSsoAvailability(false);
             loginContext.setInstitutionSupportEmail(StringUtils.EMPTY);
             loginContext.setUnsupportedInstitutionLogin(unsupportedInstitutionLogin);
             loginContext.setOrcidLoginUrl(orcidLoginUrl);

src/main/java/io/cos/cas/osf/web/flow/login/OsfInstitutionLoginPreparationAction.java

@@ -81,6 +81,9 @@ protected Event doExecute(RequestContext context) {
                 context.getFlowScope().put(PARAMETER_LOGIN_CONTEXT, loginContext);
                 institutionId = null;
             } else {
+                if (OsfInstitutionUtils.isInstitutionSsoAvailabilityHidden(jpaOsfDao, institutionId)) {
+                    loginContext.setHiddenSsoAvailability(true);
+                }
                 final String institutionSupportEmail = OsfInstitutionUtils.getInstitutionSupportEmail(jpaOsfDao, institutionId);
                 if (institutionSupportEmail != null) {
                     loginContext.setInstitutionSupportEmail(institutionSupportEmail);

src/main/java/io/cos/cas/osf/web/support/OsfCasLoginContext.java

@@ -30,6 +30,8 @@ public class OsfCasLoginContext implements Serializable  {
 
     private String institutionId;
 
+    private boolean hiddenSsoAvailability;
+
     private String institutionSupportEmail;
 
     private boolean unsupportedInstitutionLogin;

src/main/resources/templates/casInstitutionLoginView.html

@@ -32,7 +32,7 @@ <h1 th:utext="#{screen.institutionlogin.heading}"></h1>
                     </section>
 
                     <section class="text-with-mdi text-danger">
-                            <p th:if="${osfCasLoginContext.institutionId}" th:utext="#{screen.institutionlogin.link.hidden}"></p>
+                            <p th:if="${osfCasLoginContext.institutionId != null AND osfCasLoginContext.hiddenSsoAvailability}" th:utext="#{screen.institutionlogin.link.hidden}"></p>
                     </section>
 
                     <section class="text-with-mdi">