initial support for fetching rtl based on window variable

SimulatedGREG · SimulatedGREG · commit f6574d5c9d88 · 2019-11-19T13:54:14.000-06:00
diff --git a/package.json b/package.json
@@ -27,7 +27,7 @@
     "test:only": "cross-env NODE_ENV=test jest",
     "test:watch": "cross-env NODE_ENV=test jest --watch",
     "test:coverage": "cross-env NODE_ENV=test jest --collectCoverageFrom=\"src/**/*.js\" --coverage",
-    "test:manual": "webpack-dev-server test/manual/src/index.js --open --config test/manual/webpack.config.js",
+    "test:manual": "webpack-dev-server test/manual/src/index.js --config test/manual/webpack.config.js",
     "pretest": "npm run lint",
     "test": "cross-env NODE_ENV=test npm run test:coverage",
     "defaults": "webpack-defaults"
diff --git a/src/index.js b/src/index.js
@@ -325,6 +325,7 @@ class MiniCssExtractPlugin {
               source,
               '',
               `// ${pluginName} CSS loading`,
+              `var fetchRTL = !!window['${this.options.globalRTLFlag}'];`,
               `var cssChunks = ${JSON.stringify(chunkMap)};`,
               'if(installedCssChunks[chunkId]) promises.push(installedCssChunks[chunkId]);',
               'else if(installedCssChunks[chunkId] !== 0 && cssChunks[chunkId]) {',
@@ -333,6 +334,11 @@ class MiniCssExtractPlugin {
                 Template.indent([
                   `var href = ${linkHrefPath};`,
                   `var fullhref = ${mainTemplate.requireFn}.p + href;`,
+                  'if (fetchRTL) {',
+                  Template.indent([
+                    `fullhref = fullhref.replace(/\\.css/i, '.rtl.css');`,
+                  ]),
+                  '}',
                   'var existingLinkTags = document.getElementsByTagName("link");',
                   'for(var i = 0; i < existingLinkTags.length; i++) {',
                   Template.indent([
diff --git a/src/options.json b/src/options.json
@@ -10,6 +10,9 @@
           "instanceof": "Function"
         }
       ]
+    },
+    "globalRTLFlag": {
+      "type": "string"
     }
   },
   "errorMessages": {
diff --git a/test/manual/index.html b/test/manual/index.html
@@ -5,7 +5,7 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <title>mini-css-extract-plugin testcase</title>
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <link rel="stylesheet" type="text/css" href="/dist/preloaded1.css" />
+  <link rel="stylesheet" type="text/css" href="/dist/preloaded1.client.css" />
   <style>
     .test {
       background: lightcoral;
@@ -23,7 +23,7 @@
       background: lightgreen;
     }
   </style>
-  <link rel="stylesheet" type="text/css" href="/dist/main.css" />
+  <link rel="stylesheet" type="text/css" href="/dist/main.client.css" />
 </head>
 <body>
   <div class="test initial-css">
diff --git a/test/manual/webpack.config.js b/test/manual/webpack.config.js
@@ -17,8 +17,9 @@ module.exports = {
   },
   plugins: [
     new Self({
-      filename: '[name].css',
-      chunkFilename: '[contenthash].css',
+      filename: '[name].client.css',
+      chunkFilename: '[name].chunk.client.css',
+      globalRTLFlag: 'rtlLanguageEnabled',
     }),
   ],
   devServer: {

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,9 @@`
`10`	`10`	`"instanceof": "Function"`
`11`	`11`	`}`
`12`	`12`	`]`
	`13`	`+ },`
	`14`	`+ "globalRTLFlag": {`
	`15`	`+ "type": "string"`
`13`	`16`	`}`
`14`	`17`	`},`
`15`	`18`	`"errorMessages": {`