Improve how node warnings are displayed and adjusted type of job terminated events

Author: vogti

api/v1/cem.php

@@ -158,7 +158,7 @@ public function post() {
                     // Create event
                     $event = new Event(0, "Job terminated", date('Y-m-d H:i:s'),
                         "The job with the ID " . $job->getId() . " has terminated. The following reason has been provided by the CEM bootstrapper: " . $reason,
-                        Define::EVENT_NODE, $job->getId(), null, $node->getId());
+                        Define::EVENT_JOB, $job->getId(), null, $node->getId());
                     Factory::getEventFactory()->save($event);
                 } else if ($job->getStatus() == Define::JOB_STATUS_RUNNING || $job->getStatus() == Define::JOB_STATUS_SCHEDULED
                     || $job->getStatus() == Define::JOB_STATUS_SETUP ) {
@@ -167,12 +167,12 @@ public function post() {
                     // Create event
                     $event = new Event(0, "Job terminated", date('Y-m-d H:i:s'),
                         "The job with the ID " . $job->getId() . " has terminated. Job was not reported as finished, thus setting job state to failed.",
-                        Define::EVENT_NODE, $job->getId(), null, $node->getId());
+                        Define::EVENT_JOB, $job->getId(), null, $node->getId());
                     Factory::getEventFactory()->save($event);
                 } else {
                     $event = new Event(0, "Job finished", date('Y-m-d H:i:s'),
                         "The job with the ID " . $job->getId() . " has has been completed.",
-                        Define::EVENT_NODE, $job->getId(), null, $node->getId());
+                        Define::EVENT_JOB, $job->getId(), null, $node->getId());
                     Factory::getEventFactory()->save($event);
                 }
                 $node->setCurrentJob(null);

views/cem/detail.php

@@ -111,7 +111,7 @@
                     <?php } ?>
                     <div class="info-box-content">
                         <span class="info-box-text">Health Status</span>
-                        <span class="info-box-number"><?php echo (empty($data['node']->getHealthStatus()) ? "OK" : $data['node']->getHealthStatus()); ?></span>
+                        <span class="info-box-number"><?php echo (empty($data['node']->getHealthStatus()) ? "OK" : nl2br($data['node']->getHealthStatus())); ?></span>
                     </div>
                 </div>
 

views/cem/overview.php

@@ -97,7 +97,7 @@ function reloadPage() {
                                 <td><?php echo $n->getId(); ?></td>
                                 <td><?php echo $n->getHostname(); ?></td>
                                 <td><?php if ($n->getCurrentJob() == null) { echo("Idle"); } else { echo "Working on job " . $n->getCurrentJob(); } ?></td>
-                                <td><?php if (!empty($n->getHealthStatus())) { ?> <span class="glyphicon glyphicon-alert" style="color:yellow" title="Warnings detected"></span> <?php } ?></td>
+                                <td><?php if (!empty($n->getHealthStatus())) { ?> <span class="glyphicon glyphicon-alert" style="color:darkorange" title="Warnings detected"></span> <?php } ?></td>
                             </tr>
                         <?php } ?>
                     </tbody>