Skip to content

Commit 5e0a26b

Browse files
authored
Merge pull request #387 from CivicDataLab/fix-proper-spacing
Fix proper spacing
2 parents 7dde7da + 997c50c commit 5e0a26b

4 files changed

Lines changed: 242 additions & 212 deletions

File tree

app/[locale]/dashboard/[entityType]/[entitySlug]/aimodels/edit/[id]/details/page.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,7 @@ export default function AIModelDetailsPage() {
156156
const SAVE_SUCCESS_TOAST_ID = 'ai-model-details-save-success';
157157
const SAVE_ERROR_TOAST_ID = 'ai-model-details-save-error';
158158
const AI_MODEL_VALIDATION_TOAST_ID = 'ai-model-details-validation-toast';
159+
const OPEN_ACCESS_REQUIRED_TOAST_ID = SAVE_SUCCESS_TOAST_ID;
159160
const isValidHttpUrl = (value: string) => {
160161
try {
161162
const parsed = new URL(value);
@@ -452,7 +453,6 @@ export default function AIModelDetailsPage() {
452453
</div>
453454
);
454455
}
455-
const OPEN_ACCESS_REQUIRED_TOAST_ID = SAVE_SUCCESS_TOAST_ID;
456456
return (
457457
<div className="flex flex-col gap-4 py-6">
458458
{/* Model Type & Domain - side by side */}

app/[locale]/dashboard/[entityType]/[entitySlug]/usecases/edit/[id]/metadata/page.tsx

Lines changed: 25 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -483,8 +483,10 @@ const Metadata = () => {
483483
<div className="w-full py-4 pr-4 sm:w-1/2 md:w-1/2 lg:w-1/2 xl:w-1/2">
484484
<Combobox
485485
displaySelected
486-
label="SDG Goals *"
486+
label="SDG Goals"
487487
name="sdgs"
488+
required
489+
requiredIndicator={true}
488490
list={
489491
getSDGsList?.data?.sdgs?.map((item: any) => {
490492
const num = item.number
@@ -503,7 +505,7 @@ const Metadata = () => {
503505
}}
504506
/>
505507
</div>
506-
<div className="w-full py-4 pr-4 sm:w-1/2 md:w-1/2 lg:w-1/2 xl:w-1/2">
508+
<div className="w-full py-4 pl-2 pr-4 sm:w-1/2 md:w-1/2 lg:w-1/2 xl:w-1/2">
507509
<Combobox
508510
displaySelected
509511
name="tags"
@@ -527,8 +529,10 @@ const Metadata = () => {
527529
<div className="w-full py-4 pr-4 sm:w-1/2 md:w-1/2 lg:w-1/2 xl:w-1/2">
528530
<Combobox
529531
displaySelected
530-
label="Sectors *"
532+
label="Sectors"
531533
name="sectors"
534+
required
535+
requiredIndicator={true}
532536
list={
533537
getSectorsList?.data.sectors?.map((item: TypeSector) => ({
534538
label: item.name,
@@ -541,22 +545,24 @@ const Metadata = () => {
541545
handleSave({ ...formData, sectors: value });
542546
}}
543547
/>
544-
<Combobox
545-
displaySelected
546-
label="Geographies"
547-
name="geographies"
548-
list={
549-
getGeographiesList?.data?.geographies?.map((item: any) => ({
550-
label: `${item.name}${item.parentId ? ` (${item.parentId.name})` : ''}`,
551-
value: item.id,
552-
})) || []
553-
}
554-
selectedValue={formData.geographies}
555-
onChange={(value) => {
556-
handleChange('geographies', value);
557-
handleSave({ ...formData, geographies: value });
558-
}}
559-
/>
548+
<div className="mt-8 w-full">
549+
<Combobox
550+
displaySelected
551+
label="Geographies"
552+
name="geographies"
553+
list={
554+
getGeographiesList?.data?.geographies?.map((item: any) => ({
555+
label: `${item.name}${item.parentId ? ` (${item.parentId.name})` : ''}`,
556+
value: item.id,
557+
})) || []
558+
}
559+
selectedValue={formData.geographies}
560+
onChange={(value) => {
561+
handleChange('geographies', value);
562+
handleSave({ ...formData, geographies: value });
563+
}}
564+
/>
565+
</div>
560566
</div>
561567
</div>
562568

0 commit comments

Comments
 (0)