Some cosmetic changes and fixing issue #98 where command line arguments are being ignored in the stack create command.

Author: sbotman

lib/chef/knife/cs_stack_create.rb

@@ -60,7 +60,10 @@ class CsStackCreate < Chef::Knife
 
     def run
       validate_base_options
-
+      if @name_args.first.nil?
+        ui.error "Please specify json file eg: knife cs stack create JSON_FILE"
+        exit 1
+      end
       file_path = File.expand_path(@name_args.first)
       unless File.exist?(file_path) then
         ui.error "Stack file '#{file_path}' not found. Please check the path."
@@ -98,6 +101,12 @@ def create_server(server)
       cmd = KnifeCloudstack::CsServerCreate.new([server[:name]])
       # configure and run command
       # TODO: validate parameters
+      cmd.config[:cloudstack_url] = config[:cloudstack_url]
+      cmd.config[:cloudstack_api_key] = config[:cloudstack_api_key]
+      cmd.config[:cloudstack_secret_key] = config[:cloudstack_secret_key]
+      cmd.config[:cloudstack_proxy] = config[:cloudstack_proxy]
+      cmd.config[:cloudstack_no_ssl_verify] = config[:cloudstack_no_ssl_verify]
+      cmd.config[:cloudstack_project] = config[:cloudstack_project]
       cmd.config[:ssh_user] = config[:ssh_user]
       cmd.config[:ssh_password] = config[:ssh_password]
       cmd.config[:ssh_port] = config[:ssh_port] || "22" # Chef::Config[:knife][:ssh_port]

lib/chef/knife/cs_stack_delete.rb

@@ -16,9 +16,13 @@
 # limitations under the License.
 #
 
+require 'chef/knife/cs_base'
+
 module KnifeCloudstack
   class CsStackDelete < Chef::Knife
 
+    include Chef::Knife::KnifeCloudstackBase
+
     deps do
       require 'chef/json_compat'
       require 'chef/mash'
@@ -30,25 +34,11 @@ class CsStackDelete < Chef::Knife
 
     banner "knife cs stack delete JSON_FILE (options)"
 
-    option :cloudstack_url,
-           :short => "-U URL",
-           :long => "--cloudstack-url URL",
-           :description => "The CloudStack endpoint URL",
-           :proc => Proc.new { |url| Chef::Config[:knife][:cloudstack_url] = url }
-
-    option :cloudstack_api_key,
-           :short => "-A KEY",
-           :long => "--cloudstack-api-key KEY",
-           :description => "Your CloudStack API key",
-           :proc => Proc.new { |key| Chef::Config[:knife][:cloudstack_api_key] = key }
-
-    option :cloudstack_secret_key,
-           :short => "-K SECRET",
-           :long => "--cloudstack-secret-key SECRET",
-           :description => "Your CloudStack secret key",
-           :proc => Proc.new { |key| Chef::Config[:knife][:cloudstack_secret_key] = key }
-
     def run
+      if @name_args.first.nil?
+        ui.error "Please specify json file eg: knife cs stack delete JSON_FILE"
+        exit 1
+      end
       file_path = File.expand_path(@name_args.first)
       unless File.exist?(file_path) then
         ui.error "Stack file '#{file_path}' not found. Please check the path."