fix: route plugin replies through ConvertPluginMessage and fix StopPlugin data race

Author: Cod-e-Codes

README.md

@@ -766,12 +766,12 @@ Percentages are **statement coverage** from a merged profile (`go test -coverpro
 | `plugin/license` | 87.1% | 203 LOC | High |
 | `client/crypto` | 80.3% | 320 LOC | High |
 | `config` | 73.2% | 285 LOC | High |
-| `plugin/host` | 62.5% | 536 LOC | Medium |
+| `plugin/host` | 62.5% | 539 LOC | Medium |
 | `client/config` | 57.3% | 1683 LOC | Medium |
 | `internal/doctor` | 49.8% | 661 LOC | Medium |
 | `plugin/store` | 47.0% | 490 LOC | Medium |
 | `cmd/license` | 42.2% | 140 LOC | Medium |
-| `server` | 36.1% | 6310 LOC | Low |
+| `server` | 36.1% | 6303 LOC | Low |
 | `plugin/manager` | 32.1% | 626 LOC | Low |
 | `client` | 23.0% | 4966 LOC | Low |
 | `cmd/server` | 13.7% | 424 LOC | Low |

TESTING.md

@@ -174,12 +174,12 @@ go test -cover ./...
 | `plugin/license` | 87.1% | High | 203 | Small |
 | `client/crypto` | 80.3% | High | 320 | Small |
 | `config` | 73.2% | High | 285 | Small |
-| `plugin/host` | 62.5% | Medium | 536 | Medium |
+| `plugin/host` | 62.5% | Medium | 539 | Medium |
 | `client/config` | 57.3% | Medium | 1683 | Medium |
 | `internal/doctor` | 49.8% | Medium | 661 | Medium |
 | `plugin/store` | 47.0% | Medium | 490 | Medium |
 | `cmd/license` | 42.2% | Medium | 140 | Small |
-| `server` | 36.1% | Low | 6310 | Large |
+| `server` | 36.1% | Low | 6303 | Large |
 | `plugin/manager` | 32.1% | Low | 626 | Medium |
 | `client` | 23.0% | Low | 4966 | Large |
 | `cmd/server` | 13.7% | Low | 424 | Medium |

plugin/host/host.go

@@ -244,9 +244,11 @@ func (h *PluginHost) StartPlugin(name string) error {
 		return fmt.Errorf("failed to initialize plugin %s: %w", name, err)
 	}
 
-	// Start communication goroutines
+	// Start communication goroutines.
+	// Stderr is captured as a function arg so StopPlugin can safely nil the
+	// struct field without racing the goroutine's first read.
 	go h.handlePluginOutput(instance)
-	go h.handlePluginErrors(instance)
+	go h.handlePluginErrors(instance, instance.Stderr)
 
 	log.Printf("Plugin %s started successfully", name)
 	return nil
@@ -542,9 +544,10 @@ func (h *PluginHost) handlePluginOutput(instance *PluginInstance) {
 	}
 }
 
-// handlePluginErrors handles stderr from a plugin
-func (h *PluginHost) handlePluginErrors(instance *PluginInstance) {
-	scanner := json.NewDecoder(instance.Stderr)
+// handlePluginErrors handles stderr from a plugin.
+// stderr is passed explicitly to avoid racing StopPlugin's nil-out of the field.
+func (h *PluginHost) handlePluginErrors(instance *PluginInstance, stderr io.Reader) {
+	scanner := json.NewDecoder(stderr)
 	for {
 		var logEntry struct {
 			Level   string `json:"level"`

server/hub.go

@@ -402,14 +402,7 @@ func (h *Hub) Run() {
 	// Start plugin message handler goroutine
 	go func() {
 		for msg := range h.pluginManager.GetMessageChannel() {
-			// Route plugin messages through the broadcast channel for safe access
-			sharedMsg := shared.Message{
-				Sender:    msg.Sender,
-				Content:   msg.Content,
-				CreatedAt: msg.CreatedAt,
-				Type:      shared.TextMessage,
-			}
-			h.broadcast <- sharedMsg
+			h.broadcast <- ConvertPluginMessage(msg)
 		}
 	}()