ci: add Postgres/MySQL schema smoke; expand server and plugin lifecycle tests

Author: Cod-e-Codes

.github/workflows/go.yml

@@ -36,4 +36,52 @@ jobs:
             $(go env GOPATH)/bin/golangci-lint run ./...
           else
             go vet ./...
-          fi 
+          fi
+
+  database-smoke:
+    runs-on: ubuntu-latest
+    services:
+      postgres:
+        image: postgres:16-alpine
+        ports:
+          - 5432:5432
+        env:
+          POSTGRES_USER: marchat
+          POSTGRES_PASSWORD: marchat
+          POSTGRES_DB: marchat_ci
+        options: >-
+          --health-cmd "pg_isready -U marchat -d marchat_ci"
+          --health-interval 5s
+          --health-timeout 5s
+          --health-retries 10
+      mysql:
+        image: mysql:8.0
+        ports:
+          - 3306:3306
+        env:
+          MYSQL_ROOT_PASSWORD: root
+          MYSQL_DATABASE: marchat_ci
+          MYSQL_USER: marchat
+          MYSQL_PASSWORD: marchat
+        options: >-
+          --health-cmd "mysqladmin ping -h 127.0.0.1 -uroot -proot"
+          --health-interval 5s
+          --health-timeout 5s
+          --health-retries 15
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+
+      - name: Set up Go
+        uses: actions/setup-go@7a3fe6cf4cb3a834922a1244abfce67bcef6a0c5 # v6.2.0
+        with:
+          go-version: '1.25.8'
+
+      - name: Tidy modules
+        run: go mod tidy
+
+      - name: Postgres and MySQL schema smoke
+        env:
+          MARCHAT_CI_POSTGRES_URL: postgres://marchat:marchat@127.0.0.1:5432/marchat_ci?sslmode=disable
+          MARCHAT_CI_MYSQL_URL: marchat:marchat@tcp(127.0.0.1:3306)/marchat_ci
+        run: go test -race ./server -run 'Test(Postgres|MySQL)InitDBAndSchemaSmoke' -count=1 -v

README.md

@@ -733,7 +733,7 @@ Profiles stored in platform-appropriate locations:
 
 ## Testing
 
-Foundational test suite covering core functionality, cryptography, and plugins.
+Foundational test suite covering core functionality, cryptography, and plugins. CI (`.github/workflows/go.yml`) runs the full suite with the race detector and a separate **database-smoke** job against Postgres and MySQL (see [TESTING.md](TESTING.md)).
 
 ### Running Tests
 ```bash
@@ -752,21 +752,21 @@ Percentages are **statement coverage** from a merged profile (`go test -coverpro
 
 | Package | Coverage | Size | Status |
 |---------|----------|------|--------|
-| `shared` | 86.8% | 203 LOC | High |
-| `plugin/license` | 85.4% | 198 LOC | High |
-| `client/crypto` | 79.5% | 282 LOC | High |
-| `config` | 73.2% | 277 LOC | High |
-| `client/config` | 57.0% | 1679 LOC | Medium |
-| `internal/doctor` | 50.2% | 666 LOC | Medium |
-| `plugin/store` | 47.0% | 490 LOC | Medium |
-| `cmd/license` | 42.2% | 140 LOC | Medium |
-| `server` | 35.3% | 6273 LOC | Low |
-| `plugin/manager` | 26.8% | 626 LOC | Low |
-| `client` | 23.1% | 4950 LOC | Low |
-| `plugin/host` | 21.1% | 533 LOC | Low |
-| `cmd/server` | 13.7% | 424 LOC | Low |
-
-**Overall: 35.7%** (main module packages only). See [TESTING.md](TESTING.md) for detailed information.
+| `shared` | 86.8% | 244 LOC | High |
+| `plugin/license` | 85.4% | 241 LOC | High |
+| `client/crypto` | 79.5% | 347 LOC | High |
+| `config` | 73.2% | 330 LOC | High |
+| `plugin/host` | 63.2% | 617 LOC | Medium |
+| `client/config` | 57.0% | 1988 LOC | Medium |
+| `internal/doctor` | 50.2% | 737 LOC | Medium |
+| `plugin/store` | 47.0% | 552 LOC | Medium |
+| `cmd/license` | 42.2% | 160 LOC | Medium |
+| `server` | 35.4% | 7153 LOC | Low |
+| `plugin/manager` | 32.1% | 747 LOC | Low |
+| `client` | 23.1% | 5499 LOC | Low |
+| `cmd/server` | 13.7% | 484 LOC | Low |
+
+**Overall: 37.3%** (main module packages only). See [TESTING.md](TESTING.md) for detailed information.
 
 ## Contributing
 

TESTING.md

@@ -0,0 +1,90 @@
+package main
+
+import (
+	"bytes"
+	"context"
+	"encoding/json"
+	"os"
+	"os/exec"
+	"path/filepath"
+	"runtime"
+	"strings"
+	"testing"
+	"time"
+
+	"github.com/Cod-e-Codes/marchat/internal/doctor"
+)
+
+func marchatModuleRoot(t *testing.T) string {
+	t.Helper()
+	_, file, _, ok := runtime.Caller(0)
+	if !ok {
+		t.Fatal("runtime.Caller failed")
+	}
+	dir := filepath.Dir(file)
+	for {
+		if _, err := os.Stat(filepath.Join(dir, "go.mod")); err == nil {
+			return dir
+		}
+		parent := filepath.Dir(dir)
+		if parent == dir {
+			t.Fatal("go.mod not found above cmd/server")
+		}
+		dir = parent
+	}
+}
+
+func TestSubprocessDoctorPlain(t *testing.T) {
+	root := marchatModuleRoot(t)
+	cfgDir := t.TempDir()
+
+	ctx, cancel := context.WithTimeout(context.Background(), 3*time.Minute)
+	defer cancel()
+
+	cmd := exec.CommandContext(ctx, "go", "run", "./cmd/server", "-doctor", "-config-dir", cfgDir)
+	cmd.Dir = root
+	cmd.Env = append(os.Environ(),
+		"MARCHAT_DOCTOR_NO_NETWORK=1",
+		"NO_COLOR=1",
+		"CGO_ENABLED=0",
+	)
+	out, err := cmd.CombinedOutput()
+	if err != nil {
+		t.Fatalf("go run -doctor: %v\n%s", err, out)
+	}
+	if len(bytes.TrimSpace(out)) == 0 {
+		t.Fatal("expected non-empty doctor output")
+	}
+}
+
+func TestSubprocessDoctorJSON(t *testing.T) {
+	root := marchatModuleRoot(t)
+	cfgDir := t.TempDir()
+
+	ctx, cancel := context.WithTimeout(context.Background(), 3*time.Minute)
+	defer cancel()
+
+	cmd := exec.CommandContext(ctx, "go", "run", "./cmd/server", "-doctor-json", "-config-dir", cfgDir)
+	cmd.Dir = root
+	cmd.Env = append(os.Environ(),
+		"MARCHAT_DOCTOR_NO_NETWORK=1",
+		"NO_COLOR=1",
+		"CGO_ENABLED=0",
+	)
+	out, err := cmd.CombinedOutput()
+	if err != nil {
+		t.Fatalf("go run -doctor-json: %v\n%s", err, out)
+	}
+
+	trim := bytes.TrimSpace(out)
+	var rep doctor.Report
+	if err := json.Unmarshal(trim, &rep); err != nil {
+		t.Fatalf("invalid JSON doctor output: %v\n%s", err, string(trim))
+	}
+	if rep.Role != "server" {
+		t.Fatalf("report.role = %q, want server", rep.Role)
+	}
+	if !strings.HasPrefix(rep.GoVersion, "go") {
+		t.Fatalf("expected go_version, got %q", rep.GoVersion)
+	}
+}

cmd/server/subprocess_doctor_test.go

@@ -0,0 +1,170 @@
+package host
+
+import (
+	"encoding/json"
+	"os"
+	"os/exec"
+	"path/filepath"
+	"runtime"
+	"testing"
+
+	"github.com/Cod-e-Codes/marchat/plugin/sdk"
+)
+
+// minimalPluginMain is a tiny stdin/stdout JSON plugin that answers init and shutdown.
+const minimalPluginMain = `package main
+
+import (
+	"encoding/json"
+	"os"
+)
+
+func main() {
+	dec := json.NewDecoder(os.Stdin)
+	enc := json.NewEncoder(os.Stdout)
+	for {
+		var req map[string]interface{}
+		if err := dec.Decode(&req); err != nil {
+			return
+		}
+		t, _ := req["type"].(string)
+		switch t {
+		case "init":
+			_ = enc.Encode(map[string]interface{}{"type": "response", "success": true})
+		case "shutdown":
+			return
+		default:
+			_ = enc.Encode(map[string]interface{}{"type": "response", "success": true})
+		}
+	}
+}
+`
+
+func buildMinimalPluginBinary(t *testing.T, pluginName, pluginRoot string) {
+	t.Helper()
+	srcDir := filepath.Join(pluginRoot, "_build_"+pluginName)
+	if err := os.MkdirAll(srcDir, 0o755); err != nil {
+		t.Fatalf("mkdir src: %v", err)
+	}
+	mainPath := filepath.Join(srcDir, "main.go")
+	if err := os.WriteFile(mainPath, []byte(minimalPluginMain), 0o644); err != nil {
+		t.Fatalf("write main: %v", err)
+	}
+	// go build requires a module boundary when GO111MODULE=on (default).
+	if err := os.WriteFile(filepath.Join(srcDir, "go.mod"), []byte("module marchat_test_minimal_plugin\n\ngo 1.21\n"), 0o644); err != nil {
+		t.Fatalf("write go.mod: %v", err)
+	}
+
+	pluginPath := filepath.Join(pluginRoot, pluginName)
+	if err := os.MkdirAll(pluginPath, 0o755); err != nil {
+		t.Fatalf("mkdir plugin: %v", err)
+	}
+
+	outName := pluginName
+	if runtime.GOOS == "windows" {
+		outName += ".exe"
+	}
+	outPath := filepath.Join(pluginPath, outName)
+
+	cmd := exec.Command("go", "build", "-o", outPath, ".")
+	cmd.Dir = srcDir
+	cmd.Env = append(os.Environ(), "CGO_ENABLED=0")
+	if out, err := cmd.CombinedOutput(); err != nil {
+		t.Fatalf("go build plugin: %v\n%s", err, out)
+	}
+
+	manifest := sdk.PluginManifest{
+		Name:        pluginName,
+		Version:     "1.0.0",
+		Description: "minimal test plugin",
+		Author:      "test",
+		License:     "MIT",
+	}
+	data, err := json.Marshal(manifest)
+	if err != nil {
+		t.Fatalf("marshal manifest: %v", err)
+	}
+	if err := os.WriteFile(filepath.Join(pluginPath, "plugin.json"), data, 0o644); err != nil {
+		t.Fatalf("write manifest: %v", err)
+	}
+}
+
+func TestPluginHostStartStopLifecycle(t *testing.T) {
+	pluginDir := t.TempDir()
+	dataDir := t.TempDir()
+	const name = "lifecycleplug"
+	buildMinimalPluginBinary(t, name, pluginDir)
+
+	h := NewPluginHost(pluginDir, dataDir)
+	if err := h.LoadPlugin(name); err != nil {
+		t.Fatalf("LoadPlugin: %v", err)
+	}
+	if err := h.StartPlugin(name); err != nil {
+		t.Fatalf("StartPlugin: %v", err)
+	}
+	inst := h.GetPlugin(name)
+	if inst == nil || inst.Process == nil {
+		t.Fatal("expected running process after StartPlugin")
+	}
+	if err := h.StopPlugin(name); err != nil {
+		t.Fatalf("StopPlugin: %v", err)
+	}
+	if inst := h.GetPlugin(name); inst == nil || inst.Process != nil {
+		t.Fatal("expected Process cleared after StopPlugin")
+	}
+}
+
+func TestPluginHostStartPluginAlreadyRunning(t *testing.T) {
+	pluginDir := t.TempDir()
+	dataDir := t.TempDir()
+	const name = "doublestart"
+	buildMinimalPluginBinary(t, name, pluginDir)
+
+	h := NewPluginHost(pluginDir, dataDir)
+	if err := h.LoadPlugin(name); err != nil {
+		t.Fatalf("LoadPlugin: %v", err)
+	}
+	if err := h.StartPlugin(name); err != nil {
+		t.Fatalf("StartPlugin: %v", err)
+	}
+	defer func() { _ = h.StopPlugin(name) }()
+
+	if err := h.StartPlugin(name); err == nil {
+		t.Fatal("expected error when StartPlugin on already running plugin")
+	}
+}
+
+func TestPluginHostStopPluginIdempotent(t *testing.T) {
+	pluginDir := t.TempDir()
+	dataDir := t.TempDir()
+	const name = "stopnoop"
+	buildMinimalPluginBinary(t, name, pluginDir)
+
+	h := NewPluginHost(pluginDir, dataDir)
+	if err := h.LoadPlugin(name); err != nil {
+		t.Fatalf("LoadPlugin: %v", err)
+	}
+	if err := h.StopPlugin(name); err != nil {
+		t.Fatalf("StopPlugin on non-started: %v", err)
+	}
+}
+
+func TestPluginHostExecuteCommandWhenRunning(t *testing.T) {
+	pluginDir := t.TempDir()
+	dataDir := t.TempDir()
+	const name = "cmdplug"
+	buildMinimalPluginBinary(t, name, pluginDir)
+
+	h := NewPluginHost(pluginDir, dataDir)
+	if err := h.LoadPlugin(name); err != nil {
+		t.Fatalf("LoadPlugin: %v", err)
+	}
+	if err := h.StartPlugin(name); err != nil {
+		t.Fatalf("StartPlugin: %v", err)
+	}
+	defer func() { _ = h.StopPlugin(name) }()
+
+	if err := h.ExecuteCommand(name, "ping", nil); err != nil {
+		t.Fatalf("ExecuteCommand: %v", err)
+	}
+}