Skip to content

Commit 23fc33a

Browse files
committed
Fix lints and CI
Signed-off-by: Marvin Gudel <marvin.gudel@9elements.com>
1 parent 9be71fe commit 23fc33a

5 files changed

Lines changed: 6 additions & 8 deletions

File tree

ci/runtests.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ cargo build --target thumbv7em-none-eabihf --features defmt --no-default-feature
5353
cargo build --features log
5454
)
5555

56-
FEATURES_ASYNC="embassy"
56+
FEATURES_ASYNC="async"
5757
FEATURES_SYNC=""
5858

5959
declare -a FEATURES=(

mctp-estack/src/fragment.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ impl Fragmenter {
147147
rest = &mut rest[1..];
148148
}
149149

150-
let Ok(n) = self.reader.read(payload, &mut rest) else {
150+
let Ok(n) = self.reader.read(payload, rest) else {
151151
return SendOutput::failure(Error::BadArgument, self);
152152
};
153153
let rest = &rest[n..];

mctp-usb-embassy/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ embassy-usb-driver = { version = "0.2" }
1515
embassy-usb = { version = "0.5", default-features = false }
1616
heapless = { workspace = true }
1717
log = { workspace = true, optional = true }
18-
mctp-estack = { workspace = true }
18+
mctp-estack = { workspace = true, features = ["async"] }
1919
mctp = { workspace = true, default-features = false }
2020

2121
[features]

pldm-file/examples/host.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ use std::io::{Read, Seek, SeekFrom};
1212
use std::os::unix::fs::MetadataExt;
1313
use std::time::{Duration, Instant};
1414

15-
use argh;
16-
1715
/// PLDM file host
1816
#[derive(argh::FromArgs)]
1917
struct Args {
@@ -142,7 +140,7 @@ fn read_whole(f: &mut File, buf: &mut [u8]) -> std::io::Result<usize> {
142140
}
143141
}
144142
// Full output
145-
return Ok(total);
143+
Ok(total)
146144
}
147145

148146
struct Speed {

pldm-platform/examples/decodepdr.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ fn main() {
2222
})
2323
.unwrap();
2424
println!("rsp {pdrrsp:?}");
25-
assert!(rest.len() == 0);
25+
assert!(rest.is_empty());
2626

2727
let ((rest, _), pdr) = Pdr::from_bytes((&pdrrsp.record_data, 0))
2828
.map_err(|e| {
@@ -33,7 +33,7 @@ fn main() {
3333
if !rest.is_empty() {
3434
panic!("Extra PDR response");
3535
}
36-
assert!(rest.len() == 0);
36+
assert!(rest.is_empty());
3737

3838
println!("PDR {pdr:?}");
3939
}

0 commit comments

Comments
 (0)