Skip to content

Commit 3e9d5fb

Browse files
committed
tests: remove unused variables
Fix ruff lint F841. Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
1 parent 7954b5e commit 3e9d5fb

2 files changed

Lines changed: 7 additions & 11 deletions

File tree

tests/mctpenv/__init__.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -557,15 +557,15 @@ async def run(self):
557557
while True:
558558
try:
559559
data = await self.sock.recv(1024)
560-
except ConnectionResetError as ex:
560+
except ConnectionResetError:
561561
break
562562

563563
if len(data) == 0:
564564
break
565565

566566
try:
567567
await self.recv_msg(data)
568-
except BrokenPipeError as ex:
568+
except BrokenPipeError:
569569
break
570570

571571
async def recv_msg(self, data):
@@ -1051,8 +1051,7 @@ def _parse_route(self, msg):
10511051
gw = msg.get_attr('RTA_GATEWAY')
10521052
start_eid = msg.get_attr('RTA_DST')
10531053
extent_eid = msg['dst_len']
1054-
# todo: RTAX metrics
1055-
mtu = 0
1054+
# todo: RTAX metrics: MTU
10561055

10571056
if ifindex:
10581057
iface = self.system.find_interface_by_ifindex(ifindex)
@@ -1149,7 +1148,7 @@ async def run(self):
11491148
math.floor(trio.current_time() * 1000000))
11501149
await self.sock.send(data)
11511150
self.delay = sys.maxsize
1152-
except (ConnectionResetError, BrokenPipeError) as ex:
1151+
except (ConnectionResetError, BrokenPipeError):
11531152
break
11541153

11551154

tests/test_mctpd.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,6 @@ def ep_removed(ep_path, interfaces):
227227
async def test_recover_endpoint_reset(dbus, mctpd, autojump_clock):
228228
iface = mctpd.system.interfaces[0]
229229
dev = mctpd.network.endpoints[0]
230-
mctp = await dbus.get_proxy_object(MCTPD_C, MCTPD_MCTP_P)
231230
mctp_iface = await mctpd_mctp_iface_obj(dbus, iface)
232231
(eid, net, path, new) = await mctp_iface.call_setup_endpoint(dev.lladdr)
233232

@@ -407,8 +406,6 @@ async def test_assign_endpoint_static_varies(dbus, mctpd):
407406
for a basic Get Endpoint ID command"""
408407
async def test_get_endpoint_id(dbus, mctpd, routed_ep):
409408
ep = routed_ep
410-
iface = mctpd.system.interfaces[0]
411-
mctp = await mctpd_mctp_iface_obj(dbus, iface)
412409

413410
cmd = MCTPControlCommand(True, 0, 0x02)
414411
rsp = await ep.send_control(mctpd.network.mctp_socket, cmd)
@@ -448,7 +445,7 @@ async def handle_mctp_control(self, sock, src_addr, msg):
448445
mctp = await mctpd_mctp_iface_obj(dbus, iface)
449446

450447
with pytest.raises(asyncdbus.errors.DBusError) as ex:
451-
rc = await mctp.call_learn_endpoint(ep.lladdr)
448+
await mctp.call_learn_endpoint(ep.lladdr)
452449

453450
assert str(ex.value) == "Request failed"
454451

@@ -479,7 +476,7 @@ async def handle_mctp_control(self, sock, src_addr, msg):
479476
mctp = await mctpd_mctp_iface_obj(dbus, iface)
480477

481478
with pytest.raises(asyncdbus.errors.DBusError) as ex:
482-
rc = await mctp.call_setup_endpoint(ep.lladdr)
479+
await mctp.call_setup_endpoint(ep.lladdr)
483480

484481
assert str(ex.value) == "Endpoint returned failure to Set Endpoint ID"
485482

@@ -710,7 +707,7 @@ async def test_network_learn_endpoint_absent(dbus, mctpd):
710707

711708
net = await mctpd_mctp_network_obj(dbus, iface.net)
712709

713-
with pytest.raises(asyncdbus.errors.DBusError) as ex:
710+
with pytest.raises(asyncdbus.errors.DBusError):
714711
await net.call_learn_endpoint(10)
715712

716713
""" Change a network id, while we have an active endpoint on that net """

0 commit comments

Comments
 (0)