Skip to content

Commit 12f0d96

Browse files
committed
nvme: mi: dev: Improve debug output on deku parse failure
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
1 parent fc19504 commit 12f0d96

1 file changed

Lines changed: 15 additions & 16 deletions

File tree

src/nvme/mi/dev.rs

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -93,22 +93,21 @@ impl RequestHandler for MessageHeader {
9393
};
9494

9595
match nmimt {
96-
MessageType::NvmeMiCommand => {
97-
let Ok(((rest, _), ch)) = NvmeMiCommandRequestHeader::from_bytes((rest, 0)) else {
98-
debug!("Message too short to extract NVMeMICommandHeader");
99-
return Err(ResponseStatus::InvalidCommandSize);
100-
};
101-
102-
ch.handle(&ch, mep, subsys, rest, resp, app).await
103-
}
104-
MessageType::NvmeAdminCommand => {
105-
let Ok(((rest, _), ch)) = AdminCommandRequestHeader::from_bytes((rest, 0)) else {
106-
debug!("Message too short to extract AdminCommandHeader");
107-
return Err(ResponseStatus::InvalidCommandSize);
108-
};
109-
110-
ch.handle(&ch, mep, subsys, rest, resp, app).await
111-
}
96+
MessageType::NvmeMiCommand => match NvmeMiCommandRequestHeader::from_bytes((rest, 0)) {
97+
Ok(((rest, _), ch)) => ch.handle(&ch, mep, subsys, rest, resp, app).await,
98+
Err(err) => {
99+
debug!("Unable to parse NVMeMICommandHeader from message buffer: {err:?}");
100+
Err(ResponseStatus::InvalidCommandSize)
101+
}
102+
},
103+
MessageType::NvmeAdminCommand => match AdminCommandRequestHeader::from_bytes((rest, 0))
104+
{
105+
Ok(((rest, _), ch)) => ch.handle(&ch, mep, subsys, rest, resp, app).await,
106+
Err(err) => {
107+
debug!("Unable to parse AdminCommandHeader from message buffer: {err:?}");
108+
Err(ResponseStatus::InvalidCommandSize)
109+
}
110+
},
112111
_ => {
113112
debug!("Unimplemented NMINT: {:?}", ctx.nmimt());
114113
Err(ResponseStatus::InternalError)

0 commit comments

Comments
 (0)