Skip to content

Commit 4d855cc

Browse files
committed
Merge branch 'develop' into 423-model-prompts
2 parents 8de92c9 + 75c1a14 commit 4d855cc

2 files changed

Lines changed: 7 additions & 16 deletions

File tree

server/api/views/uploadFile/test_title.py

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -59,25 +59,20 @@ def test_falls_back_to_chatgpt_if_no_title_found(self, mock_openAI):
5959
doc.metadata = {"title": None}
6060
doc[0].get_text.return_value = []
6161

62-
mock_response = MagicMock()
63-
mock_response.choices = [MagicMock()]
64-
mock_response.choices[0].message.content = "A Study Regarding The Efficacy of Drugs"
65-
mock_openAI.return_value = mock_response
62+
mock_openAI.return_value = "A Study Regarding The Efficacy of Drugs"
6663

67-
title.generate_title(doc)
64+
result = title.generate_title(doc)
6865

6966
self.assertTrue(mock_openAI.called)
67+
self.assertEqual(result, "A Study Regarding The Efficacy of Drugs")
7068

7169
@patch("api.views.uploadFile.title.openAIServices.openAI")
7270
def test_strips_quotes_from_openai_title(self, mock_openAI):
7371
doc = MagicMock()
7472
doc.metadata = {"title": None}
7573
doc[0].get_text.return_value = []
7674

77-
mock_response = MagicMock()
78-
mock_response.choices = [MagicMock()]
79-
mock_response.choices[0].message.content = '"Updated CANMAT/ISBD Guidelines for Treating Mixed Features in Bipolar Disorder"'
80-
mock_openAI.return_value = mock_response
75+
mock_openAI.return_value = '"Updated CANMAT/ISBD Guidelines for Treating Mixed Features in Bipolar Disorder"'
8176

8277
result = title.generate_title(doc)
8378

@@ -89,10 +84,7 @@ def test_truncates_long_openai_title(self, mock_openAI):
8984
doc.metadata = {"title": None}
9085
doc[0].get_text.return_value = []
9186

92-
mock_response = MagicMock()
93-
mock_response.choices = [MagicMock()]
94-
mock_response.choices[0].message.content = "A" * 300
95-
mock_openAI.return_value = mock_response
87+
mock_openAI.return_value = "A" * 300
9688

9789
result = title.generate_title(doc)
9890

server/api/views/uploadFile/title.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,7 @@ def summarize_pdf(pdf: fitz.Document) -> str:
5656
raise Exception("Failed to read the first page of the PDF file")
5757

5858
# UploadFile model title is limited to 255 chars.
59-
response = openAIServices.openAI(
60-
first_page_content, UPLOAD_FILE_TITLE_PROMPT, model='gpt-4o', temp=0.0)
61-
title = response.choices[0].message.content.strip().strip('"').strip("'")
59+
response = openAIServices.openAI(first_page_content, UPLOAD_FILE_TITLE_PROMPT, model='gpt-4o', temp=0.0)
60+
title = response.strip().strip('"').strip("'")
6261
# Truncate to fit UploadFile model's max_length=255 title field as a final safeguard
6362
return title[:255]

0 commit comments

Comments
 (0)