feat: add button to submit review

Author: nathanosdev

README.md

@@ -294,6 +294,13 @@ Any property preceded by `opt` is optional and can be omitted. For example, to o
 dfx canister call backend update_user_profile '(record { user_id = "${userId}"; username = opt "${username}"; })'
 ```
 
+Or to only upgrade a user to a reviewer:
+
+```bash
+
+dfx canister call backend update_user_profile '(record { user_id = "${userId}"; config = opt variant { reviewer = record {} } })'
+```
+
 ### Listing open proposals
 
 To list open replica version management proposals:

dfx.json

@@ -1,5 +1,5 @@
 {
-  "dfx": "0.21.0",
+  "dfx": "0.24.3",
   "output_env_file": ".env",
   "version": 1,
   "networks": {

lib/styles/global/buttons.scss

@@ -58,6 +58,26 @@ $btn-disabled-color: rgba(colors.$primary, 0.45);
     border-color: $btn-disabled-color;
     background-color: transparent;
   }
+
+  &.btn--success {
+    color: colors.$success;
+    border-color: colors.$success;
+
+    &:hover:not(:disabled) {
+      background-color: colors.$success;
+      border-color: colors.$success;
+    }
+  }
+
+  &.btn--error {
+    color: colors.$error;
+    border-color: colors.$error;
+
+    &:hover:not(:disabled) {
+      background-color: colors.$error;
+      border-color: colors.$error;
+    }
+  }
 }
 
 .btn-group {

src/frontend/src/app/core/api/review/review-api.mapper.ts

@@ -34,7 +34,7 @@ export function mapCreateProposalReviewRequest(
     review_duration_mins: toCandidOpt(req.reviewDurationMins),
     summary: toCandidOpt(req.summary),
     build_reproduced: toCandidOpt(req.buildReproduced),
-    vote: mapProposalVoteRequest(req.vote),
+    vote: toCandidOpt(mapProposalVoteRequest(req.vote)),
   };
 }
 
@@ -43,12 +43,11 @@ export function mapUpdateProposalReviewRequest(
 ): UpdateProposalReviewApiRequest {
   return {
     proposal_id: req.proposalId,
-    // [TODO] - connect with form once it's implemented
-    status: [],
+    status: toCandidOpt(mapProposalReviewStatusRequest(req.status)),
     review_duration_mins: toCandidOpt(req.reviewDurationMins),
     summary: toCandidOpt(req.summary),
     build_reproduced: toCandidOpt(req.buildReproduced),
-    vote: mapProposalVoteRequest(req.vote),
+    vote: toCandidOpt(mapProposalVoteRequest(req.vote)),
   };
 }
 
@@ -101,6 +100,24 @@ export function mapGetProposalReviewResponse(
   };
 }
 
+function mapProposalReviewStatusRequest(
+  status?: ProposalReviewStatus | null,
+): ProposalReviewStatusApi | null {
+  switch (status) {
+    case ProposalReviewStatus.Published: {
+      return { published: null };
+    }
+
+    case ProposalReviewStatus.Draft: {
+      return { draft: null };
+    }
+
+    default: {
+      return null;
+    }
+  }
+}
+
 function mapProposalReviewStatusResponse(
   res: ProposalReviewStatusApi,
 ): ProposalReviewStatus {
@@ -111,16 +128,16 @@ function mapProposalReviewStatusResponse(
   return ProposalReviewStatus.Draft;
 }
 
-function mapProposalVoteRequest(vote?: boolean | null): [] | [ApiProposalVote] {
+function mapProposalVoteRequest(vote?: boolean | null): ApiProposalVote | null {
   switch (vote) {
     case true: {
-      return [{ yes: null }];
+      return { yes: null };
     }
     case false: {
-      return [{ no: null }];
+      return { no: null };
     }
     default: {
-      return [];
+      return null;
     }
   }
 }

src/frontend/src/app/core/api/review/review-api.model.ts

@@ -11,6 +11,7 @@ export interface CreateProposalReviewRequest {
 
 export interface UpdateProposalReviewRequest {
   proposalId: string;
+  status?: ProposalReviewStatus | null;
   reviewDurationMins?: number | null;
   summary?: string | null;
   buildReproduced?: boolean | null;
@@ -46,14 +47,14 @@ export interface GetProposalReviewResponse {
 }
 
 export enum ProposalReviewStatus {
-  Draft,
-  Published,
+  Draft = 'Draft',
+  Published = 'Published',
 }
 
 export enum ProposalReviewVote {
-  Adopt,
-  Reject,
-  NoVote,
+  Adopt = 'Adopt',
+  Reject = 'Reject',
+  NoVote = 'NoVote',
 }
 
 export interface ProposalCommitReviewHighlight {

src/frontend/src/app/core/icons/loading-icon/loading-icon-component.ts

@@ -1,4 +1,4 @@
-import { ChangeDetectionStrategy, Component } from '@angular/core';
+import { ChangeDetectionStrategy, Component, input } from '@angular/core';
 
 @Component({
   selector: 'app-loading-icon',
@@ -16,10 +16,17 @@ import { ChangeDetectionStrategy, Component } from '@angular/core';
       }
 
       .loading-icon__svg {
-        stroke: common.$primary;
         fill: none;
         stroke-width: 10px;
       }
+
+      .loading-icon__svg--primary {
+        stroke: common.$primary;
+      }
+
+      .loading-icon__svg--white {
+        stroke: common.$white;
+      }
     `,
   ],
   template: `
@@ -32,7 +39,7 @@ import { ChangeDetectionStrategy, Component } from '@angular/core';
       preserveAspectRatio="xMidYMid"
     >
       <circle
-        class="loading-icon__svg"
+        [class]="'loading-icon__svg loading-icon__svg--' + theme()"
         cx="50"
         cy="50"
         r="32"
@@ -51,4 +58,6 @@ import { ChangeDetectionStrategy, Component } from '@angular/core';
     </svg>
   `,
 })
-export class LoadingIconComponent {}
+export class LoadingIconComponent {
+  public readonly theme = input<'white' | 'primary'>('primary');
+}

src/frontend/src/app/core/state/review-submission/review-submission.service.ts

@@ -15,6 +15,7 @@ import {
   GetProposalReviewCommitResponse,
   UpdateProposalReviewRequest,
   ReviewCommitDetails,
+  ProposalReviewStatus,
 } from '../../api';
 import { batchApiCall, filterNotNil, isNil, isNotNil } from '../../utils';
 
@@ -79,15 +80,7 @@ export class ReviewSubmissionService {
         takeUntilDestroyed(),
         filterNotNil(),
         batchApiCall(review =>
-          from(
-            this.reviewApiService.updateProposalReview({
-              proposalId: this.proposalId!,
-              summary: review.summary,
-              reviewDurationMins: review.reviewDurationMins,
-              buildReproduced: review.buildReproduced,
-              vote: review.vote,
-            }),
-          ),
+          from(this.reviewApiService.updateProposalReview(review)),
         ),
       )
       .subscribe({});
@@ -135,6 +128,38 @@ export class ReviewSubmissionService {
     this.pendingReviewSubject.next(updatedReview);
   }
 
+  public async publishReview(): Promise<void> {
+    await this.updateStatus(ProposalReviewStatus.Published);
+  }
+
+  public async editReview(): Promise<void> {
+    await this.updateStatus(ProposalReviewStatus.Draft);
+  }
+
+  private async updateStatus(status: ProposalReviewStatus): Promise<void> {
+    if (isNil(this.proposalId)) {
+      throw new Error(
+        'Tried to update review status without selecting a proposal',
+      );
+    }
+
+    const currentReview = this.reviewSubject.value;
+    if (isNil(currentReview)) {
+      throw new Error('Tried to update review status before review was loaded');
+    }
+
+    await this.reviewApiService.updateProposalReview({
+      proposalId: this.proposalId,
+      status,
+    });
+
+    this.reviewSubject.next({
+      ...currentReview,
+      ...(this.pendingReviewSubject.value || {}),
+      status,
+    });
+  }
+
   public addCommit(): void {
     if (isNil(this.proposalId)) {
       throw new Error(

src/frontend/src/app/core/ui/loading-button/loading-button.component.ts

@@ -8,15 +8,29 @@ import { LoadingIconComponent } from '../../icons';
   changeDetection: ChangeDetectionStrategy.OnPush,
   styles: [
     `
+      .loading-button {
+        &:disabled {
+          cursor: not-allowed;
+        }
+      }
+
       .loading-button__text--transparent {
         color: transparent;
       }
     `,
   ],
   template: `
-    <button [type]="type()" [disabled]="disabled()" [class]="btnClass()">
+    <button
+      [type]="type()"
+      [disabled]="isSaving() || disabled()"
+      [class]="'loading-button ' + btnClass()"
+    >
       @if (isSaving()) {
-        <app-loading-icon class="btn--loading" aria-label="Saving" />
+        <app-loading-icon
+          class="btn--loading"
+          aria-label="Saving"
+          [theme]="theme()"
+        />
       }
 
       <div
@@ -31,6 +45,8 @@ import { LoadingIconComponent } from '../../icons';
 export class LoadingButtonComponent {
   public readonly type = input<'submit' | 'button'>('button');
 
+  public readonly theme = input<'primary' | 'white'>('primary');
+
   public readonly disabled = input(false);
 
   public readonly btnClass = input('');

src/frontend/src/app/core/utils/route-param.ts

@@ -1,16 +1,17 @@
-import { inject } from '@angular/core';
-import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
+import { inject, Signal } from '@angular/core';
+import { toSignal } from '@angular/core/rxjs-interop';
 import { ActivatedRoute } from '@angular/router';
-import { Observable, map } from 'rxjs';
+import { map } from 'rxjs';
 
 import { filterNotNil } from './nil';
 
-export function routeParam(name: string): Observable<string> {
+export function routeParamSignal(name: string): Signal<string | undefined> {
   const route = inject(ActivatedRoute);
 
-  return route.paramMap.pipe(
-    map(params => params.get(name)),
-    filterNotNil(),
-    takeUntilDestroyed(),
+  return toSignal(
+    route.paramMap.pipe(
+      map(params => params.get(name)),
+      filterNotNil(),
+    ),
   );
 }

src/frontend/src/app/pages/profile-edit/admin-personal-info-form/admin-personal-info-form.component.ts

@@ -110,7 +110,7 @@ interface AdminProfileForm {
         <app-loading-button
           btnClass="btn"
           type="submit"
-          [disabled]="profileForm().invalid || isSaving()"
+          [disabled]="profileForm().invalid"
           [isSaving]="isSaving()"
         >
           Save