Merge pull request #117 from CodeGov-org/nathan/update-review-pages

feat: update review pages

Author: nathanosdev

lib/styles/global/buttons.scss

@@ -85,6 +85,7 @@ $btn-disabled-color: rgba(colors.$primary, 0.45);
   flex-direction: row;
   justify-content: end;
   align-items: center;
+  margin-top: sizing.size(4);
 
   > :not(:last-child) {
     margin-right: sizing.size(2);

lib/styles/global/typography.scss

@@ -140,3 +140,24 @@ code {
     background-color: colors.$slate-900;
   }
 }
+
+.truncate {
+  display: block;
+  overflow-x: hidden;
+  white-space: nowrap;
+  text-overflow: ellipsis;
+  margin-right: sizing.size(4);
+}
+
+.page-heading {
+  display: flex;
+  flex-direction: row;
+  justify-content: space-between;
+  align-items: center;
+  margin-bottom: sizing.size(4);
+
+  > * {
+    margin-bottom: 0;
+    margin-top: 0;
+  }
+}

src/backend/api/backend.did

@@ -41,15 +41,24 @@ type UserConfig = variant {
   anonymous;
 };
 
-type GetMyUserProfileResponse = variant {
+type UserProfile = record {
+  id : text;
+  username : text;
+  config : UserConfig;
+};
+
+type ListReviewerProfilesResponse = variant {
   ok : record {
-    id : text;
-    username : text;
-    config : UserConfig;
+    profiles : vec UserProfile;
   };
   err : Err;
 };
 
+type GetMyUserProfileResponse = variant {
+  ok : UserProfile;
+  err : Err;
+};
+
 type UserProfileHistoryEntry = record {
   username : text;
   config : UserConfig;
@@ -396,6 +405,7 @@ type HttpResponse = record {
 // End HTTP
 
 service : {
+  list_reviewer_profiles : () -> (ListReviewerProfilesResponse) query;
   get_my_user_profile : () -> (GetMyUserProfileResponse) query;
   get_my_user_profile_history : () -> (GetMyUserProfileHistoryResponse) query;
   create_my_user_profile : () -> (CreateMyUserProfileResponse);

src/backend/api/src/user_profile.rs

@@ -52,12 +52,19 @@ pub struct SocialLink {
 }
 
 #[derive(Debug, Clone, CandidType, PartialEq, Eq)]
-pub struct GetMyUserProfileResponse {
+pub struct UserProfile {
     pub id: String,
     pub username: String,
     pub config: UserConfig,
 }
 
+#[derive(Debug, Clone, CandidType, PartialEq, Eq)]
+pub struct ListReviewerProfilesResponse {
+    pub profiles: Vec<UserProfile>,
+}
+
+pub type GetMyUserProfileResponse = UserProfile;
+
 #[derive(Debug, Clone, CandidType, PartialEq, Eq)]
 pub struct CreateMyUserProfileResponse {
     pub id: String,

src/backend/impl/src/controllers/log_controller.rs

@@ -69,7 +69,7 @@ mod tests {
 
     #[rstest]
     #[case::anonymous_principal(Principal::anonymous())]
-    #[case::non_admin_principal(fixtures::principal())]
+    #[case::non_admin_principal(fixtures::principal_a())]
     fn list_logs_unauthorized(#[case] calling_principal: Principal) {
         let request = LogsFilterRequest {
             before_timestamp_ms: None,
@@ -105,7 +105,7 @@ mod tests {
 
     #[rstest]
     fn list_logs() {
-        let calling_principal = fixtures::principal();
+        let calling_principal = fixtures::principal_a();
         let request = LogsFilterRequest {
             before_timestamp_ms: None,
             after_timestamp_ms: None,

src/backend/impl/src/controllers/proposal_controller.rs

@@ -135,7 +135,7 @@ mod tests {
 
     #[rstest]
     #[case::anonymous_principal(Principal::anonymous())]
-    #[case::non_admin_principal(fixtures::principal())]
+    #[case::non_admin_principal(fixtures::principal_a())]
     async fn sync_proposals_unauthorized(#[case] calling_principal: Principal) {
         let error = ApiError::permission_denied(&format!(
             "Principal {} must be an admin to call this endpoint",
@@ -171,7 +171,7 @@ mod tests {
 
     #[rstest]
     async fn sync_proposals() {
-        let calling_principal = fixtures::principal();
+        let calling_principal = fixtures::principal_a();
         let synced_proposals_count = 2;
         let completed_proposals_count = 1;
 

src/backend/impl/src/controllers/proposal_review_commit_controller.rs

@@ -135,7 +135,7 @@ mod tests {
 
     #[rstest]
     async fn create_proposal_review_commit() {
-        let calling_principal = fixtures::principal();
+        let calling_principal = fixtures::principal_a();
         let request = CreateProposalReviewCommitRequest {
             proposal_review_id: "proposal_review_id".to_string(),
             commit_sha: "commit_sha".to_string(),
@@ -177,7 +177,7 @@ mod tests {
 
     #[rstest]
     async fn create_proposal_review_commit_unauthorized() {
-        let calling_principal = fixtures::principal();
+        let calling_principal = fixtures::principal_a();
         let request = CreateProposalReviewCommitRequest {
             proposal_review_id: "proposal_review_id".to_string(),
             commit_sha: "commit_sha".to_string(),
@@ -215,7 +215,7 @@ mod tests {
 
     #[rstest]
     fn update_proposal_review_commit() {
-        let calling_principal = fixtures::principal();
+        let calling_principal = fixtures::principal_a();
         let request = UpdateProposalReviewCommitRequest {
             id: "id".to_string(),
             state: backend_api::ReviewCommitState::Reviewed {
@@ -249,7 +249,7 @@ mod tests {
 
     #[rstest]
     fn update_proposal_review_commit_unauthorized() {
-        let calling_principal = fixtures::principal();
+        let calling_principal = fixtures::principal_a();
         let request = UpdateProposalReviewCommitRequest {
             id: "id".to_string(),
             state: backend_api::ReviewCommitState::Reviewed {
@@ -285,7 +285,7 @@ mod tests {
 
     #[rstest]
     fn delete_proposal_review_commit() {
-        let calling_principal = fixtures::principal();
+        let calling_principal = fixtures::principal_a();
         let request = DeleteProposalReviewCommitRequest {
             id: "id".to_string(),
         };
@@ -314,7 +314,7 @@ mod tests {
 
     #[rstest]
     fn delete_proposal_review_commit_unauthorized() {
-        let calling_principal = fixtures::principal();
+        let calling_principal = fixtures::principal_a();
         let request = DeleteProposalReviewCommitRequest {
             id: "id".to_string(),
         };

src/backend/impl/src/controllers/proposal_review_controller.rs

@@ -250,7 +250,7 @@ mod tests {
 
     #[rstest]
     async fn create_proposal_review() {
-        let calling_principal = fixtures::principal();
+        let calling_principal = fixtures::principal_a();
         let request = CreateProposalReviewRequest {
             proposal_id: "proposal_id".to_string(),
             summary: Some("summary".to_string()),
@@ -293,7 +293,7 @@ mod tests {
 
     #[rstest]
     async fn create_proposal_review_unauthorized() {
-        let calling_principal = fixtures::principal();
+        let calling_principal = fixtures::principal_a();
         let request = CreateProposalReviewRequest {
             proposal_id: "proposal_id".to_string(),
             summary: Some("summary".to_string()),
@@ -333,7 +333,7 @@ mod tests {
 
     #[rstest]
     fn update_proposal_review() {
-        let calling_principal = fixtures::principal();
+        let calling_principal = fixtures::principal_a();
         let request = UpdateProposalReviewRequest {
             proposal_id: fixtures::proposal_id().to_string(),
             status: None,
@@ -369,7 +369,7 @@ mod tests {
 
     #[rstest]
     fn update_proposal_review_unauthorized() {
-        let calling_principal = fixtures::principal();
+        let calling_principal = fixtures::principal_a();
         let request = UpdateProposalReviewRequest {
             proposal_id: fixtures::proposal_id().to_string(),
             status: None,
@@ -409,7 +409,7 @@ mod tests {
 
     #[rstest]
     async fn create_proposal_review_image() {
-        let calling_principal = fixtures::principal();
+        let calling_principal = fixtures::principal_a();
         let request = CreateProposalReviewImageRequest {
             proposal_id: fixtures::proposal_id().to_string(),
             content_type: "image/png".to_string(),
@@ -448,7 +448,7 @@ mod tests {
 
     #[rstest]
     async fn create_proposal_review_image_unauthorized() {
-        let calling_principal = fixtures::principal();
+        let calling_principal = fixtures::principal_a();
         let request = CreateProposalReviewImageRequest {
             proposal_id: fixtures::proposal_id().to_string(),
             content_type: "image/png".to_string(),
@@ -486,7 +486,7 @@ mod tests {
 
     #[rstest]
     async fn delete_proposal_review_image() {
-        let calling_principal = fixtures::principal();
+        let calling_principal = fixtures::principal_a();
         let request = DeleteProposalReviewImageRequest {
             proposal_id: fixtures::proposal_id().to_string(),
             image_path: "/images/reviews/dummy-image-id".to_string(),
@@ -518,7 +518,7 @@ mod tests {
 
     #[rstest]
     async fn delete_proposal_review_image_unauthorized() {
-        let calling_principal = fixtures::principal();
+        let calling_principal = fixtures::principal_a();
         let request = DeleteProposalReviewImageRequest {
             proposal_id: fixtures::proposal_id().to_string(),
             image_path: "/images/reviews/dummy-image-id".to_string(),

src/backend/impl/src/controllers/user_profile_controller.rs

@@ -6,11 +6,19 @@ use crate::{
 };
 use backend_api::{
     ApiError, ApiResult, CreateMyUserProfileResponse, GetMyUserProfileHistoryResponse,
-    GetMyUserProfileResponse, UpdateMyUserProfileRequest, UpdateUserProfileRequest,
+    GetMyUserProfileResponse, ListReviewerProfilesResponse, UpdateMyUserProfileRequest,
+    UpdateUserProfileRequest,
 };
 use candid::Principal;
 use ic_cdk::*;
 
+#[query]
+fn list_reviewer_profiles() -> ApiResult<ListReviewerProfilesResponse> {
+    UserProfileController::default()
+        .list_reviewer_profiles()
+        .into()
+}
+
 #[query]
 fn get_my_user_profile() -> ApiResult<GetMyUserProfileResponse> {
     let calling_principal = caller();
@@ -84,6 +92,12 @@ impl<A: AccessControlService, U: UserProfileService> UserProfileController<A, U>
         }
     }
 
+    fn list_reviewer_profiles(&self) -> Result<ListReviewerProfilesResponse, ApiError> {
+        let profiles = self.user_profile_service.list_reviewer_profiles()?;
+
+        Ok(profiles)
+    }
+
     fn get_my_user_profile(
         &self,
         calling_principal: Principal,
@@ -163,16 +177,39 @@ mod tests {
     use super::*;
     use crate::{
         fixtures,
-        mappings::{map_get_my_user_profile_history_response, map_get_my_user_profile_response},
+        mappings::{
+            map_get_my_user_profile_history_response, map_get_my_user_profile_response,
+            map_list_reviewer_profiles_response,
+        },
         services::{MockAccessControlService, MockUserProfileService},
     };
     use backend_api::UserConfig;
     use mockall::predicate::*;
     use rstest::*;
 
+    #[rstest]
+    fn list_reviewer_profiles() {
+        let profiles = map_list_reviewer_profiles_response(vec![(
+            fixtures::user_id(),
+            fixtures::reviewer_user_profile(),
+        )]);
+
+        let mut service_mock = MockUserProfileService::new();
+        service_mock
+            .expect_list_reviewer_profiles()
+            .once()
+            .return_const(Ok(profiles.clone()));
+
+        let controller = UserProfileController::new(MockAccessControlService::new(), service_mock);
+
+        let result = controller.list_reviewer_profiles().unwrap();
+
+        assert_eq!(result, profiles);
+    }
+
     #[rstest]
     fn get_my_user_profile() {
-        let calling_principal = fixtures::principal();
+        let calling_principal = fixtures::principal_a();
         let profile =
             map_get_my_user_profile_response(fixtures::user_id(), fixtures::admin_user_profile());
 
@@ -224,7 +261,7 @@ mod tests {
 
     #[rstest]
     fn get_my_user_profile_no_profile() {
-        let calling_principal = fixtures::principal();
+        let calling_principal = fixtures::principal_a();
         let error = ApiError::not_found("User profile not found");
 
         let mut access_control_service_mock = MockAccessControlService::new();
@@ -253,7 +290,7 @@ mod tests {
 
     #[rstest]
     fn get_my_user_profile_history() {
-        let calling_principal = fixtures::principal();
+        let calling_principal = fixtures::principal_a();
         let profile_history =
             map_get_my_user_profile_history_response(fixtures::user_profile_history());
 
@@ -329,7 +366,7 @@ mod tests {
 
     #[rstest]
     async fn create_my_user_profile() {
-        let calling_principal = fixtures::principal();
+        let calling_principal = fixtures::principal_a();
         let profile = CreateMyUserProfileResponse {
             id: "id".to_string(),
             username: "username".to_string(),
@@ -387,7 +424,7 @@ mod tests {
 
     #[rstest]
     fn update_user_profile() {
-        let calling_principal = fixtures::principal();
+        let calling_principal = fixtures::principal_a();
         let user_id = fixtures::user_id();
         let request = UpdateUserProfileRequest {
             user_id: user_id.to_string(),
@@ -423,7 +460,7 @@ mod tests {
 
     #[rstest]
     fn update_my_user_profile() {
-        let calling_principal = fixtures::principal();
+        let calling_principal = fixtures::principal_a();
         let request = UpdateMyUserProfileRequest {
             username: Some("username".to_string()),
             config: None,
@@ -511,7 +548,7 @@ mod tests {
 
     #[rstest]
     fn update_user_profile_non_admin_principal() {
-        let calling_principal = fixtures::principal();
+        let calling_principal = fixtures::principal_a();
         let user_id = fixtures::user_id();
         let request = UpdateUserProfileRequest {
             user_id: user_id.to_string(),