Skip to content

Commit fbc5e66

Browse files
committed
fix: add vote to frontend review api
1 parent 3283e35 commit fbc5e66

2 files changed

Lines changed: 11 additions & 0 deletions

File tree

src/frontend/src/app/core/api/review/review-api.mapper.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ export function mapCreateProposalReviewRequest(
3434
review_duration_mins: toCandidOpt(req.reviewDurationMins),
3535
summary: toCandidOpt(req.summary),
3636
build_reproduced: toCandidOpt(req.buildReproduced),
37+
vote: [],
3738
};
3839
}
3940

@@ -47,6 +48,7 @@ export function mapUpdateProposalReviewRequest(
4748
review_duration_mins: toCandidOpt(req.reviewDurationMins),
4849
summary: toCandidOpt(req.summary),
4950
build_reproduced: toCandidOpt(req.buildReproduced),
51+
vote: [],
5052
};
5153
}
5254

src/frontend/src/app/core/api/review/review-api.service.spec.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ describe('ReviewApiService', () => {
6464
summary: [],
6565
review_duration_mins: [],
6666
build_reproduced: [],
67+
vote: [],
6768
};
6869
const commonApiResponse: CreateProposalReviewApiResponse = {
6970
ok: {
@@ -81,6 +82,7 @@ describe('ReviewApiService', () => {
8182
build_reproduced: [],
8283
images_paths: [],
8384
proposal_review_commits: [],
85+
vote: { unspecified: null },
8486
},
8587
},
8688
};
@@ -142,6 +144,7 @@ describe('ReviewApiService', () => {
142144
summary: [],
143145
review_duration_mins: [],
144146
build_reproduced: [],
147+
vote: [],
145148
};
146149
const commonApiResponse: UpdateProposalReviewApiResponse = {
147150
ok: null,
@@ -202,6 +205,7 @@ describe('ReviewApiService', () => {
202205
build_reproduced: [],
203206
images_paths: [],
204207
proposal_review_commits: [],
208+
vote: { unspecified: null },
205209
},
206210
},
207211
{
@@ -219,6 +223,7 @@ describe('ReviewApiService', () => {
219223
build_reproduced: [],
220224
images_paths: [],
221225
proposal_review_commits: [],
226+
vote: { unspecified: null },
222227
},
223228
},
224229
],
@@ -306,6 +311,7 @@ describe('ReviewApiService', () => {
306311
build_reproduced: [],
307312
images_paths: [],
308313
proposal_review_commits: [],
314+
vote: { unspecified: null },
309315
},
310316
},
311317
};
@@ -376,6 +382,7 @@ describe('ReviewApiService', () => {
376382
build_reproduced: [],
377383
images_paths: [],
378384
proposal_review_commits: [],
385+
vote: { unspecified: null },
379386
},
380387
},
381388
};
@@ -433,6 +440,7 @@ describe('ReviewApiService', () => {
433440
summary: [],
434441
review_duration_mins: [],
435442
build_reproduced: [],
443+
vote: [],
436444
};
437445
const commonGetApiRequest: GetMyProposalReviewApiRequest = {
438446
proposal_id: 'proposalId',
@@ -453,6 +461,7 @@ describe('ReviewApiService', () => {
453461
build_reproduced: [],
454462
images_paths: [],
455463
proposal_review_commits: [],
464+
vote: { unspecified: null },
456465
},
457466
},
458467
};

0 commit comments

Comments
 (0)