Making change to help with PR

Author: Jacknguyen4438

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -12,7 +12,11 @@
 
 function isProperFraction(numerator, denominator) {
   // TODO: Implement this function
- if ( numerator > 0 && denominator > 0 && denominator !==0 && numerator < denominator){
+  if(typeof numerator === "bigint"|| typeof denominator === "bigint"){
+    return false;
+  }
+
+ if ( numerator >= 0 && denominator >= 0 && denominator !==0 && numerator < denominator){
   return true;
  } else {
   return false

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -39,7 +39,11 @@ function getCardValue(card) {
     "K",
   ];
   const cardSuits = ["♠", "♥", "♦", "♣"];
-  let rank = card.slice(0,-1);
+  if (typeof card !== "string") {
+    throw new Error("Invalid card");
+  }
+
+  let rank = card.slice(0, -1);
   let suit = card.slice(-1);
   if (
     typeof card !== "string" ||
@@ -61,8 +65,6 @@ function getCardValue(card) {
   }
 }
 
-
-
 // The line below allows us to load the getCardValue function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.
 module.exports = getCardValue;
@@ -85,6 +87,7 @@ assertEquals(getCardValue("K♣"), 10);
 assertEquals(getCardValue("10♠"), 10);
 assertEquals(getCardValue("5♠"), 5);
 
+
 // Handling invalid cards
 try {
   getCardValue("invalid");

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -34,7 +34,7 @@ test(`should return "Reflex angle" when ( 180 < angle < 360)`, () => {
   expect(getAngleType(359)).toEqual("Reflex angle");
 });
 // Case 6: Invalid angles
-test(`should return "Invalid angle" when ( 0 < angle && angle > 360)`, () => {
+test(`should return "Invalid angle" when ( 0 < angle or angle > 360)`, () => {
   expect(getAngleType(-1)).toEqual("Invalid angle");
   expect(getAngleType(-10)).toEqual("Invalid angle");
   expect(getAngleType(361)).toEqual("Invalid angle");

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -5,20 +5,20 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 // TODO: Write tests in Jest syntax to cover all combinations of positives, negatives, zeros, and other categories.
 
 // Special case: numerator is zero
-test(`should return false when denominator is zero`, () => {
+test(`should return true when denominator is zero`, () => {
   expect(isProperFraction(1, 0)).toEqual(false);
 });
-test(`should return false when numerator is zero`, () => {
-  expect(isProperFraction(0, 1)).toEqual(false);
+test(`should return true when numerator is zero`, () => {
+  expect(isProperFraction(0, 1)).toEqual(true);
 });
-test(`should return false when numerator < denominator `, () => {
+test(`should return false when numerator value is negative `, () => {
   expect(isProperFraction(-1, 2)).toEqual(false);
 });
-test(`should return false when denominator < numerator`, () => {
+test(`should return false when denominator value is negative`, () => {
   expect(isProperFraction(1, -2)).toEqual(false);
 });
 test(`should return false when denominator is bigInt`, () => {
-  expect(isProperFraction(1, 23443243n)).toEqual(true);
+  expect(isProperFraction(1, 23443243n)).toEqual(false);
 });
 test(`should return false when numerator is infinity`, () => {
   expect(isProperFraction(23432434n, 10)).toEqual(false);

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -51,6 +51,9 @@ test("Should throw error for undefined", () => {
   expect(() => getCardValue(undefined)).toThrow("Invalid card");
 });
 
+test("Should throw error for the card value is number", () => {
+  expect(() => getCardValue(5)).toThrow("Invalid card");
+});
 // To learn how to test whether a function throws an error as expected in Jest,
 // please refer to the Jest documentation:
 // https://jestjs.io/docs/expect#tothrowerror