Remove --no-build flag and clean up project dependencies

Removed the `--no-build` flag from `dotnet pack` commands in `deterministic-build.yml` to ensure the project is built during
packaging. This affects both the initial package creation and verification steps.

In `Codebreaker.Analyzers.csproj`, removed the `<WarningsAsErrors />`  element, allowing warnings to no longer be treated as errors.
Also removed the `<PackageReference>` to `System.Text.Json`, as this was a workaround for the project or NuGet packaging.

Author: christiannagel

.github/workflows/deterministic-build.yml

@@ -89,7 +89,6 @@ jobs:
           echo "Creating deterministic NuGet package for ${{ matrix.solution.name }}..."
           dotnet pack ${{ matrix.solution.project }} \
             --configuration Release \
-            --no-build \
             --output ./packages \
             /p:ContinuousIntegrationBuild=true \
             /p:Deterministic=true \
@@ -110,7 +109,6 @@ jobs:
           echo "Building second time for verification..."
           dotnet pack ${{ matrix.solution.project }} \
             --configuration Release \
-            --no-build \
             --output ./packages-verify \
             /p:ContinuousIntegrationBuild=true \
             /p:Deterministic=true \

src/services/common/Codebreaker.GameAPIs.Analyzers/Codebreaker.Analyzers.csproj

@@ -20,17 +20,11 @@
     <!-- Suppress NU5017 warning for packages with no dependencies -->
     <NoWarn>$(NoWarn);NU5017</NoWarn>
     <MSBuildTreatWarningsAsErrors>false</MSBuildTreatWarningsAsErrors>
-    <WarningsAsErrors />
   </PropertyGroup>
 
   <ItemGroup>
     <None Include="docs/readme.md" Pack="true" PackagePath="\" />
     <None Include="Images/codebreaker.jpeg" Pack="true" PackagePath="\" />
   </ItemGroup>
 
-  <ItemGroup>
-    <!-- Add minimal dependency to satisfy NuGet packaging requirements -->
-    <PackageReference Include="System.Text.Json" />
-  </ItemGroup>
-
 </Project>