Implement requested changes: Move MockAnonymousUserService to tests and add PromoteAnonUser method

Co-authored-by: christiannagel <1908285+christiannagel@users.noreply.github.com>

Author: Copilot

src/services/identity/Codebreaker.Identity.Tests/AnonymousUserServiceTests.cs

@@ -44,6 +44,13 @@ public async Task DeleteAnonUsers_ShouldDeleteStaleAnonymousUsers()
         // In a real implementation, we would use a test double or wrapper for GraphServiceClient
     }
 
+    [Fact(Skip = "Requires mocking of GraphServiceClient which is challenging")]
+    public async Task PromoteAnonUser_ShouldPromoteAnonymousUser()
+    {
+        // This test would require extensive mocking of GraphServiceClient
+        // In a real implementation, we would use a test double or wrapper for GraphServiceClient
+    }
+
     [Fact]
     public void ServiceInitialization_WithValidOptions_ShouldNotThrow()
     {
@@ -84,12 +91,14 @@ private class GraphAnonymousUserServiceWrapper(
         IOptions<AnonymousUserOptions> options,
         ILogger<GraphAnonymousUserService> logger) : GraphAnonymousUserService(options, logger)
     {
-
         // We don't test the actual Graph API methods here
         public new Task<AnonymousUser> CreateAnonUser(string userName) =>
             Task.FromResult(new AnonymousUser());
 
         public new Task<int> DeleteAnonUsers() =>
             Task.FromResult(0);
+            
+        public new Task<AnonymousUser> PromoteAnonUser(string anonymousUserId, string email, string displayName, string password) =>
+            Task.FromResult(new AnonymousUser());
     }
 }

…ity/Services/MockAnonymousUserService.cs …entity.Tests/MockAnonymousUserService.cssrc/services/identity/Codebreaker.Identity/Services/MockAnonymousUserService.cs renamed to src/services/identity/Codebreaker.Identity.Tests/MockAnonymousUserService.cs src/services/identity/Codebreaker.Identity/Services/MockAnonymousUserService.cs renamed to src/services/identity/Codebreaker.Identity.Tests/MockAnonymousUserService.cs

@@ -1,7 +1,8 @@
 using Codebreaker.Identity.Models;
+using Codebreaker.Identity.Services;
 using Microsoft.Extensions.Logging;
 
-namespace Codebreaker.Identity.Services;
+namespace Codebreaker.Identity.Tests;
 
 /// <summary>
 /// A mock implementation of <see cref="IAnonymousUserService"/> for testing
@@ -54,6 +55,26 @@ public Task<int> DeleteAnonUsers()
         return Task.FromResult(count);
     }
 
+    /// <inheritdoc />
+    public Task<AnonymousUser> PromoteAnonUser(string anonymousUserId, string email, string displayName, string password)
+    {
+        _logger.LogInformation("Promoting mock anonymous user: {UserId}", anonymousUserId);
+
+        var user = _users.FirstOrDefault(u => u.Id == anonymousUserId);
+        if (user == null)
+        {
+            throw new InvalidOperationException($"User with ID {anonymousUserId} not found");
+        }
+
+        // Update the user properties
+        user.Email = email;
+        user.DisplayName = displayName;
+        user.Password = password;
+        user.LastLoginAt = DateTimeOffset.UtcNow;
+
+        return Task.FromResult(user);
+    }
+
     /// <summary>
     /// Gets the current anonymous users
     /// </summary>

src/services/identity/Codebreaker.Identity.Tests/MockAnonymousUserServiceTests.cs

@@ -97,6 +97,47 @@ public async Task DeleteAnonUsers_ShouldRemoveStaleUsers()
         Assert.Equal(recentUser.Id, remainingUsers[0].Id);
     }
 
+    [Fact]
+    public async Task PromoteAnonUser_ShouldUpdateUserProperties()
+    {
+        // Arrange
+        var service = new MockAnonymousUserService(_mockLogger.Object);
+        var user = await service.CreateAnonUser("AnonUser");
+        
+        string newEmail = "registered@example.com";
+        string newDisplayName = "Registered User";
+        string newPassword = "SecurePassword123!";
+
+        // Act
+        var result = await service.PromoteAnonUser(user.Id, newEmail, newDisplayName, newPassword);
+
+        // Assert
+        Assert.NotNull(result);
+        Assert.Equal(user.Id, result.Id);  // ID should remain the same
+        Assert.Equal(newEmail, result.Email);
+        Assert.Equal(newDisplayName, result.DisplayName);
+        Assert.Equal(newPassword, result.Password);
+        Assert.NotNull(result.LastLoginAt);  // Should set last login time
+        
+        // Verify the user was updated in the collection
+        var users = service.GetUsers();
+        Assert.Single(users);
+        Assert.Equal(newEmail, users[0].Email);
+        Assert.Equal(newDisplayName, users[0].DisplayName);
+    }
+
+    [Fact]
+    public async Task PromoteAnonUser_WithInvalidId_ShouldThrowException()
+    {
+        // Arrange
+        var service = new MockAnonymousUserService(_mockLogger.Object);
+        string invalidId = "non-existent-id";
+
+        // Act & Assert
+        await Assert.ThrowsAsync<InvalidOperationException>(async () => 
+            await service.PromoteAnonUser(invalidId, "email@example.com", "Display Name", "password"));
+    }
+
     [Fact]
     public void GetUsers_ShouldReturnReadOnlyListOfUsers()
     {

src/services/identity/Codebreaker.Identity.Tests/TestExtensions.cs

@@ -0,0 +1,21 @@
+using Codebreaker.Identity.Services;
+using Microsoft.Extensions.DependencyInjection;
+
+namespace Codebreaker.Identity.Tests;
+
+/// <summary>
+/// Extension methods for testing
+/// </summary>
+public static class TestExtensions
+{
+    /// <summary>
+    /// Adds a mock anonymous user service for testing purposes
+    /// </summary>
+    /// <param name="services">The service collection</param>
+    /// <returns>The service collection</returns>
+    public static IServiceCollection AddMockAnonymousUserService(this IServiceCollection services)
+    {
+        services.AddScoped<IAnonymousUserService, MockAnonymousUserService>();
+        return services;
+    }
+}

src/services/identity/Codebreaker.Identity/Extensions/ServiceCollectionExtensions.cs

@@ -34,15 +34,4 @@ public static IServiceCollection AddAnonymousUserService(
         services.AddScoped<IAnonymousUserService, GraphAnonymousUserService>();
         return services;
     }
-    
-    /// <summary>
-    /// Adds a mock anonymous user service for testing purposes
-    /// </summary>
-    /// <param name="services">The service collection</param>
-    /// <returns>The service collection</returns>
-    public static IServiceCollection AddMockAnonymousUserService(this IServiceCollection services)
-    {
-        services.AddScoped<IAnonymousUserService, MockAnonymousUserService>();
-        return services;
-    }
 }

src/services/identity/Codebreaker.Identity/Services/GraphAnonymousUserService.cs

@@ -177,6 +177,79 @@ createdAtObj is string createdAtStr &&
         }
     }
 
+    /// <inheritdoc />
+    public async Task<AnonymousUser> PromoteAnonUser(string anonymousUserId, string email, string displayName, string password)
+    {
+        _logger.LogInformation("Promoting anonymous user {UserId} to registered user", anonymousUserId);
+
+        try
+        {
+            // First, verify the user exists and is actually an anonymous user
+            var user = await _graphClient.Users[anonymousUserId].GetAsync(requestConfig =>
+            {
+                requestConfig.QueryParameters.Select = ["id", "displayName", "userPrincipalName", "mail", "extension_AnonymousUser"];
+            });
+
+            if (user == null)
+            {
+                throw new InvalidOperationException($"User with ID {anonymousUserId} not found");
+            }
+
+            // Verify this is an anonymous user
+            if (user.AdditionalData == null || 
+                !user.AdditionalData.TryGetValue("extension_AnonymousUser", out var isAnonObj) ||
+                isAnonObj is not bool isAnon || 
+                !isAnon)
+            {
+                throw new InvalidOperationException($"User with ID {anonymousUserId} is not an anonymous user");
+            }
+
+            // Update the user properties but keep the same ID
+            await _graphClient.Users[anonymousUserId].PatchAsync(new User
+            {
+                DisplayName = displayName,
+                UserPrincipalName = email,
+                Mail = email,
+                PasswordProfile = new PasswordProfile
+                {
+                    ForceChangePasswordNextSignIn = false,
+                    Password = password
+                },
+                // Remove the anonymous user flag and add promoted flag
+                AdditionalData = new Dictionary<string, object>
+                {
+                    { "extension_AnonymousUser", false },
+                    { "extension_PromotedAt", DateTimeOffset.UtcNow.ToString("o") }
+                }
+            });
+
+            // Get the updated user to return
+            var updatedUser = await _graphClient.Users[anonymousUserId].GetAsync();
+
+            if (updatedUser == null)
+            {
+                throw new InvalidOperationException($"Failed to retrieve updated user with ID {anonymousUserId}");
+            }
+
+            // Return the updated user details
+            return new AnonymousUser
+            {
+                Id = updatedUser.Id ?? anonymousUserId,
+                UserName = updatedUser.UserPrincipalName ?? email,
+                DisplayName = updatedUser.DisplayName ?? displayName,
+                Email = updatedUser.Mail ?? email,
+                Password = password,
+                CreatedAt = DateTimeOffset.Parse(user.AdditionalData?["extension_CreatedAt"]?.ToString() ?? DateTimeOffset.UtcNow.ToString()),
+                LastLoginAt = updatedUser.SignInActivity?.LastSignInDateTime ?? DateTimeOffset.UtcNow
+            };
+        }
+        catch (Exception ex)
+        {
+            _logger.LogError(ex, "Failed to promote anonymous user {UserId}: {Message}", anonymousUserId, ex.Message);
+            throw;
+        }
+    }
+
     private static string GenerateSecurePassword(int length)
     {
         const string uppercaseChars = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";

src/services/identity/Codebreaker.Identity/Services/IAnonymousUserService.cs

@@ -19,4 +19,14 @@ public interface IAnonymousUserService
     /// </summary>
     /// <returns>The number of deleted users</returns>
     Task<int> DeleteAnonUsers();
+
+    /// <summary>
+    /// Promotes an anonymous user to a registered user
+    /// </summary>
+    /// <param name="anonymousUserId">The ID of the anonymous user</param>
+    /// <param name="email">The email address for the registered user</param>
+    /// <param name="displayName">The display name for the registered user</param>
+    /// <param name="password">The password for the registered user</param>
+    /// <returns>The updated user object</returns>
+    Task<AnonymousUser> PromoteAnonUser(string anonymousUserId, string email, string displayName, string password);
 }