Add new inspectorServiceProvider() function to extensions_base.dart (flutter#3470)

Author: matt-ragonese

packages/devtools_app/lib/devtools_app.dart

@@ -16,6 +16,8 @@ export 'src/debugger/program_explorer_controller.dart';
 export 'src/debugger/span_parser.dart';
 export 'src/debugger/syntax_highlighter.dart';
 export 'src/error_badge_manager.dart';
+export 'src/extension_points/extensions_base.dart';
+export 'src/extension_points/extensions_external.dart';
 export 'src/globals.dart';
 export 'src/http/http_request_data.dart';
 export 'src/inspector/diagnostics.dart';

packages/devtools_app/lib/src/extension_points/extensions_base.dart

@@ -4,11 +4,14 @@
 
 import '../common_widgets.dart';
 import '../debugger/codeview.dart';
+import '../inspector/inspector_service.dart';
 
 abstract class DevToolsExtensionPoints {
   List<ScriptPopupMenuOption> buildExtraDebuggerScriptPopupMenuOptions();
 
   Link issueTrackerLink();
 
   String loadingAppSizeDataMessage();
+
+  InspectorServiceBase inspectorServiceProvider();
 }

packages/devtools_app/lib/src/extension_points/extensions_external.dart

@@ -4,6 +4,8 @@
 
 import '../common_widgets.dart';
 import '../debugger/codeview.dart';
+import '../globals.dart';
+import '../inspector/inspector_service.dart';
 import 'extensions_base.dart';
 
 class ExternalDevToolsExtensionPoints implements DevToolsExtensionPoints {
@@ -21,4 +23,8 @@ class ExternalDevToolsExtensionPoints implements DevToolsExtensionPoints {
   String loadingAppSizeDataMessage() {
     return 'Loading app size data. Please wait...';
   }
+
+  @override
+  InspectorServiceBase inspectorServiceProvider() =>
+      serviceManager.connectedApp.isFlutterAppNow ? InspectorService() : null;
 }

packages/devtools_app/lib/src/service_manager.dart

@@ -302,11 +302,7 @@ class ServiceConnectionManager {
       return;
     }
 
-    if (connectedApp.isFlutterAppNow) {
-      _inspectorService = InspectorService();
-    } else {
-      _inspectorService = null;
-    }
+    _inspectorService = devToolsExtensionPoints.inspectorServiceProvider();
 
     // Set up analytics dimensions for the connected app.
     await ga.setupUserApplicationDimensions();

packages/devtools_test/lib/flutter_test_environment.dart

@@ -97,6 +97,7 @@ class FlutterTestEnvironment {
       await preferencesController.init();
       setGlobal(ServiceConnectionManager, ServiceConnectionManager());
       setGlobal(PreferencesController, preferencesController);
+      setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
       await serviceManager.vmServiceOpened(
         _service,
         onClosed: Completer().future,