refactor: Hapus business logic fitur cron tracking didalam tracking bloc sekalian dengan event dan state-nya

Author: CoderJava

lib/feature/presentation/bloc/tracking/tracking_bloc.dart

@@ -3,11 +3,7 @@ import 'dart:async';
 import 'package:bloc/bloc.dart';
 import 'package:bloc_concurrency/bloc_concurrency.dart';
 import 'package:dipantau_desktop_client/core/util/helper.dart';
-import 'package:dipantau_desktop_client/feature/data/model/create_track/bulk_create_track_data_body.dart';
-import 'package:dipantau_desktop_client/feature/data/model/create_track/bulk_create_track_image_body.dart';
 import 'package:dipantau_desktop_client/feature/data/model/create_track/create_track_body.dart';
-import 'package:dipantau_desktop_client/feature/domain/usecase/bulk_create_track_data/bulk_create_track_data.dart';
-import 'package:dipantau_desktop_client/feature/domain/usecase/bulk_create_track_image/bulk_create_track_image.dart';
 import 'package:dipantau_desktop_client/feature/domain/usecase/create_track/create_track.dart';
 
 part 'tracking_event.dart';
@@ -16,19 +12,13 @@ part 'tracking_state.dart';
 
 class TrackingBloc extends Bloc<TrackingEvent, TrackingState> {
   final CreateTrack createTrack;
-  final BulkCreateTrackData bulkCreateTrackData;
   final Helper helper;
-  final BulkCreateTrackImage bulkCreateTrackImage;
 
   TrackingBloc({
     required this.createTrack,
-    required this.bulkCreateTrackData,
     required this.helper,
-    required this.bulkCreateTrackImage,
   }) : super(InitialTrackingState()) {
     on<CreateTimeTrackingEvent>(_onCreateTimeTrackingEvent, transformer: sequential());
-
-    on<CronTrackingEvent>(_onCronTrackingEvent, transformer: sequential());
   }
 
   FutureOr<void> _onCreateTimeTrackingEvent(
@@ -52,41 +42,4 @@ class TrackingBloc extends Bloc<TrackingEvent, TrackingState> {
     final errorMessage = helper.getErrorMessageFromFailure(failure);
     emit(FailureTrackingState(errorMessage: errorMessage));
   }
-
-  FutureOr<void> _onCronTrackingEvent(
-    CronTrackingEvent event,
-    Emitter<TrackingState> emit,
-  ) async {
-    final bodyData = event.bodyData;
-    final ids = <int>[];
-    if (bodyData != null) {
-      final result = await bulkCreateTrackData(
-        ParamsBulkCreateTrackData(
-          body: bodyData,
-        ),
-      );
-      if (result.response != null) {
-        ids.addAll(bodyData.data.where((element) => element.id != null).map((e) => e.id!));
-      }
-    }
-
-    final bodyImage = event.bodyImage;
-    final files = <String>[];
-    if (bodyImage != null) {
-      final result = await bulkCreateTrackImage(
-        ParamsBulkCreateTrackImage(
-          body: bodyImage,
-        ),
-      );
-      if (result.response != null) {
-        files.addAll(bodyImage.files);
-      }
-    }
-    emit(
-      SuccessCronTrackingState(
-        ids: ids,
-        files: files,
-      ),
-    );
-  }
 }

lib/feature/presentation/bloc/tracking/tracking_event.dart

@@ -17,19 +17,4 @@ class CreateTimeTrackingEvent extends TrackingEvent {
   String toString() {
     return 'CreateTimeTrackingEvent{body: $body, trackEntityId: $trackEntityId}';
   }
-}
-
-class CronTrackingEvent extends TrackingEvent {
-  final BulkCreateTrackDataBody? bodyData;
-  final BulkCreateTrackImageBody? bodyImage;
-
-  CronTrackingEvent({
-    required this.bodyData,
-    required this.bodyImage,
-  });
-
-  @override
-  String toString() {
-    return 'CronTrackingEvent{bodyData: $bodyData, bodyImage: $bodyImage}';
-  }
-}
+}

lib/feature/presentation/bloc/tracking/tracking_state.dart

@@ -32,19 +32,4 @@ class SuccessCreateTimeTrackingState extends TrackingState {
   String toString() {
     return 'SuccessCreateTimeTrackingState{files: $files, trackEntityId: $trackEntityId}';
   }
-}
-
-class SuccessCronTrackingState extends TrackingState {
-  final List<int> ids;
-  final List<String> files;
-
-  SuccessCronTrackingState({
-    required this.ids,
-    required this.files,
-  });
-
-  @override
-  String toString() {
-    return 'SuccessCronTrackingState{ids: $ids, files: $files}';
-  }
-}
+}

lib/injection_container.dart

@@ -72,9 +72,7 @@ void init() {
   sl.registerFactory(
     () => TrackingBloc(
       createTrack: sl(),
-      bulkCreateTrackData: sl(),
       helper: sl(),
-      bulkCreateTrackImage: sl(),
     ),
   );
   sl.registerFactory(

test/feature/presentation/bloc/tracking/tracking_bloc_test.dart

@@ -2,12 +2,8 @@ import 'dart:convert';
 
 import 'package:bloc_test/bloc_test.dart';
 import 'package:dipantau_desktop_client/core/error/failure.dart';
-import 'package:dipantau_desktop_client/feature/data/model/create_track/bulk_create_track_data_body.dart';
-import 'package:dipantau_desktop_client/feature/data/model/create_track/bulk_create_track_image_body.dart';
 import 'package:dipantau_desktop_client/feature/data/model/create_track/create_track_body.dart';
 import 'package:dipantau_desktop_client/feature/data/model/general/general_response.dart';
-import 'package:dipantau_desktop_client/feature/domain/usecase/bulk_create_track_data/bulk_create_track_data.dart';
-import 'package:dipantau_desktop_client/feature/domain/usecase/bulk_create_track_image/bulk_create_track_image.dart';
 import 'package:dipantau_desktop_client/feature/domain/usecase/create_track/create_track.dart';
 import 'package:dipantau_desktop_client/feature/presentation/bloc/tracking/tracking_bloc.dart';
 import 'package:flutter_test/flutter_test.dart';
@@ -19,20 +15,14 @@ import '../../../../helper/mock_helper.mocks.dart';
 void main() {
   late TrackingBloc bloc;
   late MockCreateTrack mockCreateTrack;
-  late MockBulkCreateTrackData mockBulkCreateTrackData;
   late MockHelper mockHelper;
-  late MockBulkCreateTrackImage mockBulkCreateTrackImage;
 
   setUp(() {
     mockCreateTrack = MockCreateTrack();
-    mockBulkCreateTrackData = MockBulkCreateTrackData();
     mockHelper = MockHelper();
-    mockBulkCreateTrackImage = MockBulkCreateTrackImage();
     bloc = TrackingBloc(
       createTrack: mockCreateTrack,
-      bulkCreateTrackData: mockBulkCreateTrackData,
       helper: mockHelper,
-      bulkCreateTrackImage: mockBulkCreateTrackImage,
     );
   });
 
@@ -144,48 +134,4 @@ void main() {
       },
     );
   });
-
-  group('cron tracking', () {
-    final bodyData = BulkCreateTrackDataBody.fromJson(
-      json.decode(
-        fixture('bulk_create_track_data_body.json'),
-      ),
-    );
-    final bodyImage = BulkCreateTrackImageBody.fromJson(
-      json.decode(
-        fixture('bulk_create_track_image_body.json'),
-      ),
-    );
-    final tEvent = CronTrackingEvent(
-      bodyData: bodyData,
-      bodyImage: bodyImage,
-    );
-    final paramsData = ParamsBulkCreateTrackData(body: bodyData);
-    final paramsImage = ParamsBulkCreateTrackImage(body: bodyImage);
-    final tResponse = GeneralResponse.fromJson(
-      json.decode(
-        fixture('general_response.json'),
-      ),
-    );
-
-    blocTest(
-      'pastikan emit [SuccessCronTrackingState] ketika terima event CronTrackingEvent dengan proses berhasil',
-      build: () {
-        final result = (failure: null, response: tResponse);
-        when(mockBulkCreateTrackData(any)).thenAnswer((_) async => result);
-        when(mockBulkCreateTrackImage(any)).thenAnswer((_) async => result);
-        return bloc;
-      },
-      act: (TrackingBloc bloc) {
-        return bloc.add(tEvent);
-      },
-      expect: () => [
-        isA<SuccessCronTrackingState>(),
-      ],
-      verify: (_) {
-        verify(mockBulkCreateTrackData(paramsData));
-        verify(mockBulkCreateTrackImage(paramsImage));
-      },
-    );
-  });
 }

test/feature/presentation/bloc/tracking/tracking_event_test.dart

@@ -26,22 +26,4 @@ void main() {
       },
     );
   });
-
-  group('CronTrackingEvent', () {
-    final tEvent = CronTrackingEvent(
-      bodyData: null,
-      bodyImage: null,
-    );
-
-    test(
-      'pastikan output dari fungsi toString',
-      () async {
-        // assert
-        expect(
-          tEvent.toString(),
-          'CronTrackingEvent{bodyData: ${tEvent.bodyData}, bodyImage: ${tEvent.bodyImage}}',
-        );
-      },
-    );
-  });
 }

test/feature/presentation/bloc/tracking/tracking_state_test.dart

@@ -34,22 +34,4 @@ void main() {
       },
     );
   });
-
-  group('SuccessCronTrackingState', () {
-    final tState = SuccessCronTrackingState(
-      ids: [],
-      files: [],
-    );
-
-    test(
-      'pastikan output dari fungsi toString',
-      () async {
-        // assert
-        expect(
-          tState.toString(),
-          'SuccessCronTrackingState{ids: ${tState.ids}, files: ${tState.files}}',
-        );
-      },
-    );
-  });
 }