Skip to content

Commit 7a1c8d1

Browse files
committed
build: fix alignment checker
1 parent 3d6915c commit 7a1c8d1

3 files changed

Lines changed: 7 additions & 18 deletions

File tree

build/Build.Android.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ partial class Build
4040

4141
var readElfTool = ToolResolver.GetTool(llvmReadElf);
4242

43-
var libDir = GetLibDirectory(variant: Variant);
43+
var libDir = GetLibDirectory(GetAlphaSkiaLibName(Variant), variant: Variant);
4444
var distPath = DistBasePath / libDir;
4545
var soFiles = distPath.GlobFiles("*.so").ToArray();
4646

build/Build.LibAlphaSkia.cs

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -248,18 +248,9 @@ void BuildAlphaSkia()
248248
var staticLibPath = DistBasePath / GetLibDirectory(variant: Variant.Static);
249249
var gnFlags = new Dictionary<string, string>();
250250

251-
string buildTarget;
252-
if (Variant == Variant.Static)
251+
var buildTarget = GetAlphaSkiaLibName(Variant);
252+
if (Variant == Variant.Jni)
253253
{
254-
buildTarget = "libalphaskia";
255-
}
256-
else if (Variant == Variant.Shared)
257-
{
258-
buildTarget = "libalphaskia";
259-
}
260-
else if (Variant == Variant.Jni)
261-
{
262-
buildTarget = "libalphaskiajni";
263254

264255
var alphaSkiaInclude = DistBasePath / "include";
265256
var jniInclude = JavaHome / "include";
@@ -293,8 +284,6 @@ void BuildAlphaSkia()
293284
}
294285
else if (Variant == Variant.Node)
295286
{
296-
buildTarget = "libalphaskianode";
297-
298287
if (OperatingSystem.IsWindows())
299288
{
300289
// windows requires a lib to link against, fetch it from the node downloads
@@ -309,10 +298,6 @@ void BuildAlphaSkia()
309298
AppendToFlagList(gnArgs, "extra_ldflags", "'-undefined', 'dynamic_lookup'");
310299
}
311300
}
312-
else
313-
{
314-
throw new ArgumentException("Unknown variant: " + Variant);
315-
}
316301

317302
if (TargetOs == TargetOperatingSystem.Windows)
318303
{

build/Build.Native.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,10 @@ string GetLibDirectory(string libName = "libskia", TargetOperatingSystem targetO
7070
return $"{libName.ToLowerInvariant()}-{targetOs?.RuntimeIdentifier}-{arch}-{variant}";
7171
}
7272

73+
static string GetAlphaSkiaLibName(Variant variant) => variant == Variant.Jni ? "libalphaskiajni"
74+
: variant == Variant.Node ? "libalphaskianode"
75+
: "libalphaskia";
76+
7377
Task GitSyncDepsCustom(string[] requiredDependencies)
7478
{
7579
var depsFile = SkiaPath / "DEPS";

0 commit comments

Comments
 (0)