Skip to content

Commit c0f26bb

Browse files
authored
Merge pull request #14 from Commencis/bugfix/secret-cpp-generation-error
Fix checking obfuscated value instead of key name on generating cpp file for secrets
2 parents 0c044d7 + 078f816 commit c0f26bb

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

secretsvaultplugin/src/main/kotlin/com/commencis/secretsvaultplugin/KeepSecretsTask.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -488,14 +488,15 @@ internal abstract class KeepSecretsTask : DefaultTask() {
488488
val (key, value) = secret
489489
val obfuscatedValue = Utils.encodeSecret(value, secretsVaultExtension.obfuscationKey.get())
490490
val cppText = secretsCpp.readText(Charset.defaultCharset())
491-
if (cppText.contains(obfuscatedValue)) {
491+
val keyName = "$JVM_NAME_PREFIX${secretKeyToIndexMap[key]}"
492+
if (cppText.contains(keyName)) {
492493
logWarning("Key already added in C++ !")
493494
return@forEach
494495
}
495496
secretsCpp.appendText(
496497
text = codeGenerator.getCppCode(
497498
packageName = kotlinPackage,
498-
keyName = "$JVM_NAME_PREFIX${secretKeyToIndexMap[key]}",
499+
keyName = keyName,
499500
obfuscatedValue = obfuscatedValue,
500501
fileName = fileName.removeSuffix(KOTLIN_FILE_NAME_SUFFIX),
501502
)

0 commit comments

Comments
 (0)