Fix issue for temporary remote not deleted after promotion validation

Author: ligangty

addons/promote/common/src/main/java/org/commonjava/indy/promote/validate/PromotionValidator.java

@@ -116,18 +116,29 @@ public ValidationRequest validate( PromoteRequest request, ValidationResult resu
     {
         ValidationRuleSet set = validationsManager.getRuleSetMatching( request.getTargetKey() );
 
-        final ArtifactStore store = getRequestStore( request, baseUrl );
-        final ValidationRequest req = new ValidationRequest( request, set, validationTools, store );
+        ArtifactStore source;
+        try
+        {
+            source = storeDataMgr.getArtifactStore( request.getSource() );
+        }
+        catch ( IndyDataException e )
+        {
+            throw new PromotionValidationException(
+                    String.format( "Failed to retrieve source ArtifactStore: %s for validation", request.getSource() ),
+                    e );
+        }
 
         if ( set != null )
         {
-            
+
             logger.debug( "Running validation rule-set for promotion: {}", set.getName() );
 
             result.setRuleSet( set.getName() );
             List<String> ruleNames = set.getRuleNames();
             if ( ruleNames != null && !ruleNames.isEmpty() )
             {
+                final ArtifactStore store = getRequestStore( request, baseUrl );
+                final ValidationRequest req = new ValidationRequest( request, set, validationTools, store );
                 try
                 {
                     DrainingExecutorCompletionService<PromotionValidationException> svc =
@@ -202,15 +213,19 @@ public ValidationRequest validate( PromoteRequest request, ValidationResult resu
                         }
                     }
                 }
-
+                return req;
+            }
+            else
+            {
+                logger.info( "No validation rules are defined for: {}", request.getTargetKey() );
+                return new ValidationRequest( request, set, validationTools, source );
             }
         }
         else
         {
             logger.info( "No validation rule-sets are defined for: {}", request.getTargetKey() );
+            return new ValidationRequest( request, set, validationTools, source );
         }
-
-        return req;
     }
 
     @Measure