Remove nested paralleledEach from default promotion groovy (#1222)

Author: ruhan1

addons/promote/common/src/main/data/promote/rules/artifact-refs-via.groovy

@@ -25,7 +25,7 @@ class ArtifactRefAvailability implements ValidationRule {
             if (it.endsWith(".pom")) {
                 def relationships = tools.getRelationshipsForPom(it, dc, request, verifyStoreKeys)
                 if (relationships != null) {
-                    tools.paralleledEach(relationships, { rel ->
+                    tools.forEach(relationships, { rel ->
                         def skip = false
                         if (rel.getType() == RelationshipType.DEPENDENCY) {
                             def dr = (DependencyRelationship) rel
@@ -42,7 +42,7 @@ class ArtifactRefAvailability implements ValidationRule {
                             def found = false
                             def foundPom = false
 
-                            tools.paralleledEach(verifyStoreKeys, { verifyStoreKey ->
+                            tools.forEach(verifyStoreKeys, { verifyStoreKey ->
                                 if (!found) {
                                     def txfr = tools.getTransfer(verifyStoreKey, path)
                                     logger.info("{} in {}: {}. Exists? {}", target, verifyStoreKey, txfr, txfr == null ? false : txfr.exists())

addons/promote/common/src/main/data/promote/rules/no-pre-existing-paths.groovy

@@ -16,7 +16,7 @@ class NoPreExistingPaths implements ValidationRule {
         tools.paralleledEach(request.getSourcePaths(), { it ->
             def aref = tools.getArtifact(it);
             if (aref != null) {
-                tools.paralleledEach(verifyStoreKeys, { verifyStoreKey ->
+                tools.forEach(verifyStoreKeys, { verifyStoreKey ->
                     if (tools.exists(verifyStoreKey, it)) {
                         errors.add(String.format("%s is already available in: %s", it, verifyStoreKey))
                     }

addons/promote/common/src/main/data/promote/rules/no-snapshots.groovy

@@ -26,7 +26,7 @@ class NoSnapshots implements ValidationRule {
 
                 def relationships = tools.getRelationshipsForPom(it, dc, request, verifyStoreKeys)
                 if (relationships != null) {
-                    tools.paralleledEach(relationships, { rel ->
+                    tools.forEach(relationships, { rel ->
                         def target = rel.getTarget()
                         if (!target.getVersionSpec().isRelease()) {
                             errors.add(String.format("%s uses a variable/snapshot version in: %s", target, it))

addons/promote/common/src/main/data/promote/rules/no-version-ranges.groovy

@@ -18,7 +18,7 @@ class NoVersionRanges implements ValidationRule {
             if (it.endsWith(".pom")) {
                 def relationships = tools.getRelationshipsForPom(it, dc, request, verifyStoreKeys)
                 if (relationships != null) {
-                    tools.paralleledEach(relationships, { rel ->
+                    tools.forEach(relationships, { rel ->
                         def target = rel.getTarget()
                         if (!target.getVersionSpec().isSingle()) {
                             errors.add(String.format("%s uses a compound version in: %s", target, it))