fix(client): allow searching inventory for players with police job or target with canSteal (#35)

Author: Devexity-fivem

client.lua

@@ -178,7 +178,7 @@ function client.openInventory(inv, data)
 
         local targetCoords = targetPed and GetEntityCoords(targetPed)
 
-        if not targetCoords or #(targetCoords - GetEntityCoords(playerPed)) > 1.8 or not (client.hasGroup(shared.police) or not Player(serverId).state.canSteal) then
+        if not targetCoords or #(targetCoords - GetEntityCoords(playerPed)) > 1.8 or (not client.hasGroup(shared.police) and not Player(serverId).state.canSteal) then
             return lib.notify({ id = 'inventory_right_access', type = 'error', description = locale('inventory_right_access') })
         end
     end
@@ -1376,7 +1376,7 @@ RegisterNetEvent('ox_inventory:setPlayerInventory', function(currentDrops, inven
 						local ped = GetPlayerPed(id)
 						local pedCoords = GetEntityCoords(ped)
 
-						if not id or #(playerCoords - pedCoords) > maxDistance or not (client.hasGroup(shared.police) or not Player(currentInventory.id).state.canSteal) then
+						if not id or #(playerCoords - pedCoords) > maxDistance or (not client.hasGroup(shared.police) and not Player(currentInventory.id).state.canSteal) then
 							client.closeInventory()
 							lib.notify({ id = 'inventory_lost_access', type = 'error', description = locale('inventory_lost_access') })
 						else

server.lua

@@ -290,10 +290,18 @@ lib.callback.register('ox_inventory:openInventory', function(source, invType, da
     if invType == 'player' and source ~= data then
         local serverId = type(data) == 'table' and data.id or data
 
-        if source == serverId or type(serverId) ~= 'number' or not Player(serverId).state.canSteal then return end
+        if source == serverId or type(serverId) ~= 'number' then return end
+
+        local left = Inventory(source)
+        if not left then return end
+
+        local isPolice = server.hasGroup(left, shared.police)
+        local isTargetStealable = Player(serverId).state.canSteal
+
+        if not isPolice and not isTargetStealable then return end
     end
 
-	return openInventory(source, invType, data)
+    return openInventory(source, invType, data)
 end)
 
 ---@param netId number