replaced os offset method with constant

Author: nielshulstaert

Writer/MzMlSpectrumWriter.cs

@@ -42,6 +42,7 @@ public class MzMlSpectrumWriter : SpectrumWriter
         private readonly XmlSerializer cvParamSerializer;
         private readonly XmlSerializerNamespaces mzMlNamespace;
         private readonly bool doIndexing;
+        private readonly int osOffset;
 
         private XmlWriter _writer;
 
@@ -51,6 +52,7 @@ public MzMlSpectrumWriter(ParseInput parseInput) : base(parseInput)
             mzMlNamespace = new XmlSerializerNamespaces();
             mzMlNamespace.Add(string.Empty, "http://psi.hupo.org/ms/mzml");
             doIndexing = ParseInput.OutputFormat == OutputFormat.IndexMzML;
+            osOffset = System.Environment.NewLine == "\n" ? 0 : 1;
         }
 
         /// <inheritdoc />
@@ -271,11 +273,11 @@ public override void Write(IRawDataPlus rawFile, int firstScanNumber, int lastSc
                             Writer.Flush();
                             if (spectrumOffSets.Count != 0)
                             {
-                                spectrumOffSets.Add(spectrum.id, Writer.BaseStream.Position + 6 + GetOsOffset());
+                                spectrumOffSets.Add(spectrum.id, Writer.BaseStream.Position + 6 + osOffset);
                             }
                             else
                             {
-                                spectrumOffSets.Add(spectrum.id, Writer.BaseStream.Position + 7 + GetOsOffset());
+                                spectrumOffSets.Add(spectrum.id, Writer.BaseStream.Position + 7 + osOffset);
                             }
                         }
 
@@ -308,11 +310,11 @@ public override void Write(IRawDataPlus rawFile, int firstScanNumber, int lastSc
                             Writer.Flush();
                             if (chromatogramOffSets.Count != 0)
                             {
-                                chromatogramOffSets.Add(chromatogram.id, Writer.BaseStream.Position + 6 + GetOsOffset());
+                                chromatogramOffSets.Add(chromatogram.id, Writer.BaseStream.Position + 6 + osOffset);
                             }
                             else
                             {
-                                chromatogramOffSets.Add(chromatogram.id, Writer.BaseStream.Position + 7 + GetOsOffset());
+                                chromatogramOffSets.Add(chromatogram.id, Writer.BaseStream.Position + 7 + osOffset);
                             }
                         }
 
@@ -332,7 +334,7 @@ public override void Write(IRawDataPlus rawFile, int firstScanNumber, int lastSc
                     _writer.Flush();
                     Writer.Flush();
 
-                    var indexListPosition = Writer.BaseStream.Position + GetOsOffset();              
+                    var indexListPosition = Writer.BaseStream.Position + osOffset;
 
                     //  indexList
                     _writer.WriteStartElement("indexList");
@@ -441,11 +443,6 @@ public override void Write(IRawDataPlus rawFile, int firstScanNumber, int lastSc
             }
         }
 
-        private int GetOsOffset()
-        {
-            return System.Environment.NewLine == "\n" ? 0 : 1;
-        }
-
         /// <summary>
         /// Populate the instrument configuration list
         /// </summary>