Skip to content

Commit 68f6c8a

Browse files
rubenvdlindeclaude
rubenvdlinde
and
claude
committed
fix: Fix falsed() typo in SettingsService + add #457 Postman tests
- Fix critical typo `isOpenRegisterInstalle === falsed(...)` → `isOpenRegisterInstalled(...) === false` that blocked Nextcloud upgrade cycle - Add 3 new Postman tests for #457 (koppeling deletion 400-error) - Fix #419 test auth (use admin credentials, move before session-bleeding tests) - Set lever_app_uuid in environment-local.json Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent eb72884 commit 68f6c8a

3 files changed

Lines changed: 252 additions & 138 deletions

File tree

‎lib/Service/SettingsService.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1158,7 +1158,7 @@ public function initialize(?string $minOpenRegisterVersion=self::MIN_OPENREGISTE
11581158
// Check if OpenRegister is installed and enabled.
11591159
$checkStart = microtime(true);
11601160

1161-
if ($this->isOpenRegisterInstalle === falsed(minVersion: $minOpenRegisterVersion)) {
1161+
if ($this->isOpenRegisterInstalled(minVersion: $minOpenRegisterVersion) === false) {
11621162
$error = 'OpenRegister is not installed or does not meet minimum version requirements';
11631163
$results['errors'][] = $error;
11641164
$this->logger->error('SettingsService: '.$error);

‎postman/environment-local.json‎

Lines changed: 181 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -2,42 +2,186 @@
22
"id": "softcat-local",
33
"name": "Softwarecatalogus - Local",
44
"values": [
5-
{ "key": "base_url", "value": "http://localhost:8080", "enabled": true },
6-
{ "key": "openregister_api", "value": "{{base_url}}/index.php/apps/openregister/api", "enabled": true },
7-
{ "key": "softwarecatalog_api", "value": "{{base_url}}/index.php/apps/softwarecatalog/api", "enabled": true },
8-
{ "key": "opencatalogi_api", "value": "{{base_url}}/index.php/apps/opencatalogi/api", "enabled": true },
9-
{ "key": "ocs_api", "value": "{{base_url}}/ocs/v2.php", "enabled": true },
10-
{ "key": "admin_user", "value": "admin", "enabled": true },
11-
{ "key": "admin_pass", "value": "admin", "enabled": true },
12-
{ "key": "test_password", "value": "WelcomeToTest2026", "enabled": true },
13-
{ "key": "current_user", "value": "", "enabled": true },
14-
{ "key": "current_password", "value": "", "enabled": true },
15-
{ "key": "register_name", "value": "voorzieningen", "enabled": true },
16-
{ "key": "register_id", "value": "3", "enabled": true },
17-
{ "key": "schema_applicatie", "value": "module", "enabled": true },
18-
{ "key": "schema_contactpersoon", "value": "contactpersoon", "enabled": true },
19-
{ "key": "schema_dienst", "value": "dienst", "enabled": true },
20-
{ "key": "schema_koppeling", "value": "koppeling", "enabled": true },
21-
{ "key": "schema_organisatie", "value": "organisatie", "enabled": true },
22-
{ "key": "schema_gebruik", "value": "gebruik", "enabled": true },
23-
{ "key": "register_gemma", "value": "vng-gemma", "enabled": true },
24-
{ "key": "schema_view", "value": "view", "enabled": true },
25-
{ "key": "lever_nc_uuid", "value": "", "enabled": true },
26-
{ "key": "lever_reg_uuid", "value": "", "enabled": true },
27-
{ "key": "gemeente_nc_uuid", "value": "", "enabled": true },
28-
{ "key": "gemeente_reg_uuid", "value": "", "enabled": true },
29-
{ "key": "samenwerking_nc_uuid", "value": "", "enabled": true },
30-
{ "key": "samenwerking_reg_uuid", "value": "", "enabled": true },
31-
{ "key": "lever2_nc_uuid", "value": "", "enabled": true },
32-
{ "key": "lever2_reg_uuid", "value": "", "enabled": true },
33-
{ "key": "lever_app_uuid", "value": "", "enabled": true },
34-
{ "key": "lever2_app_uuid", "value": "", "enabled": true },
35-
{ "key": "gemeente_app_uuid", "value": "", "enabled": true },
36-
{ "key": "lever_dienst_uuid", "value": "", "enabled": true },
37-
{ "key": "jan_contact_uuid", "value": "", "enabled": true },
38-
{ "key": "maria_contact_uuid", "value": "", "enabled": true },
39-
{ "key": "mark_contact_uuid", "value": "", "enabled": true },
40-
{ "key": "linda_contact_uuid", "value": "", "enabled": true }
5+
{
6+
"key": "base_url",
7+
"value": "http://localhost:8080",
8+
"enabled": true
9+
},
10+
{
11+
"key": "openregister_api",
12+
"value": "{{base_url}}/index.php/apps/openregister/api",
13+
"enabled": true
14+
},
15+
{
16+
"key": "softwarecatalog_api",
17+
"value": "{{base_url}}/index.php/apps/softwarecatalog/api",
18+
"enabled": true
19+
},
20+
{
21+
"key": "opencatalogi_api",
22+
"value": "{{base_url}}/index.php/apps/opencatalogi/api",
23+
"enabled": true
24+
},
25+
{
26+
"key": "ocs_api",
27+
"value": "{{base_url}}/ocs/v2.php",
28+
"enabled": true
29+
},
30+
{
31+
"key": "admin_user",
32+
"value": "admin",
33+
"enabled": true
34+
},
35+
{
36+
"key": "admin_pass",
37+
"value": "admin",
38+
"enabled": true
39+
},
40+
{
41+
"key": "test_password",
42+
"value": "WelcomeToTest2026",
43+
"enabled": true
44+
},
45+
{
46+
"key": "current_user",
47+
"value": "",
48+
"enabled": true
49+
},
50+
{
51+
"key": "current_password",
52+
"value": "",
53+
"enabled": true
54+
},
55+
{
56+
"key": "register_name",
57+
"value": "voorzieningen",
58+
"enabled": true
59+
},
60+
{
61+
"key": "register_id",
62+
"value": "3",
63+
"enabled": true
64+
},
65+
{
66+
"key": "schema_applicatie",
67+
"value": "module",
68+
"enabled": true
69+
},
70+
{
71+
"key": "schema_contactpersoon",
72+
"value": "contactpersoon",
73+
"enabled": true
74+
},
75+
{
76+
"key": "schema_dienst",
77+
"value": "dienst",
78+
"enabled": true
79+
},
80+
{
81+
"key": "schema_koppeling",
82+
"value": "koppeling",
83+
"enabled": true
84+
},
85+
{
86+
"key": "schema_organisatie",
87+
"value": "organisatie",
88+
"enabled": true
89+
},
90+
{
91+
"key": "schema_gebruik",
92+
"value": "gebruik",
93+
"enabled": true
94+
},
95+
{
96+
"key": "register_gemma",
97+
"value": "vng-gemma",
98+
"enabled": true
99+
},
100+
{
101+
"key": "schema_view",
102+
"value": "view",
103+
"enabled": true
104+
},
105+
{
106+
"key": "lever_nc_uuid",
107+
"value": "",
108+
"enabled": true
109+
},
110+
{
111+
"key": "lever_reg_uuid",
112+
"value": "",
113+
"enabled": true
114+
},
115+
{
116+
"key": "gemeente_nc_uuid",
117+
"value": "",
118+
"enabled": true
119+
},
120+
{
121+
"key": "gemeente_reg_uuid",
122+
"value": "",
123+
"enabled": true
124+
},
125+
{
126+
"key": "samenwerking_nc_uuid",
127+
"value": "",
128+
"enabled": true
129+
},
130+
{
131+
"key": "samenwerking_reg_uuid",
132+
"value": "",
133+
"enabled": true
134+
},
135+
{
136+
"key": "lever2_nc_uuid",
137+
"value": "",
138+
"enabled": true
139+
},
140+
{
141+
"key": "lever2_reg_uuid",
142+
"value": "",
143+
"enabled": true
144+
},
145+
{
146+
"key": "lever_app_uuid",
147+
"value": "00764440-cd3b-52fb-99ac-4e1b9189c324",
148+
"enabled": true
149+
},
150+
{
151+
"key": "lever2_app_uuid",
152+
"value": "",
153+
"enabled": true
154+
},
155+
{
156+
"key": "gemeente_app_uuid",
157+
"value": "",
158+
"enabled": true
159+
},
160+
{
161+
"key": "lever_dienst_uuid",
162+
"value": "",
163+
"enabled": true
164+
},
165+
{
166+
"key": "jan_contact_uuid",
167+
"value": "",
168+
"enabled": true
169+
},
170+
{
171+
"key": "maria_contact_uuid",
172+
"value": "",
173+
"enabled": true
174+
},
175+
{
176+
"key": "mark_contact_uuid",
177+
"value": "",
178+
"enabled": true
179+
},
180+
{
181+
"key": "linda_contact_uuid",
182+
"value": "",
183+
"enabled": true
184+
}
41185
],
42186
"_postman_variable_scope": "environment"
43-
}
187+
}

0 commit comments

Comments
 (0)