fix: Use positional args in imagePath() to fix NC version compatibility

rubenvdlinde · claude · rubenvdlinde · commit c3944ce7c680 · 2026-03-03T12:09:20.000+01:00
Named parameter 'appName:' breaks on Nextcloud versions where the concrete
URLGenerator still uses '$app' as the parameter name.

Co-Authored-By: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/lib/Sections/SoftwareCatalogAdmin.php b/lib/Sections/SoftwareCatalogAdmin.php
@@ -53,7 +53,8 @@ public function __construct(IL10N $l, IURLGenerator $urlGenerator)
      */
     public function getIcon(): string
     {
-        return $this->urlGenerator->imagePath(appName: 'core', file: 'actions/settings-dark.svg');
+        // phpcs:ignore -- named parameters unsafe for Nextcloud core methods (param names vary by NC version)
+        return $this->urlGenerator->imagePath('core', 'actions/settings-dark.svg');
     }//end getIcon()
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,8 @@ public function __construct(IL10N $l, IURLGenerator $urlGenerator)`
`53`	`53`	`*/`
`54`	`54`	`public function getIcon(): string`
`55`	`55`	`{`
`56`		`- return $this->urlGenerator->imagePath(appName: 'core', file: 'actions/settings-dark.svg');`
	`56`	`+ // phpcs:ignore -- named parameters unsafe for Nextcloud core methods (param names vary by NC version)`
	`57`	`+ return $this->urlGenerator->imagePath('core', 'actions/settings-dark.svg');`
`57`	`58`	`}//end getIcon()`
`58`	`59`
`59`	`60`	`/**`