Extract settings object, log some app version and settings on startup

Author: Ethan Bishop

src/Pdf2Html/Controllers/RootController.cs

@@ -1,14 +1,16 @@
 using System.Diagnostics;
 using System.Net.Mime;
 using System.Reflection;
-using System.Text.RegularExpressions;
+
 using Microsoft.AspNetCore.Mvc;
 
+using Pdf2Html.Settings;
+
 namespace Pdf2Html.Controllers;
 
 [ApiController]
 [Route("/")]
-public class RootController(ILogger<RootController> logger, IConfiguration configuration) : ControllerBase
+public class RootController(ILogger<RootController> logger, ConversionOptions conversionOptions) : ControllerBase
 {
     [HttpGet]
     public ActionResult Get()
@@ -57,11 +59,10 @@ public async Task<ActionResult> Post()
     private async Task<(bool Success, ICollection<string> logs)> ConvertAsync(string inputFile, string outputFile)
     {
         using var p = new Process();
-        string options = ToCommandLineArguments(configuration.GetSection("ConversionOptions").AsEnumerable());
         p.StartInfo = new ProcessStartInfo
         {
             FileName = "pdf2htmlEX",
-            Arguments = $"{options} --dest-dir={Path.GetDirectoryName(outputFile)} {inputFile} {Path.GetFileName(outputFile)}",
+            Arguments = $"{conversionOptions.CommandLineArguments} --dest-dir={Path.GetDirectoryName(outputFile)} {inputFile} {Path.GetFileName(outputFile)}",
             CreateNoWindow = true,
             RedirectStandardOutput = true,
             RedirectStandardError = true
@@ -91,13 +92,5 @@ void AddLog(string? log)
         return (p.ExitCode == 0, logs);
     }
 
-    internal static string ToCommandLineArguments(IEnumerable<KeyValuePair<string, string?>> options) =>
-        string.Join(' ', options.Where(kvp => kvp.Value != null).Select(kvp => $"--{ToKebabCase(kvp.Key.Replace("ConversionOptions:", ""))}={ValueToString(kvp.Value!)}"));
-
-    private static string ValueToString(string value) => bool.TryParse(value, out var boolValue) ? (boolValue ? "1" : "0") : value;
-
-    private static string ToKebabCase(string value) =>
-        Regex.Replace(value, "(?<!^)([A-Z][a-z]|(?<=[a-z])[A-Z0-9])", "-$1", RegexOptions.Compiled).Trim().ToLower();
-
     private static string FormatToMb(long bytesLength) => (bytesLength / 1024.0 / 1024.0).ToString("0.00 MB");
 }

src/Pdf2Html/Program.cs

@@ -1,10 +1,20 @@
+using Pdf2Html.Settings;
+
+using System.Diagnostics;
+using System.Reflection;
+
 var builder = WebApplication.CreateBuilder(args);
 builder.Logging.ClearProviders();
 builder.Logging.AddConsole();
 
 // Add services to the container.
 builder.Services.AddControllers();
+builder.Services.AddSingleton<ConversionOptions>();
 
 var app = builder.Build();
+var versionInfo = FileVersionInfo.GetVersionInfo(Assembly.GetExecutingAssembly().Location);
+app.Logger.LogInformation($"Starting {versionInfo.ProductName} {versionInfo.ProductVersion}");
+app.Logger.LogInformation($"Using pdf2htmlEX command line arguments: {app.Services.GetService<ConversionOptions>()!.CommandLineArguments}");
+
 app.MapControllers();
 app.Run();

src/Pdf2Html/Settings/ConversionOptions.cs

@@ -0,0 +1,16 @@
+using System.Text.RegularExpressions;
+
+namespace Pdf2Html.Settings;
+
+public class ConversionOptions(IConfiguration configuration)
+{
+    public string CommandLineArguments { get; } = ToCommandLineArguments(configuration.GetSection("ConversionOptions").AsEnumerable());
+
+    internal static string ToCommandLineArguments(IEnumerable<KeyValuePair<string, string?>> options) =>
+        string.Join(' ', options.Where(kvp => kvp.Value != null).Select(kvp => $"--{ToKebabCase(kvp.Key.Replace("ConversionOptions:", ""))}={ValueToString(kvp.Value!)}"));
+
+    private static string ValueToString(string value) => bool.TryParse(value, out var boolValue) ? (boolValue ? "1" : "0") : value;
+
+    private static string ToKebabCase(string value) =>
+        Regex.Replace(value, "(?<!^)([A-Z][a-z]|(?<=[a-z])[A-Z0-9])", "-$1", RegexOptions.Compiled).Trim().ToLower();
+}

tests/Unit.Tests/RootControllerTest.cs …sts/Unit.Tests/ConversionOptionsTests.cstests/Unit.Tests/RootControllerTest.cs renamed to tests/Unit.Tests/ConversionOptionsTests.cs tests/Unit.Tests/RootControllerTest.cs renamed to tests/Unit.Tests/ConversionOptionsTests.cs

@@ -1,8 +1,8 @@
-using Pdf2Html.Controllers;
+using Pdf2Html.Settings;
 
 namespace Unit.Tests;
 
-public class RootControllerTest
+public class ConversionOptionsTests
 {
     [Test]
     public void TestToCommandLineArguments()
@@ -14,7 +14,7 @@ public void TestToCommandLineArguments()
             { "ConversionOptions:Hello", "World!" },
             { "ConversionOptions:FizzBuzz", "5" },
         };
-        var result = RootController.ToCommandLineArguments(input);
+        var result = ConversionOptions.ToCommandLineArguments(input);
         Assert.That(result, Is.EqualTo("--foo-bar=1 --baz-blort=0 --hello=World! --fizz-buzz=5"));
     }
 }