Skip to content

Commit 6f0394a

Browse files
TK MUNSimon Wilson
authored andcommitted
DO NOT MERGE SystemUI: update signal level when broadcast is received
- Signal level updates should be updated whenever a signal change broadcast is received but it is failing to do so. - Only when state change broadcast is received, signal level was updated. (Ex: State: Idle -> State: Connected) Change-Id: I71d86782143b3440a042164a87af64c7bee97ae2 Signed-off-by: TK MUN <tk.mun@samsung.com>
1 parent 4c1e73b commit 6f0394a

1 file changed

Lines changed: 19 additions & 27 deletions

File tree

packages/SystemUI/src/com/android/systemui/statusbar/StatusBarPolicy.java

Lines changed: 19 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -512,10 +512,10 @@ public class StatusBarPolicy {
512512
private static final int sWimaxDisconnectedImg =
513513
R.drawable.stat_sys_data_wimax_signal_disconnected;
514514
private static final int sWimaxIdleImg = R.drawable.stat_sys_data_wimax_signal_idle;
515-
private boolean mIsWimaxConnected = false;
516515
private boolean mIsWimaxEnabled = false;
517516
private int mWimaxSignal = 0;
518517
private int mWimaxState = 0;
518+
private int mWimaxExtraState = 0;
519519

520520
// state of inet connection - 0 not connected, 100 connected
521521
private int mInetCondition = 0;
@@ -940,12 +940,6 @@ private void updateConnectivity(Intent intent) {
940940
break;
941941
case ConnectivityManager.TYPE_WIMAX:
942942
mInetCondition = inetCondition;
943-
if (info.isConnected()) {
944-
mIsWimaxConnected = true;
945-
mService.setIconVisibility("wimax", true);
946-
} else {
947-
mIsWimaxConnected = false;
948-
}
949943
updateWiMAX(intent);
950944
break;
951945
}
@@ -1332,42 +1326,40 @@ private final void updateWiMAX(Intent intent) {
13321326
final String action = intent.getAction();
13331327
int iconId = sWimaxDisconnectedImg;
13341328

1335-
if (action.equals(WimaxManagerConstants. WIMAX_ENABLED_STATUS_CHANGED)) {
1336-
int mWimaxStatus = intent.getIntExtra(WimaxManagerConstants.EXTRA_WIMAX_STATUS,
1329+
if (action.equals(WimaxManagerConstants.WIMAX_ENABLED_STATUS_CHANGED)) {
1330+
int wimaxStatus = intent.getIntExtra(WimaxManagerConstants.EXTRA_WIMAX_STATUS,
13371331
WimaxManagerConstants.WIMAX_STATUS_DISABLED);
1338-
switch(mWimaxStatus) {
1332+
switch(wimaxStatus) {
13391333
case WimaxManagerConstants.WIMAX_STATUS_ENABLED:
13401334
mIsWimaxEnabled = true;
13411335
break;
13421336
case WimaxManagerConstants.WIMAX_STATUS_DISABLED:
13431337
mIsWimaxEnabled = false;
13441338
break;
13451339
}
1340+
mService.setIconVisibility("wimax", mIsWimaxEnabled);
13461341
} else if (action.equals(WimaxManagerConstants.SIGNAL_LEVEL_CHANGED_ACTION)) {
13471342
mWimaxSignal = intent.getIntExtra(WimaxManagerConstants.EXTRA_NEW_SIGNAL_LEVEL, 0);
13481343
} else if (action.equals(WimaxManagerConstants.WIMAX_STATE_CHANGED_ACTION)) {
13491344
mWimaxState = intent.getIntExtra(WimaxManagerConstants.EXTRA_WIMAX_STATE,
13501345
WimaxManagerConstants.WIMAX_STATE_UNKNOWN);
1351-
int mExtraWimaxState = intent.getIntExtra(
1346+
mWimaxExtraState = intent.getIntExtra(
13521347
WimaxManagerConstants.EXTRA_WIMAX_STATE_DETAIL,
13531348
WimaxManagerConstants.WIMAX_DEREGISTRATION);
1354-
1355-
switch(mWimaxState) {
1356-
case WimaxManagerConstants.WIMAX_STATE_DISCONNECTED:
1357-
iconId = sWimaxDisconnectedImg;
1358-
break;
1359-
case WimaxManagerConstants.WIMAX_STATE_CONNECTED:
1360-
if(mExtraWimaxState == WimaxManagerConstants.WIMAX_IDLE) {
1361-
iconId = sWimaxIdleImg;
1362-
}
1363-
else {
1364-
iconId = sWimaxSignalImages[mInetCondition][mWimaxSignal];
1365-
}
1366-
break;
1367-
}
1368-
mService.setIcon("wimax", iconId, 0);
13691349
}
1370-
mService.setIconVisibility("wimax", mIsWimaxEnabled);
1350+
switch(mWimaxState) {
1351+
case WimaxManagerConstants.WIMAX_STATE_DISCONNECTED:
1352+
iconId = sWimaxDisconnectedImg;
1353+
break;
1354+
case WimaxManagerConstants.WIMAX_STATE_CONNECTED:
1355+
if(mWimaxExtraState == WimaxManagerConstants.WIMAX_IDLE) {
1356+
iconId = sWimaxIdleImg;
1357+
} else {
1358+
iconId = sWimaxSignalImages[mInetCondition][mWimaxSignal];
1359+
}
1360+
break;
1361+
}
1362+
if (mIsWimaxEnabled) mService.setIcon("wimax", iconId, 0);
13711363
}
13721364

13731365
private final void updateGps(Intent intent) {

0 commit comments

Comments
 (0)