Skip to content

Commit d1d0743

Browse files
dsandlerAndroid (Google) Code Review
authored andcommitted
Merge "More debug logs for RSSI updates." into ics-factoryrom
2 parents bbb11b8 + c49e195 commit d1d0743

1 file changed

Lines changed: 23 additions & 7 deletions

File tree

packages/SystemUI/src/com/android/systemui/statusbar/policy/NetworkController.java

Lines changed: 23 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ public class NetworkController extends BroadcastReceiver {
8484
int mDataTypeIconId;
8585
boolean mDataActive;
8686
int mMobileActivityIconId; // overlay arrows for data direction
87+
int mLastSignalLevel;
8788

8889
String mContentDescriptionPhoneSignal;
8990
String mContentDescriptionWifi;
@@ -281,8 +282,9 @@ public void onReceive(Context context, Intent intent) {
281282
PhoneStateListener mPhoneStateListener = new PhoneStateListener() {
282283
@Override
283284
public void onSignalStrengthsChanged(SignalStrength signalStrength) {
284-
if (DEBUG) {
285-
Slog.d(TAG, "onSignalStrengthsChanged signalStrength=" + signalStrength);
285+
if (DEBUG || CHATTY) {
286+
Slog.d(TAG, "onSignalStrengthsChanged signalStrength=" + signalStrength +
287+
((signalStrength == null) ? "" : (" level=" + signalStrength.getLevel())));
286288
}
287289
mSignalStrength = signalStrength;
288290
updateTelephonySignalStrength();
@@ -315,14 +317,17 @@ public void onCallStateChanged(int state, String incomingNumber) {
315317

316318
@Override
317319
public void onDataConnectionStateChanged(int state, int networkType) {
318-
if (DEBUG || CHATTY) {
320+
if (DEBUG) {
319321
Slog.d(TAG, "onDataConnectionStateChanged: state=" + state
320322
+ " type=" + networkType);
321323
}
322324
mDataState = state;
323325
mDataNetType = networkType;
324326
if (state < 0) {
325327
// device without a data connection
328+
if (CHATTY) {
329+
Slog.d(TAG, "clearing mSignalStrength");
330+
}
326331
mSignalStrength = null;
327332
}
328333
updateDataNetType();
@@ -390,19 +395,23 @@ private void updateAirplaneMode() {
390395

391396
private final void updateTelephonySignalStrength() {
392397
if (!hasService()) {
393-
//Slog.d(TAG, "updateTelephonySignalStrength: no service");
398+
if (CHATTY) Slog.d(TAG, "updateTelephonySignalStrength: !hasService()");
394399
mPhoneSignalIconId = R.drawable.stat_sys_signal_0;
395400
mDataSignalIconId = R.drawable.stat_sys_signal_0;
396401
} else {
397402
if (mSignalStrength == null) {
403+
if (CHATTY) Slog.d(TAG, "updateTelephonySignalStrength: mSignalStrength == null");
398404
mPhoneSignalIconId = R.drawable.stat_sys_signal_0;
399405
mDataSignalIconId = R.drawable.stat_sys_signal_0;
400406
mContentDescriptionPhoneSignal = mContext.getString(
401407
AccessibilityContentDescriptions.PHONE_SIGNAL_STRENGTH[0]);
402408
} else {
403409
int iconLevel;
404410
int[] iconList;
405-
iconLevel = mSignalStrength.getLevel();
411+
mLastSignalLevel = iconLevel = mSignalStrength.getLevel();
412+
if (CHATTY) {
413+
Slog.d(TAG, "updateTelephonySignalStrength: signal level = " + iconLevel);
414+
}
406415
if (isCdma()) {
407416
if (isCdmaEri()) {
408417
iconList = TelephonyIcons.TELEPHONY_SIGNAL_STRENGTH_ROAMING[mInetCondition];
@@ -976,8 +985,10 @@ else if (!mDataConnected && !mWifiConnected && !mBluetoothTethered) {
976985
}
977986

978987
public void dump(FileDescriptor fd, PrintWriter pw, String[] args) {
979-
pw.println("Network Controller state:");
988+
pw.println("NetworkController state:");
980989
pw.println(" - telephony ------");
990+
pw.print(" hasService()=");
991+
pw.println(hasService());
981992
pw.print(" mHspaDataDistinguishable=");
982993
pw.println(mHspaDataDistinguishable);
983994
pw.print(" mDataConnected=");
@@ -996,6 +1007,10 @@ public void dump(FileDescriptor fd, PrintWriter pw, String[] args) {
9961007
pw.println(TelephonyManager.getNetworkTypeName(mDataNetType));
9971008
pw.print(" mServiceState=");
9981009
pw.println(mServiceState);
1010+
pw.print(" mSignalStrength=");
1011+
pw.println(mSignalStrength);
1012+
pw.print(" mLastSignalLevel=");
1013+
pw.println(mLastSignalLevel);
9991014
pw.print(" mNetworkName=");
10001015
pw.println(mNetworkName);
10011016
pw.print(" mNetworkNameDefault=");
@@ -1035,7 +1050,7 @@ public void dump(FileDescriptor fd, PrintWriter pw, String[] args) {
10351050

10361051

10371052
pw.println(" - Bluetooth ----");
1038-
pw.print(" mBtReverseTethered=");
1053+
pw.print(" mBtReverseTethered=");
10391054
pw.println(mBluetoothTethered);
10401055

10411056
pw.println(" - connectivity ------");
@@ -1069,6 +1084,7 @@ public void dump(FileDescriptor fd, PrintWriter pw, String[] args) {
10691084
pw.println(getResourceName(mLastCombinedSignalIconId));
10701085
pw.print(" mLastLabel=");
10711086
pw.print(mLastLabel);
1087+
pw.println("");
10721088
}
10731089

10741090
private String getResourceName(int resId) {

0 commit comments

Comments
 (0)