Skip to content

Commit 41c713a

Browse files
committed
Merge remote-tracking branch 'origin/master-1.21-lts' into master-1.21
2 parents 7b239b6 + 52b0b1d commit 41c713a

5 files changed

Lines changed: 85 additions & 4 deletions

File tree

AGENTS.md

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,14 @@ When adding new features or fixing bugs:
6969
- **Always** add game tests when the feature interacts with Minecraft gameplay systems
7070
- Look at existing tests in the respective directories for examples of test patterns and conventions
7171

72+
### Testing advancements
73+
74+
When writing game tests for advancements, don't just call criterion triggers directly, but try to simulate actual game logic to invoke the criterion triggers indirectly.
75+
76+
### Test coverage
77+
78+
When adding new tests for the sake of increasing test coverage, you can measure coverage by running `./gradlew test runGameTestServer jacocoTestReport`, and checking the coverage output in `build/reports/jacoco/test/`.
79+
7280
## Building the Project
7381

7482
### Prerequisites
@@ -132,8 +140,6 @@ ln -s ../../scripts/pre-commit .git/hooks/pre-commit
132140
6. **Format code**: `./gradlew spotlessApply`
133141
7. **Commit**: Use clear, descriptive commit messages
134142

135-
## Project Dependencies
136-
137143
## Release Management
138144

139145
Version bumping and release management helper scripts are available in the [CyclopsMC/ReleaseHelpers](https://github.com/CyclopsMC/ReleaseHelpers) repository. These bash scripts assist with:
@@ -180,3 +186,18 @@ See `.github/workflows/ci.yml` for the full CI configuration.
180186
3. **Multi-loader compatibility**: Ensure changes work across all supported loaders
181187
4. **Build validation**: Never commit without running `build` (and `runGameTestServer` for MC 1.21+)
182188
5. **Code quality**: Follow existing patterns and conventions in the codebase
189+
190+
## Code changes across Minecraft updates
191+
192+
When I ask you to things such as "fix upmerge issues" or "update to the next Minecraft version",
193+
this means that I want you to help resolve compilation errors
194+
that were introduced due to upmerging code from an older minecraft version to a newer minecraft version.
195+
The old minecraft version can be found in the `.upmerge-src-branch` file of the parent directory,
196+
and the new minecraft version can be found in `gradle.properties`.
197+
Changes may also include fixing merge conflicts.
198+
199+
IMPORTANT: Some changes may be non-trivial,
200+
for which you can find detail background information for each seperate Minecraft update within these primers: https://github.com/neoforged/.github/tree/main/primers
201+
The blogs of https://neoforged.net/ and https://fabricmc.net/blog/ may also contain useful porting help.
202+
203+
After making all necessary changes, make sure the code fully compiles and the (game) tests pass.

CHANGELOG-1.20.1.md

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,23 @@
11
# Changelog for Minecraft 1.20.1
22
All notable changes to this project will be documented in this file.
33

4+
<a name="1.20.1-1.4.5"></a>
5+
## [1.20.1-1.4.5](/compare/1.20.1-1.4.4...1.20.1-1.4.5) - 2026-03-09 08:58:52
6+
7+
8+
### Fixed
9+
* Fix the reusable ingredients in chains of recipes blocking each other (#187)
10+
11+
If the same reusable ingredient would be used within a chain of dependent
12+
recipes, the ingredient could be used in a dependent recipe, thereby blocking
13+
the dependency recipe.
14+
15+
This change ensures that dependency-less recipes first get to use the reusable ingredients.
16+
17+
Closes #182
18+
419
<a name="1.20.1-1.4.4"></a>
5-
## [1.20.1-1.4.4](/compare/1.20.1-1.4.3...1.20.1-1.4.4) - 2026-02-12 16:47:55
20+
## [1.20.1-1.4.4](/compare/1.20.1-1.4.3...1.20.1-1.4.4) - 2026-02-12 16:47:55 +0100
621

722

823
### Fixed

CHANGELOG-1.21.1.md

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,25 @@
11
# Changelog for Minecraft 1.21.1
22
All notable changes to this project will be documented in this file.
33

4+
<a name="1.21.1-1.4.5"></a>
5+
## [1.21.1-1.4.5](https://github.com/CyclopsMC/IntegratedCrafting/compare/1.21.1-1.4.4...1.21.1-1.4.5) - 2026-03-09 16:17:51
6+
7+
8+
### Added
9+
* Add translations through Crowdin (#181)
10+
11+
### Fixed
12+
* Fix the reusable ingredients in chains of recipes blocking each other (#187)
13+
If the same reusable ingredient would be used within a chain of dependent
14+
recipes, the ingredient could be used in a dependent recipe, thereby blocking
15+
the dependency recipe.
16+
This change ensures that dependency-less recipes first get to use the reusable ingredients.
17+
Closes #182
18+
* Fix craft_planks.json: use "items" instead of "item" for MC 1.21 item predicate format
19+
* Fix insert_recipe_planks advancement condition
20+
421
<a name="1.21.1-1.4.4"></a>
5-
## [1.21.1-1.4.4](https://github.com/CyclopsMC/IntegratedCrafting/compare/1.21.1-1.4.3...1.21.1-1.4.4) - 2026-02-12 16:49:31
22+
## [1.21.1-1.4.4](https://github.com/CyclopsMC/IntegratedCrafting/compare/1.21.1-1.4.3...1.21.1-1.4.4) - 2026-02-12 16:49:31 +0100
623

724

825
### Fixed
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
As always, don't forget to backup your world before updating!
2+
Requires CyclopsCore version 1.18.4 or higher.
3+
4+
Fixes:
5+
* Fix the reusable ingredients in chains of recipes blocking each other (#187)
6+
7+
If the same reusable ingredient would be used within a chain of dependent
8+
recipes, the ingredient could be used in a dependent recipe, thereby blocking
9+
the dependency recipe.
10+
11+
This change ensures that dependency-less recipes first get to use the reusable ingredients.
12+
13+
Closes #182
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
As always, don't forget to backup your world before updating!
2+
Requires CyclopsCore version 1.26.2 or higher.
3+
4+
Additions:
5+
* Add translations through Crowdin (#181)
6+
7+
Fixes:
8+
* Fix the reusable ingredients in chains of recipes blocking each other (#187)
9+
If the same reusable ingredient would be used within a chain of dependent
10+
recipes, the ingredient could be used in a dependent recipe, thereby blocking
11+
the dependency recipe.
12+
This change ensures that dependency-less recipes first get to use the reusable ingredients.
13+
Closes #182
14+
* Fix craft_planks.json: use "items" instead of "item" for MC 1.21 item predicate format
15+
* Fix insert_recipe_planks advancement condition

0 commit comments

Comments
 (0)