Skip to content

Commit 664f839

Browse files
committed
Move base mod classes to common
1 parent 0183e5d commit 664f839

8 files changed

Lines changed: 44 additions & 59 deletions

File tree

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
package org.cyclops.structuredcrafting;
2+
3+
import org.cyclops.cyclopscore.config.extendedconfig.DummyConfigCommon;
4+
import org.cyclops.cyclopscore.helper.ModBaseCommon;
5+
6+
/**
7+
* A config with general options for this mod.
8+
* @author rubensworks
9+
*
10+
*/
11+
public class GeneralConfig extends DummyConfigCommon<ModBaseCommon<?>> {
12+
13+
public GeneralConfig(ModBaseCommon<?> mod) {
14+
super(mod, "general");
15+
}
16+
17+
}

loader-neoforge/src/main/java/org/cyclops/structuredcrafting/Reference.java renamed to loader-common/src/main/java/org/cyclops/structuredcrafting/Reference.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package org.cyclops.structuredcrafting;
22

3-
import org.cyclops.cyclopscore.helper.MinecraftHelpers;
4-
53
/**
64
* Class that can hold basic static things that are better not hard-coded
75
* like mod details, texture paths, ID's...
@@ -12,6 +10,5 @@ public final class Reference {
1210
// Mod info
1311
public static final String MOD_ID = "structuredcrafting";
1412
public static final String GA_TRACKING_ID = "UA-65307010-3";
15-
public static final String VERSION_URL = "https://raw.githubusercontent.com/CyclopsMC/Versions/master/" + MinecraftHelpers.getMinecraftVersionMajorMinor() + "/StructuredCrafting.txt";
1613

1714
}
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
package org.cyclops.structuredcrafting;
2+
3+
import net.minecraft.core.registries.Registries;
4+
import net.minecraft.resources.ResourceLocation;
5+
import net.minecraft.world.item.Item;
6+
import net.minecraft.world.level.block.Block;
7+
import org.cyclops.cyclopscore.config.DeferredHolderCommon;
8+
9+
/**
10+
* Referenced registry entries.
11+
* @author rubensworks
12+
*/
13+
public class RegistryEntriesCommon {
14+
15+
public static final DeferredHolderCommon<Item, Item> ITEM_STRUCTURED_CRAFTER = DeferredHolderCommon.create(Registries.ITEM, ResourceLocation.parse("structuredcrafting:structured_crafter"));
16+
17+
public static final DeferredHolderCommon<Block, Block> BLOCK_STRUCTURED_CRAFTER = DeferredHolderCommon.create(Registries.BLOCK, ResourceLocation.parse("structuredcrafting:structured_crafter"));
18+
19+
// TODO: when when move the following, rename this file
20+
// public static final DeferredHolderCommon<BlockEntityType<?>, BlockEntityType<?>> BLOCK_ENTITY_STRUCTURED_CRAFTER = DeferredHolderCommon.create(Registries.BLOCK_ENTITY_TYPE, ResourceLocation.parse("structuredcrafting:structured_crafter"));
21+
22+
}

loader-neoforge/src/main/java/org/cyclops/structuredcrafting/GeneralConfig.java

Lines changed: 0 additions & 45 deletions
This file was deleted.

loader-neoforge/src/main/java/org/cyclops/structuredcrafting/RegistryEntries.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
import net.minecraft.core.registries.Registries;
44
import net.minecraft.resources.ResourceLocation;
5-
import net.minecraft.world.item.Item;
6-
import net.minecraft.world.level.block.Block;
75
import net.minecraft.world.level.block.entity.BlockEntityType;
86
import net.neoforged.neoforge.registries.DeferredHolder;
97
import org.cyclops.structuredcrafting.blockentity.BlockEntityStructuredCrafter;
@@ -14,10 +12,6 @@
1412
*/
1513
public class RegistryEntries {
1614

17-
public static final DeferredHolder<Item, Item> ITEM_STRUCTURED_CRAFTER = DeferredHolder.create(Registries.ITEM, ResourceLocation.parse("structuredcrafting:structured_crafter"));
18-
19-
public static final DeferredHolder<Block, Block> BLOCK_STRUCTURED_CRAFTER = DeferredHolder.create(Registries.BLOCK, ResourceLocation.parse("structuredcrafting:structured_crafter"));
20-
2115
public static final DeferredHolder<BlockEntityType<?>, BlockEntityType<BlockEntityStructuredCrafter>> BLOCK_ENTITY_STRUCTURED_CRAFTER = DeferredHolder.create(Registries.BLOCK_ENTITY_TYPE, ResourceLocation.parse("structuredcrafting:structured_crafter"));
2216

2317
}

loader-neoforge/src/main/java/org/cyclops/structuredcrafting/StructuredCrafting.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,14 +68,14 @@ protected ICommonProxy constructCommonProxy() {
6868
@Override
6969
protected CreativeModeTab.Builder constructDefaultCreativeModeTab(CreativeModeTab.Builder builder) {
7070
return super.constructDefaultCreativeModeTab(builder)
71-
.icon(() -> new ItemStack(RegistryEntries.ITEM_STRUCTURED_CRAFTER));
71+
.icon(() -> new ItemStack(RegistryEntriesCommon.ITEM_STRUCTURED_CRAFTER));
7272
}
7373

7474
@Override
7575
protected void onConfigsRegister(ConfigHandler configHandler) {
7676
super.onConfigsRegister(configHandler);
7777

78-
configHandler.addConfigurable(new GeneralConfig());
78+
configHandler.addConfigurable(new GeneralConfig(this));
7979

8080
configHandler.addConfigurable(new BlockStructuredCrafterConfig());
8181
configHandler.addConfigurable(new BlockEntityStructuredCrafterConfig());

loader-neoforge/src/main/java/org/cyclops/structuredcrafting/block/BlockStructuredCrafter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ protected MapCodec<? extends BaseEntityBlock> codec() {
5151
@Override
5252
@Nullable
5353
public <T extends BlockEntity> BlockEntityTicker<T> getTicker(Level level, BlockState blockState, BlockEntityType<T> blockEntityType) {
54-
return level.isClientSide ? null : createTickerHelper(blockEntityType, RegistryEntries.BLOCK_ENTITY_STRUCTURED_CRAFTER.get(), new BlockEntityStructuredCrafter.Ticker());
54+
return level.isClientSide ? null : createTickerHelper(blockEntityType, RegistryEntries.BLOCK_ENTITY_STRUCTURED_CRAFTER.value(), new BlockEntityStructuredCrafter.Ticker());
5555
}
5656

5757
@Override

loader-neoforge/src/main/java/org/cyclops/structuredcrafting/blockentity/BlockEntityStructuredCrafterConfig.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import com.google.common.collect.Sets;
44
import net.minecraft.world.level.block.entity.BlockEntityType;
55
import org.cyclops.cyclopscore.config.extendedconfig.BlockEntityConfig;
6-
import org.cyclops.structuredcrafting.RegistryEntries;
6+
import org.cyclops.structuredcrafting.RegistryEntriesCommon;
77
import org.cyclops.structuredcrafting.StructuredCrafting;
88

99
/**
@@ -18,7 +18,7 @@ public BlockEntityStructuredCrafterConfig() {
1818
StructuredCrafting._instance,
1919
"structured_crafter",
2020
(eConfig) -> new BlockEntityType<>(BlockEntityStructuredCrafter::new,
21-
Sets.newHashSet(RegistryEntries.BLOCK_STRUCTURED_CRAFTER.get()), null)
21+
Sets.newHashSet(RegistryEntriesCommon.BLOCK_STRUCTURED_CRAFTER.value()), null)
2222
);
2323
}
2424

0 commit comments

Comments
 (0)