Merge remote-tracking branch 'origin/master-1.18' into master-1.19-lts

rubensworks · rubensworks · commit 85b23ef9aea1 · 2023-02-12T05:30:51.000+01:00
diff --git a/resources/changelog/1.18.2-0.2.4.txt b/resources/changelog/1.18.2-0.2.4.txt
@@ -0,0 +1,5 @@
+As always, don't forget to backup your world before updating!
+Requires CyclopsCore version 1.13.4 or higher.
+
+Fixes:
+* Fix input not consumed if output can not fully fit, Closes #31
diff --git a/src/api/java/org/cyclops/commoncapabilities/api b/src/api/java/org/cyclops/commoncapabilities/api
@@ -1 +1 @@
-Subproject commit e17ce03fedf23be5d2939648f4402b9c84baf099
+Subproject commit 41bc8ce0b6c10b595d066a660a57d232baaafc3b
diff --git a/src/main/java/org/cyclops/structuredcrafting/craft/WorldCraftingMatrix.java b/src/main/java/org/cyclops/structuredcrafting/craft/WorldCraftingMatrix.java
@@ -143,7 +143,10 @@ public boolean craft(boolean simulate) {
 
         // Determine output
         if(chosenPossibility != null && !itemStack.isEmpty()
-                && addItemStackForOutput(level, targetPos, targetSide, outputProviders, itemStack, simulate)) {
+                && addItemStackForOutput(level, targetPos, targetSide, outputProviders, itemStack, true)) {
+            if (!simulate) {
+                addItemStackForOutput(level, targetPos, targetSide, outputProviders, itemStack, simulate);
+            }
             chosenPossibility.handleRemainingItems(level, inputSide, simulate);
             return true;
         }
