Skip to content

Commit 8dad389

Browse files
committed
Merge branch 'master-1.11' into master-1.12
Conflicts: build.properties src/main/java/org/cyclops/structuredcrafting/Reference.java
2 parents 391634d + 00c5136 commit 8dad389

2 files changed

Lines changed: 11 additions & 3 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
As always, don't forget to backup your world before updating!
2+
Requires CyclopsCore version 0.10.6 or higher.
3+
4+
Fixes:
5+
* Fix empty inventories not being ignored during crafting, Closes #5

src/main/java/org/cyclops/structuredcrafting/craft/provider/InventoryItemStackProvider.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,15 +48,18 @@ public boolean isValidForResults(World world, BlockPos pos, EnumFacing side) {
4848
public boolean hasItemStack(World world, BlockPos pos, EnumFacing side) {
4949
IInventory inventory = TileHelpers.getSafeTile(world, pos, IInventory.class);
5050
IItemHandler itemHandler = TileHelpers.getCapability(world, pos, side, CapabilityItemHandler.ITEM_HANDLER_CAPABILITY);
51-
return (itemHandler != null && getFirstItem(itemHandler, side) != null)
52-
|| (inventory != null && getFirstItem(inventory, side) != null);
51+
return itemHandler != null || inventory != null;
5352
}
5453

5554
@Override
5655
public ItemStack getItemStack(World world, BlockPos pos, EnumFacing side) {
5756
IItemHandler itemHandler = TileHelpers.getCapability(world, pos, side, CapabilityItemHandler.ITEM_HANDLER_CAPABILITY);
5857
IInventory inventory = TileHelpers.getSafeTile(world, pos, IInventory.class);
59-
return itemHandler != null ? getFirstItem(itemHandler, side).getRight() : getFirstItem(inventory, side).getRight();
58+
Pair<Integer, ItemStack> result = itemHandler != null ? getFirstItem(itemHandler, side) : getFirstItem(inventory, side);
59+
if (result != null) {
60+
return result.getRight();
61+
}
62+
return ItemStack.EMPTY;
6063
}
6164

6265
@Override

0 commit comments

Comments
 (0)