Merge remote-tracking branch 'origin/master-1.19-lts' into master-1.19

Author: rubensworks

resources/changelog/1.18.2-0.2.4.txt

@@ -0,0 +1,5 @@
+As always, don't forget to backup your world before updating!
+Requires CyclopsCore version 1.13.4 or higher.
+
+Fixes:
+* Fix input not consumed if output can not fully fit, Closes #31

resources/changelog/1.19.2-0.2.5.txt

@@ -0,0 +1,5 @@
+As always, don't forget to backup your world before updating!
+Requires CyclopsCore version 1.17.0 or higher.
+
+Fixes:
+* Fix input not consumed if output can not fully fit, Closes #31

src/main/java/org/cyclops/structuredcrafting/craft/WorldCraftingMatrix.java

@@ -143,7 +143,10 @@ public boolean craft(boolean simulate) {
 
         // Determine output
         if(chosenPossibility != null && !itemStack.isEmpty()
-                && addItemStackForOutput(level, targetPos, targetSide, outputProviders, itemStack, simulate)) {
+                && addItemStackForOutput(level, targetPos, targetSide, outputProviders, itemStack, true)) {
+            if (!simulate) {
+                addItemStackForOutput(level, targetPos, targetSide, outputProviders, itemStack, simulate);
+            }
             chosenPossibility.handleRemainingItems(level, inputSide, simulate);
             return true;
         }