WIN32 hack did not work

Author: ChillerDragon

CMakeLists.txt

@@ -59,10 +59,6 @@ if(TARGET_OS STREQUAL "windows")
     add_compile_definitions(${target} PRIVATE _WIN32_WINNT=0x0600) # Minimum OS version (old macro, both must be defined)
     add_compile_definitions(${target} PRIVATE UNICODE) # Windows headers
     add_compile_definitions(${target} PRIVATE _UNICODE) # C-runtime
-
-    # twbl specific hack for #ifdef WIN32 checks
-    # to avoid detect.h on windows systems that dont define WIN32 like mingw
-    add_compile_definitions(${target} PRIVATE WIN32)
 endif()
 
 set(LINK_FLAGS_PLATFORM "")

src/tools/twbl_probe.cpp

@@ -1,5 +1,8 @@
 // TODO: windows https://github.com/dlfcn-win32/dlfcn-win32
-#ifdef WIN32
+
+#include <twbl/teeworlds/base/detect.h>
+
+#ifdef CONF_FAMILY_WINDOWS
 
 int main() { return 0; }
 

src/twbl/hotreload.cpp

@@ -1,7 +1,9 @@
 #include <cstdio>
 #include <cstdlib>
 
-#ifdef WIN32
+#include <twbl/teeworlds/base/detect.h>
+
+#ifdef CONF_FAMILY_WINDOWS
 // TODO: windows api
 #else
 #include <dlfcn.h>
@@ -59,7 +61,7 @@ void *CHotreloader::LoadTick(FTwbl_BotTick *ppfnBotTick)
 
 	UnloadTick();
 
-#ifdef WIN32
+#ifdef CONF_FAMILY_WINDOWS
 	return nullptr;
 #else
 	char aTickfunc[512];
@@ -106,7 +108,7 @@ void *CHotreloader::LoadTick(FTwbl_BotTick *ppfnBotTick)
 
 int CHotreloader::CloseHandle(void *pHandle)
 {
-#ifdef WIN32
+#ifdef CONF_FAMILY_WINDOWS
 	return 0;
 #else
 	return dlclose(pHandle);