quickfort orders auto-repeat instead of one-time

[SilasD]

Manager orders made by the quickfort tool should be one-time orders, but they repeat.

Reported on Discord by OllieEKH .

Verified. This quickfort-generated order does not show a frequency at all, and I expect it to repeat. I did not feel the need to play it out.

Contrast this to a similar order which has been edited in the work orders menu:

[SilasD]

Traced to a change in df.manager_orders:new()

This is a df.manager_order created in 53.10:

[lua]# o = df.manager_order:new()
[lua]# ~ o
<manager_order: 0x1b5fcd542e0>
id                       = 0
job_type                 = -1
item_type                = -1
item_subtype             = -1
reaction_name            =
mat_type                 = -1
mat_index                = -1
specflag                 = <job_spec_flags: 0x1b5fcd54318>
specdata                 = <job_spec_data: 0x1b5fcd5431c>
material_category        = <job_material_category: 0x1b5fcd54320>
art_spec                 = <manager_order.T_art_spec: 0x1b5fcd54324>
amount_left              = 0
amount_total             = 0
status                   = <manager_order_status: 0x1b5fcd54334>
frequency                = 0
finished_year            = -1
finished_year_tick       = -1
workshop_id              = -1
max_workshops            = 0
item_conditions          = <vector<manager_order_condition_item*>[0]: 0x1b5fcd54350>
order_conditions         = <vector<manager_order_condition_order*>[0]: 0x1b5fcd54368>
items                    = nil

And this is a df.manager_order created in 53.11:

[lua]# o = df.manager_order:new()
[lua]# ~ o
<manager_order: 0x18646943770>
id                       = 0
job_type                 = -1
item_type                = -1
item_subtype             = -1
reaction_name            =
mat_type                 = -1
mat_index                = -1
specflag                 = <job_spec_flags: 0x186469437a8>
specdata                 = <job_spec_data: 0x186469437ac>
material_category        = <job_material_category: 0x186469437b0>
art_spec                 = <manager_order.T_art_spec: 0x186469437b4>
amount_left              = 0
amount_total             = 0
status                   = <manager_order_status: 0x186469437c4>
frequency                = -1
finished_year            = -1
finished_year_tick       = -1
workshop_id              = -1
max_workshops            = 0
item_conditions          = <vector<manager_order_condition_item*>[0]: 0x186469437e0>
order_conditions         = <vector<manager_order_condition_order*>[0]: 0x186469437f8>
items                    = nil
[lua]#

The frequency field was 0 in 53.10, but is now -1.

[SilasD]

the obvious fix is to set order.frequency = df.workquota_frequency_type.OneTime (0) or some other valid value.

this will affect all tools that create manager orders.

in particular, the recent Discord reports of autoclothing, tailor, and autoslab generating way too many items are clearly related to this.

[ab9rf]

in particular, the recent Discord reports of autoclothing, tailor, and autoslab generating way too many items are clearly related to this.

Already fixed in #5470

[chdoc]

Can this issue be closed? The final comment on the pull request mentioned above suggests that this is the case.