Skip to content

feat(auth): add Monitoring role with read access to financial dashboard #3727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TaprootFreak wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat(auth): add Monitoring role with read access to financial dashboard #3727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/shared/auth/role.guard.ts
View file
Open in desktop

@davidleomay davidleomay May 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add [UserRole.MONITORING]: [UserRole.ADMIN, UserRole.SUPER_ADMIN], to additionalRoles -> can remove admin on dashboard controller endpoints

Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,16 @@ class RoleGuardClass implements CanActivate {
[UserRole.CLIENT_COMPANY]: [UserRole.KYC_CLIENT_COMPANY],
};

constructor(private readonly entryRole: UserRole) {}
constructor(private readonly entryRoles: UserRole[]) {}

canActivate(context: ExecutionContext): boolean {
const userRole = context.switchToHttp().getRequest().user?.role;
return this.entryRole === userRole || this.additionalRoles[this.entryRole]?.includes(userRole);
return this.entryRoles.some(
(entryRole) => entryRole === userRole || this.additionalRoles[entryRole]?.includes(userRole),
);
}
}

export function RoleGuard(entryRole: UserRole): RoleGuardClass {
return new RoleGuardClass(entryRole);
export function RoleGuard(...entryRoles: UserRole[]): RoleGuardClass {
return new RoleGuardClass(entryRoles);
}
1 change: 1 addition & 0 deletions src/shared/auth/user-role.enum.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export enum UserRole {
CUSTODY = 'Custody',
REALUNIT = 'RealUnit',
MARKETING = 'Marketing',
MONITORING = 'Monitoring',
DEBUG = 'Debug',

// service roles
Expand Down
10 changes: 5 additions & 5 deletions src/subdomains/supporting/dashboard/dashboard-financial.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export class DashboardFinancialController {
@Get('log')
@ApiBearerAuth()
@ApiExcludeEndpoint()
@UseGuards(AuthGuard(), RoleGuard(UserRole.ADMIN), UserActiveGuard())
@UseGuards(AuthGuard(), RoleGuard(UserRole.ADMIN, UserRole.COMPLIANCE, UserRole.MONITORING), UserActiveGuard())
async getFinancialLog(
@Query('from') from?: string,
@Query('dailySample') dailySample?: string,
Expand All @@ -35,7 +35,7 @@ export class DashboardFinancialController {
@Get('latest')
@ApiBearerAuth()
@ApiExcludeEndpoint()
@UseGuards(AuthGuard(), RoleGuard(UserRole.ADMIN), UserActiveGuard())
@UseGuards(AuthGuard(), RoleGuard(UserRole.ADMIN, UserRole.COMPLIANCE, UserRole.MONITORING), UserActiveGuard())
async getLatestBalance(): Promise<LatestBalanceResponseDto> {
const result = await this.dashboardFinancialService.getLatestBalance();
if (!result) throw new NotFoundException('No financial data available');
Expand All @@ -45,7 +45,7 @@ export class DashboardFinancialController {
@Get('changes/latest')
@ApiBearerAuth()
@ApiExcludeEndpoint()
@UseGuards(AuthGuard(), RoleGuard(UserRole.ADMIN), UserActiveGuard())
@UseGuards(AuthGuard(), RoleGuard(UserRole.ADMIN, UserRole.COMPLIANCE, UserRole.MONITORING), UserActiveGuard())
async getLatestChanges(): Promise<FinancialChangesEntryDto> {
const result = await this.dashboardFinancialService.getLatestFinancialChanges();
if (!result) throw new NotFoundException('No financial changes available');
Expand All @@ -55,15 +55,15 @@ export class DashboardFinancialController {
@Get('ref-recipients')
@ApiBearerAuth()
@ApiExcludeEndpoint()
@UseGuards(AuthGuard(), RoleGuard(UserRole.ADMIN), UserActiveGuard())
@UseGuards(AuthGuard(), RoleGuard(UserRole.ADMIN, UserRole.COMPLIANCE, UserRole.MONITORING), UserActiveGuard())
async getRefRewardRecipients(@Query('from') from?: string): Promise<RefRewardRecipientDto[]> {
return this.dashboardFinancialService.getRefRewardRecipients(this.parseDate(from));
}

@Get('changes')
@ApiBearerAuth()
@ApiExcludeEndpoint()
@UseGuards(AuthGuard(), RoleGuard(UserRole.ADMIN), UserActiveGuard())
@UseGuards(AuthGuard(), RoleGuard(UserRole.ADMIN, UserRole.COMPLIANCE, UserRole.MONITORING), UserActiveGuard())
async getFinancialChanges(
@Query('from') from?: string,
@Query('dailySample') dailySample?: string,
Expand Down